Revert "phy: apple: atc: Initialize USB2 PHY for host mode during probe"

This reverts commit eef91cd.

Author: jannau

drivers/phy/apple/atc.c

@@ -1788,8 +1788,12 @@ static int atcphy_configure(struct apple_atcphy *atcphy, enum atcphy_mode mode)
 	return 0;
 }
 
-static int _atcphy_usb2_set_mode(struct apple_atcphy *atcphy, enum phy_mode mode)
+static int atcphy_usb2_set_mode(struct phy *phy, enum phy_mode mode, int submode)
 {
+	struct apple_atcphy *atcphy = phy_get_drvdata(phy);
+
+	guard(mutex)(&atcphy->lock);
+
 	switch (mode) {
 	case PHY_MODE_USB_HOST:
 		set32(atcphy->regs.usb2phy + USB2PHY_SIG, USB2PHY_SIG_HOST);
@@ -1804,15 +1808,6 @@ static int _atcphy_usb2_set_mode(struct apple_atcphy *atcphy, enum phy_mode mode
 	return 0;
 }
 
-static int atcphy_usb2_set_mode(struct phy *phy, enum phy_mode mode, int submode)
-{
-	struct apple_atcphy *atcphy = phy_get_drvdata(phy);
-
-	guard(mutex)(&atcphy->lock);
-
-	return _atcphy_usb2_set_mode(atcphy, mode);
-}
-
 static const struct phy_ops apple_atc_usb2_phy_ops = {
 	.owner = THIS_MODULE,
 	.set_mode = atcphy_usb2_set_mode,
@@ -2231,14 +2226,6 @@ static int atcphy_probe_finalize(struct apple_atcphy *atcphy)
 	/* Reset dwc3 on probe, let dwc3 (consumer) deassert it */
 	_atcphy_dwc3_reset_assert(atcphy);
 
-	/*
-	 * Bring the USB2 up once in host mode. For not yet understood reasons
-	 * this avoids not detecting USB devices on the initial cold or hot
-	 * plug.
-	 */
-	atcphy_usb2_power_on(atcphy);
-	_atcphy_usb2_set_mode(atcphy, PHY_MODE_USB_HOST);
-
 	/* Reset atcphy to clear any state potentially left by the bootloader */
 	atcphy_usb2_power_off(atcphy);
 	atcphy_power_off(atcphy);