Skip to content

Commit 1ea7342

Browse files
jannaumarcan
authored andcommitted
dcp: Fix shutdown sequence on dptx errors
Signed-off-by: Janne Grunau <j@jannau.net>
1 parent 680f1c9 commit 1ea7342

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/dcp.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,13 @@ static int dcp_hdmi_dptx_init(dcp_dev_t *dcp, const display_config_t *cfg)
6464
dcp->dpav_ep = dcp_dpav_init(dcp);
6565
if (!dcp->dpav_ep) {
6666
printf("dcp: failed to initialize dpav endpoint\n");
67-
dcp_system_shutdown(dcp->system_ep);
6867
return -1;
6968
}
7069

7170
dcp->dptx_ep = dcp_dptx_init(dcp);
7271
if (!dcp->dptx_ep) {
7372
printf("dcp: failed to initialize dptx-port endpoint\n");
7473
dcp_dpav_shutdown(dcp->dpav_ep);
75-
dcp_system_shutdown(dcp->system_ep);
7674
return -1;
7775
}
7876

@@ -81,6 +79,8 @@ static int dcp_hdmi_dptx_init(dcp_dev_t *dcp, const display_config_t *cfg)
8179
dcp->system_ep = dcp_system_init(dcp);
8280
if (!dcp->system_ep) {
8381
printf("dcp: failed to initialize system endpoint\n");
82+
dcp_dptx_shutdown(dcp->dptx_ep);
83+
dcp_dpav_shutdown(dcp->dpav_ep);
8484
return -1;
8585
}
8686

@@ -187,8 +187,6 @@ dcp_dev_t *dcp_init(const display_config_t *cfg)
187187

188188
out_afk:
189189
afk_epic_shutdown(dcp->afk);
190-
rtkit_sleep(dcp->rtkit);
191-
pmgr_reset(dcp_die, dcp_pmgr_dev);
192190
out_rtkit:
193191
rtkit_quiesce(dcp->rtkit);
194192
rtkit_free(dcp->rtkit);
@@ -210,9 +208,9 @@ int dcp_shutdown(dcp_dev_t *dcp, bool sleep)
210208
sleep = false;
211209
}
212210
}
211+
dcp_system_shutdown(dcp->system_ep);
213212
dcp_dptx_shutdown(dcp->dptx_ep);
214213
dcp_dpav_shutdown(dcp->dpav_ep);
215-
dcp_system_shutdown(dcp->system_ep);
216214
free(dcp->phy);
217215
afk_epic_shutdown(dcp->afk);
218216
if (sleep) {

0 commit comments

Comments
 (0)