fix: return types for 400/404 for player/user/guild variables

pandinocoder · pandinocoder · commit 026afd94f52b · 2025-01-08T13:01:20.000+01:00
diff --git a/Intersect.Server/Web/RestApi/Routes/V1/GuildController.cs b/Intersect.Server/Web/RestApi/Routes/V1/GuildController.cs
@@ -269,7 +269,7 @@ public object Transfer(Guid guildId, LookupKey lookupKey)
         }
 
         [HttpGet("{guildId:guid}/bank")]
-        [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]
         [ProducesResponseType(typeof(IEnumerable<GuildBankSlot>), (int)HttpStatusCode.OK, "application/json")]
         public IActionResult ItemsListBank(Guid guildId)
         {
@@ -283,7 +283,7 @@ public IActionResult ItemsListBank(Guid guildId)
         }
 
         [HttpGet("{guildId:guid}/variables")]
-        [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]
         [ProducesResponseType(typeof(IEnumerable<GuildVariable>), (int)HttpStatusCode.OK, "application/json")]
         public IActionResult GuildVariablesList(Guid guildId)
         {
@@ -296,8 +296,8 @@ public IActionResult GuildVariablesList(Guid guildId)
         }
 
         [HttpGet("{guildId:guid}/variables/{variableId:guid}")]
-        [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]
-        [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]
         [ProducesResponseType(typeof(GuildVariable), (int)HttpStatusCode.OK, "application/json")]
         public IActionResult GuildVariableGet(Guid guildId, Guid variableId)
         {
@@ -321,8 +321,8 @@ public IActionResult GuildVariableGet(Guid guildId, Guid variableId)
         }
 
         [HttpGet("{guildId:guid}/variables/{variableId:guid}/value")]
-        [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]
-        [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]
         [ProducesResponseType(typeof(VariableValueBody), (int)HttpStatusCode.OK, "application/json")]
         public IActionResult GuildVariableGetValue(Guid guildId, Guid variableId)
         {
@@ -349,8 +349,8 @@ public IActionResult GuildVariableGetValue(Guid guildId, Guid variableId)
         }
 
         [HttpPost("{guildId:guid}/variables/{variableId:guid}")]
-        [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]
-        [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]
         [ProducesResponseType(typeof(GuildVariable), (int)HttpStatusCode.OK, "application/json")]
         public IActionResult GuildVariableSet(Guid guildId, Guid variableId, [FromBody] VariableValueBody valueBody)
         {
diff --git a/Intersect.Server/Web/RestApi/Routes/V1/PlayerController.cs b/Intersect.Server/Web/RestApi/Routes/V1/PlayerController.cs
@@ -298,8 +298,8 @@ public object ChangeName(LookupKey lookupKey, [FromBody] NameChange change)
         }
 
         [HttpGet("{lookupKey:LookupKey}/variables")]
-        [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]
-        [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]
         [ProducesResponseType(typeof(IEnumerable<PlayerVariable>), (int)HttpStatusCode.OK, "application/json")]
         public IActionResult PlayerVariablesList(LookupKey lookupKey)
         {
@@ -323,8 +323,8 @@ public IActionResult PlayerVariablesList(LookupKey lookupKey)
         }
 
         [HttpGet("{lookupKey:LookupKey}/variables/{variableId:guid}")]
-        [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]
-        [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]
         [ProducesResponseType(typeof(PlayerVariable), (int)HttpStatusCode.OK, "application/json")]
         public IActionResult PlayerVariableGet(LookupKey lookupKey, Guid variableId)
         {
@@ -354,8 +354,8 @@ public IActionResult PlayerVariableGet(LookupKey lookupKey, Guid variableId)
         }
 
         [HttpGet("{lookupKey:LookupKey}/variables/{variableId:guid}/value")]
-        [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]
-        [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]
         [ProducesResponseType(typeof(VariableValueBody), (int)HttpStatusCode.OK, "application/json")]
         public IActionResult PlayerVariableValueGet(LookupKey lookupKey, Guid variableId)
         {
@@ -388,8 +388,8 @@ public IActionResult PlayerVariableValueGet(LookupKey lookupKey, Guid variableId
         }
 
         [HttpPost("{lookupKey:LookupKey}/variables/{variableId:guid}")]
-        [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]
-        [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]
         [ProducesResponseType(typeof(PlayerVariable), (int)HttpStatusCode.OK, "application/json")]
         public IActionResult PlayerVariableSet(LookupKey lookupKey, Guid variableId, [FromBody] VariableValueBody valueBody)
         {
diff --git a/Intersect.Server/Web/RestApi/Routes/V1/UserController.cs b/Intersect.Server/Web/RestApi/Routes/V1/UserController.cs
@@ -868,8 +868,8 @@ public object UserSendPasswordResetEmailById(Guid userId)
         #region Variables
 
         [HttpGet("{lookupKey:LookupKey}/variables")]
-        [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]
-        [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]
         [ProducesResponseType(typeof(IEnumerable<UserVariable>), (int)HttpStatusCode.OK, "application/json")]
         public IActionResult UserVariablesList(LookupKey lookupKey)
         {
@@ -887,8 +887,8 @@ public IActionResult UserVariablesList(LookupKey lookupKey)
         }
 
         [HttpGet("{lookupKey:LookupKey}/variables/{variableId:guid}")]
-        [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]
-        [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]
         [ProducesResponseType(typeof(UserVariable), (int)HttpStatusCode.OK, "application/json")]
         public IActionResult UserVariableGet(LookupKey lookupKey, Guid variableId)
         {
@@ -917,8 +917,8 @@ public IActionResult UserVariableGet(LookupKey lookupKey, Guid variableId)
         }
 
         [HttpGet("{lookupKey:LookupKey}/variables/{variableId:guid}/value")]
-        [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]
-        [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]
         [ProducesResponseType(typeof(VariableValueBody), (int)HttpStatusCode.OK, "application/json")]
         public IActionResult UserVariableValueGet(LookupKey lookupKey, Guid variableId)
         {
@@ -950,8 +950,8 @@ public IActionResult UserVariableValueGet(LookupKey lookupKey, Guid variableId)
         }
 
         [HttpPost("{lookupKey:LookupKey}/variables/{variableId:guid}")]
-        [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]
-        [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]
+        [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]
         [ProducesResponseType(typeof(UserVariable), (int)HttpStatusCode.OK, "application/json")]
         public IActionResult UserVariableSet(LookupKey lookupKey, Guid variableId, [FromBody] VariableValueBody valueBody)
         {

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ public object Transfer(Guid guildId, LookupKey lookupKey)`
`269`	`269`	`}`
`270`	`270`
`271`	`271`	`[HttpGet("{guildId:guid}/bank")]`
`272`		`- [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]`
	`272`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]`
`273`	`273`	`[ProducesResponseType(typeof(IEnumerable<GuildBankSlot>), (int)HttpStatusCode.OK, "application/json")]`
`274`	`274`	`public IActionResult ItemsListBank(Guid guildId)`
`275`	`275`	`{`
`@@ -283,7 +283,7 @@ public IActionResult ItemsListBank(Guid guildId)`
`283`	`283`	`}`
`284`	`284`
`285`	`285`	`[HttpGet("{guildId:guid}/variables")]`
`286`		`- [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]`
	`286`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]`
`287`	`287`	`[ProducesResponseType(typeof(IEnumerable<GuildVariable>), (int)HttpStatusCode.OK, "application/json")]`
`288`	`288`	`public IActionResult GuildVariablesList(Guid guildId)`
`289`	`289`	`{`
`@@ -296,8 +296,8 @@ public IActionResult GuildVariablesList(Guid guildId)`
`296`	`296`	`}`
`297`	`297`
`298`	`298`	`[HttpGet("{guildId:guid}/variables/{variableId:guid}")]`
`299`		`- [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]`
`300`		`- [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]`
	`299`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]`
	`300`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]`
`301`	`301`	`[ProducesResponseType(typeof(GuildVariable), (int)HttpStatusCode.OK, "application/json")]`
`302`	`302`	`public IActionResult GuildVariableGet(Guid guildId, Guid variableId)`
`303`	`303`	`{`
`@@ -321,8 +321,8 @@ public IActionResult GuildVariableGet(Guid guildId, Guid variableId)`
`321`	`321`	`}`
`322`	`322`
`323`	`323`	`[HttpGet("{guildId:guid}/variables/{variableId:guid}/value")]`
`324`		`- [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]`
`325`		`- [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]`
	`324`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]`
	`325`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]`
`326`	`326`	`[ProducesResponseType(typeof(VariableValueBody), (int)HttpStatusCode.OK, "application/json")]`
`327`	`327`	`public IActionResult GuildVariableGetValue(Guid guildId, Guid variableId)`
`328`	`328`	`{`
`@@ -349,8 +349,8 @@ public IActionResult GuildVariableGetValue(Guid guildId, Guid variableId)`
`349`	`349`	`}`
`350`	`350`
`351`	`351`	`[HttpPost("{guildId:guid}/variables/{variableId:guid}")]`
`352`		`- [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]`
`353`		`- [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]`
	`352`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]`
	`353`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]`
`354`	`354`	`[ProducesResponseType(typeof(GuildVariable), (int)HttpStatusCode.OK, "application/json")]`
`355`	`355`	`public IActionResult GuildVariableSet(Guid guildId, Guid variableId, [FromBody] VariableValueBody valueBody)`
`356`	`356`	`{`
Original file line number	Diff line number	Diff line change
`@@ -298,8 +298,8 @@ public object ChangeName(LookupKey lookupKey, [FromBody] NameChange change)`
`298`	`298`	`}`
`299`	`299`
`300`	`300`	`[HttpGet("{lookupKey:LookupKey}/variables")]`
`301`		`- [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]`
`302`		`- [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]`
	`301`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]`
	`302`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]`
`303`	`303`	`[ProducesResponseType(typeof(IEnumerable<PlayerVariable>), (int)HttpStatusCode.OK, "application/json")]`
`304`	`304`	`public IActionResult PlayerVariablesList(LookupKey lookupKey)`
`305`	`305`	`{`
`@@ -323,8 +323,8 @@ public IActionResult PlayerVariablesList(LookupKey lookupKey)`
`323`	`323`	`}`
`324`	`324`
`325`	`325`	`[HttpGet("{lookupKey:LookupKey}/variables/{variableId:guid}")]`
`326`		`- [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]`
`327`		`- [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]`
	`326`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]`
	`327`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]`
`328`	`328`	`[ProducesResponseType(typeof(PlayerVariable), (int)HttpStatusCode.OK, "application/json")]`
`329`	`329`	`public IActionResult PlayerVariableGet(LookupKey lookupKey, Guid variableId)`
`330`	`330`	`{`
`@@ -354,8 +354,8 @@ public IActionResult PlayerVariableGet(LookupKey lookupKey, Guid variableId)`
`354`	`354`	`}`
`355`	`355`
`356`	`356`	`[HttpGet("{lookupKey:LookupKey}/variables/{variableId:guid}/value")]`
`357`		`- [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]`
`358`		`- [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]`
	`357`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]`
	`358`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]`
`359`	`359`	`[ProducesResponseType(typeof(VariableValueBody), (int)HttpStatusCode.OK, "application/json")]`
`360`	`360`	`public IActionResult PlayerVariableValueGet(LookupKey lookupKey, Guid variableId)`
`361`	`361`	`{`
`@@ -388,8 +388,8 @@ public IActionResult PlayerVariableValueGet(LookupKey lookupKey, Guid variableId`
`388`	`388`	`}`
`389`	`389`
`390`	`390`	`[HttpPost("{lookupKey:LookupKey}/variables/{variableId:guid}")]`
`391`		`- [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]`
`392`		`- [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]`
	`391`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]`
	`392`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]`
`393`	`393`	`[ProducesResponseType(typeof(PlayerVariable), (int)HttpStatusCode.OK, "application/json")]`
`394`	`394`	`public IActionResult PlayerVariableSet(LookupKey lookupKey, Guid variableId, [FromBody] VariableValueBody valueBody)`
`395`	`395`	`{`
Original file line number	Diff line number	Diff line change
`@@ -868,8 +868,8 @@ public object UserSendPasswordResetEmailById(Guid userId)`
`868`	`868`	`#region Variables`
`869`	`869`
`870`	`870`	`[HttpGet("{lookupKey:LookupKey}/variables")]`
`871`		`- [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]`
`872`		`- [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]`
	`871`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]`
	`872`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]`
`873`	`873`	`[ProducesResponseType(typeof(IEnumerable<UserVariable>), (int)HttpStatusCode.OK, "application/json")]`
`874`	`874`	`public IActionResult UserVariablesList(LookupKey lookupKey)`
`875`	`875`	`{`
`@@ -887,8 +887,8 @@ public IActionResult UserVariablesList(LookupKey lookupKey)`
`887`	`887`	`}`
`888`	`888`
`889`	`889`	`[HttpGet("{lookupKey:LookupKey}/variables/{variableId:guid}")]`
`890`		`- [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]`
`891`		`- [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]`
	`890`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]`
	`891`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]`
`892`	`892`	`[ProducesResponseType(typeof(UserVariable), (int)HttpStatusCode.OK, "application/json")]`
`893`	`893`	`public IActionResult UserVariableGet(LookupKey lookupKey, Guid variableId)`
`894`	`894`	`{`
`@@ -917,8 +917,8 @@ public IActionResult UserVariableGet(LookupKey lookupKey, Guid variableId)`
`917`	`917`	`}`
`918`	`918`
`919`	`919`	`[HttpGet("{lookupKey:LookupKey}/variables/{variableId:guid}/value")]`
`920`		`- [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]`
`921`		`- [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]`
	`920`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]`
	`921`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]`
`922`	`922`	`[ProducesResponseType(typeof(VariableValueBody), (int)HttpStatusCode.OK, "application/json")]`
`923`	`923`	`public IActionResult UserVariableValueGet(LookupKey lookupKey, Guid variableId)`
`924`	`924`	`{`
`@@ -950,8 +950,8 @@ public IActionResult UserVariableValueGet(LookupKey lookupKey, Guid variableId)`
`950`	`950`	`}`
`951`	`951`
`952`	`952`	`[HttpPost("{lookupKey:LookupKey}/variables/{variableId:guid}")]`
`953`		`- [ProducesResponseType(typeof(BadRequestObjectResult), (int)HttpStatusCode.BadRequest, "application/json")]`
`954`		`- [ProducesResponseType(typeof(NotFoundObjectResult), (int)HttpStatusCode.NotFound, "application/json")]`
	`953`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.BadRequest, "application/json")]`
	`954`	`+ [ProducesResponseType(typeof(string), (int)HttpStatusCode.NotFound, "application/json")]`
`955`	`955`	`[ProducesResponseType(typeof(UserVariable), (int)HttpStatusCode.OK, "application/json")]`
`956`	`956`	`public IActionResult UserVariableSet(LookupKey lookupKey, Guid variableId, [FromBody] VariableValueBody valueBody)`
`957`	`957`	`{`