Fixes 'Reset Defaults' button when modifying controls in-game, also auto defaults controls if they are all set to none to fix a previous broken state (#2759)

Author: jcsnider

Intersect.Client.Core/Core/Controls/Controls.cs

@@ -224,6 +224,16 @@ public bool TryLoad()
                 }
             }
 
+            // Check for corrupted controls bug (all bindings are None/None)
+            if (AreAllControlsBroken())
+            {
+                ApplicationContext.Context.Value?.Logger.LogWarning(
+                    "Detected broken control bindings (all None/None), resetting to defaults"
+                );
+                ResetDefaults();
+                TrySave();
+            }
+
             return success;
         }
         catch (Exception exception)
@@ -233,6 +243,25 @@ public bool TryLoad()
         }
     }
 
+    private bool AreAllControlsBroken()
+    {
+        // Check if all controls have all bindings set to None/None (broken state from old bug)
+        foreach (var (control, mapping) in Mappings)
+        {
+            foreach (var binding in mapping.Bindings)
+            {
+                // If we find any binding that's not None/None, controls are not broken
+                if (binding.Modifier != Keys.None || binding.Key != Keys.None)
+                {
+                    return false;
+                }
+            }
+        }
+
+        // All bindings are None/None, this is the broken state
+        return true;
+    }
+
     private bool TryLoadBindingFor(Control control, int bindingIndex, [NotNullWhen(true)] out ControlBinding? binding)
     {
         try

Intersect.Client.Framework/Input/BuiltinControlsProvider.cs

@@ -53,8 +53,17 @@ internal sealed class BuiltinControlsProvider : IControlsProvider
 
     public Control[] Controls { get; } = Enum.GetValues<Control>().Where(control => control.IsValid()).ToArray();
 
-    public bool TryGetDefaultMapping(Control control, [NotNullWhen(true)] out ControlMapping? defaultMapping) =>
-        _defaultMappings.TryGetValue(control, out defaultMapping);
+    public bool TryGetDefaultMapping(Control control, [NotNullWhen(true)] out ControlMapping? defaultMapping)
+    {
+        if (_defaultMappings.TryGetValue(control, out var mapping))
+        {
+            defaultMapping = new ControlMapping(mapping);
+            return true;
+        }
+
+        defaultMapping = null;
+        return false;
+    }
 
     public void ReloadFromOptions(Options? options)
     {