fix: Ban/Mute ObjectDisposedException and collection modification crashes in UI disposal (#2787)

- Use DelayedDelete() in BanMuteBox event handlers instead of direct Dispose()
- Canvas: Fix ProcessDelayedDeletes() to iterate over a copy of the disposal queue, preventing "Collection was modified" exceptions when nested DelayedDelete() calls occur during disposal
- Add error handling to catch and log disposal exceptions instead of crashing the entire client
- User Ban working and tested

Author: Arufonsu

Intersect.Client.Core/Interface/Game/Admin/BanMuteBox.cs

@@ -103,14 +103,14 @@ public BanMuteBox(string title, string prompt, EventHandler okayHandler) : base(
         buttonOkay.Clicked += (s, e) =>
         {
             okayHandler?.Invoke(this, EventArgs.Empty);
-            Dispose();
+            DelayedDelete();
         };
 
         var buttonCancel = new Button(this, "ButtonCancel")
         {
             Text = Strings.BanMute.Cancel,
         };
-        buttonCancel.Clicked += (s, e) => Dispose();
+        buttonCancel.Clicked += (s, e) => DelayedDelete();
 
         LoadJsonUi(UI.InGame, Graphics.Renderer?.GetResolutionString(), true);
 

Intersect.Client.Framework/Gwen/Control/Canvas.cs

@@ -262,21 +262,42 @@ public void AddDelayedDelete(Base control)
 
     private void ProcessDelayedDeletes()
     {
+        List<IDisposable> controlsToDispose;
+
         lock (_disposeQueue)
         {
-            foreach (var control in _disposeQueue)
+            if (_disposeQueue.Count == 0)
             {
+                return;
+            }
+
+            controlsToDispose = new List<IDisposable>(_disposeQueue);
+            _disposeQueue.Clear();
+
 #if DEBUG
-                if (control is Base node)
-                {
-                    _delayedDeleteStackTraces.Remove(node);
-                }
+            // Remove all the stuff from debug tracking in one go
+            _delayedDeleteStackTraces.Clear();
 #endif
+        }
 
+        // Dispose outside the lock
+        foreach (var control in controlsToDispose)
+        {
+            try
+            {
                 control.Dispose();
             }
-
-            _disposeQueue.Clear();
+            catch (ObjectDisposedException)
+            {
+                // Already disposed, ignore
+            }
+            catch (Exception ex)
+            {
+                ApplicationContext.Context.Value?.Logger.LogError(
+                    ex,
+                    "Error disposing control during ProcessDelayedDeletes"
+                );
+            }
         }
     }