Skip to content

Commit 561ccfb

Browse files
committed
cleaning up GameRenderer
1 parent c2c1d96 commit 561ccfb

File tree

10 files changed

+284
-301
lines changed

10 files changed

+284
-301
lines changed

Intersect.Client.Core/Core/Graphics.cs

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -552,15 +552,15 @@ public static void Render(TimeSpan deltaTime, TimeSpan totalTime)
552552
return;
553553
}
554554

555-
if (renderer.GetScreenWidth() != sOldWidth ||
556-
renderer.GetScreenHeight() != sOldHeight ||
555+
if (renderer.ScreenWidth != sOldWidth ||
556+
renderer.ScreenHeight != sOldHeight ||
557557
renderer.DisplayModeChanged())
558558
{
559559
sDarknessTexture = null;
560560
Interface.Interface.DestroyGwen();
561561
Interface.Interface.InitGwen();
562-
sOldWidth = renderer.GetScreenWidth();
563-
sOldHeight = renderer.GetScreenHeight();
562+
sOldWidth = renderer.ScreenWidth;
563+
sOldHeight = renderer.ScreenHeight;
564564
}
565565

566566
renderer.Clear(Color.Black);
@@ -811,22 +811,22 @@ public static void DrawFullScreenTexture(IGameTexture tex, float alpha = 1f)
811811
return;
812812
}
813813

814-
var bgx = Renderer.GetScreenWidth() / 2 - tex.Width / 2;
815-
var bgy = Renderer.GetScreenHeight() / 2 - tex.Height / 2;
814+
var bgx = Renderer.ScreenWidth / 2 - tex.Width / 2;
815+
var bgy = Renderer.ScreenHeight / 2 - tex.Height / 2;
816816
var bgw = tex.Width;
817817
var bgh = tex.Height;
818818
int diff;
819819

820-
if (bgw < Renderer.GetScreenWidth())
820+
if (bgw < Renderer.ScreenWidth)
821821
{
822-
diff = Renderer.GetScreenWidth() - bgw;
822+
diff = Renderer.ScreenWidth - bgw;
823823
bgx -= diff / 2;
824824
bgw += diff;
825825
}
826826

827-
if (bgh < Renderer.GetScreenHeight())
827+
if (bgh < Renderer.ScreenHeight)
828828
{
829-
diff = Renderer.GetScreenHeight() - bgh;
829+
diff = Renderer.ScreenHeight - bgh;
830830
bgy -= diff / 2;
831831
bgh += diff;
832832
}
@@ -845,8 +845,8 @@ public static void DrawFullScreenTextureCentered(IGameTexture tex, float alpha =
845845
return;
846846
}
847847

848-
var bgx = Renderer.GetScreenWidth() / 2 - tex.Width / 2;
849-
var bgy = Renderer.GetScreenHeight() / 2 - tex.Height / 2;
848+
var bgx = Renderer.ScreenWidth / 2 - tex.Width / 2;
849+
var bgy = Renderer.ScreenHeight / 2 - tex.Height / 2;
850850
var bgw = tex.Width;
851851
var bgh = tex.Height;
852852

@@ -867,7 +867,7 @@ public static void DrawFullScreenTextureStretched(IGameTexture tex)
867867
DrawGameTexture(
868868
tex, GetSourceRect(tex),
869869
new FloatRect(
870-
Renderer.GetView().X, Renderer.GetView().Y, Renderer.GetScreenWidth(), Renderer.GetScreenHeight()
870+
Renderer.GetView().X, Renderer.GetView().Y, Renderer.ScreenWidth, Renderer.ScreenHeight
871871
), Color.White
872872
);
873873
}
@@ -879,13 +879,13 @@ public static void DrawFullScreenTextureFitWidth(IGameTexture tex)
879879
return;
880880
}
881881

882-
var scale = Renderer.GetScreenWidth() / (float)tex.Width;
882+
var scale = Renderer.ScreenWidth / (float)tex.Width;
883883
var scaledHeight = tex.Height * scale;
884-
var offsetY = (Renderer.GetScreenHeight() - tex.Height) / 2f;
884+
var offsetY = (Renderer.ScreenHeight - tex.Height) / 2f;
885885
DrawGameTexture(
886886
tex, GetSourceRect(tex),
887887
new FloatRect(
888-
Renderer.GetView().X, Renderer.GetView().Y + offsetY, Renderer.GetScreenWidth(), scaledHeight
888+
Renderer.GetView().X, Renderer.GetView().Y + offsetY, Renderer.ScreenWidth, scaledHeight
889889
), Color.White
890890
);
891891
}
@@ -897,13 +897,13 @@ public static void DrawFullScreenTextureFitHeight(IGameTexture tex)
897897
return;
898898
}
899899

900-
var scale = Renderer.GetScreenHeight() / (float)tex.Height;
900+
var scale = Renderer.ScreenHeight / (float)tex.Height;
901901
var scaledWidth = tex.Width * scale;
902-
var offsetX = (Renderer.GetScreenWidth() - scaledWidth) / 2f;
902+
var offsetX = (Renderer.ScreenWidth - scaledWidth) / 2f;
903903
DrawGameTexture(
904904
tex, GetSourceRect(tex),
905905
new FloatRect(
906-
Renderer.GetView().X + offsetX, Renderer.GetView().Y, scaledWidth, Renderer.GetScreenHeight()
906+
Renderer.GetView().X + offsetX, Renderer.GetView().Y, scaledWidth, Renderer.ScreenHeight
907907
), Color.White
908908
);
909909
}
@@ -915,7 +915,7 @@ public static void DrawFullScreenTextureFitMinimum(IGameTexture tex)
915915
return;
916916
}
917917

918-
if (Renderer.GetScreenWidth() > Renderer.GetScreenHeight())
918+
if (Renderer.ScreenWidth > Renderer.ScreenHeight)
919919
{
920920
DrawFullScreenTextureFitHeight(tex);
921921
}
@@ -932,7 +932,7 @@ public static void DrawFullScreenTextureFitMaximum(IGameTexture tex)
932932
return;
933933
}
934934

935-
if (Renderer.GetScreenWidth() < Renderer.GetScreenHeight())
935+
if (Renderer.ScreenWidth < Renderer.ScreenHeight)
936936
{
937937
DrawFullScreenTextureFitHeight(tex);
938938
}
@@ -953,8 +953,8 @@ private static void UpdateView()
953953

954954
if (Globals.GameState != GameStates.InGame || !MapInstance.TryGet(Globals.Me?.MapId ?? Guid.Empty, out var map))
955955
{
956-
var sw = Renderer.GetScreenWidth();
957-
var sh = Renderer.GetScreenHeight();
956+
var sw = Renderer.ScreenWidth;
957+
var sh = Renderer.ScreenHeight;
958958
var sx = 0;
959959
var sy = 0;
960960
CurrentView = new FloatRect(sx, sy, sw / scale, sh / scale);
@@ -1062,7 +1062,7 @@ private static void ClearDarknessTexture()
10621062
return;
10631063
}
10641064

1065-
sDarknessTexture ??= Renderer.CreateRenderTexture(Renderer.GetScreenWidth(), Renderer.GetScreenHeight());
1065+
sDarknessTexture ??= Renderer.CreateRenderTexture(Renderer.ScreenWidth, Renderer.ScreenHeight);
10661066
sDarknessTexture.Clear(Color.Black);
10671067
}
10681068

Intersect.Client.Core/Interface/Debugging/DebugWindow.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ private Table CreateGPUStatisticsTable(Base parent)
314314
scroller.MinimumSize = minimumSize;
315315
};
316316

317-
table.AddRow(Strings.Debug.Fps, name: "FPSRow").Listen(1, new DelegateDataProvider<int>(() => Graphics.Renderer.Fps), NoValue);
317+
table.AddRow(Strings.Debug.Fps, name: "FPSRow").Listen(1, new DelegateDataProvider<int>(() => Graphics.Renderer.FPS), NoValue);
318318
// table.AddRow(Strings.Debug.Draws, name: "DrawsRow").Listen(1, new DelegateDataProvider<int>(() => Graphics.DrawCalls), NoValue);
319319

320320
table.AddRow(Strings.Debug.MapsDrawn, name: "MapsDrawnRow").Listen(1, new DelegateDataProvider<int>(() => Graphics.MapsDrawn), NoValue);
@@ -717,7 +717,7 @@ private Table CreateInfoTableDebugStats(Base parent)
717717
};
718718
table.SizeChanged += ResizeTableToChildrenOnSizeChanged;
719719

720-
table.AddRow(Strings.Debug.Fps, name: "FPSRow").Listen(1, new DelegateDataProvider<int>(() => Graphics.Renderer.Fps), NoValue);
720+
table.AddRow(Strings.Debug.Fps, name: "FPSRow").Listen(1, new DelegateDataProvider<int>(() => Graphics.Renderer.FPS), NoValue);
721721
table.AddRow(Strings.Debug.Draws, name: "DrawsRow").Listen(1, new DelegateDataProvider<int>(() => Graphics.DrawCalls), NoValue);
722722
table.AddRow(Strings.Debug.Ping, name: "PingRow").Listen(1, new DelegateDataProvider<int>(() => Networking.Network.Ping, delayMilliseconds: 5000), NoValue);
723723

Intersect.Client.Core/Interface/Interface.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,8 @@ public static void InitGwen()
167167
};
168168

169169
_canvasMainMenu.SetSize(
170-
(int)(Graphics.Renderer.GetScreenWidth() / _canvasMainMenu.Scale),
171-
(int)(Graphics.Renderer.GetScreenHeight() / _canvasMainMenu.Scale)
170+
(int)(Graphics.Renderer.ScreenWidth / _canvasMainMenu.Scale),
171+
(int)(Graphics.Renderer.ScreenHeight / _canvasMainMenu.Scale)
172172
);
173173

174174
_canvasMainMenu.ShouldDrawBackground = false;
@@ -180,8 +180,8 @@ public static void InitGwen()
180180

181181
//_gameCanvas.Scale = (GameGraphics.Renderer.GetScreenWidth() / 1920f);
182182
_canvasInGame.SetSize(
183-
(int)(Graphics.Renderer.GetScreenWidth() / _canvasInGame.Scale),
184-
(int)(Graphics.Renderer.GetScreenHeight() / _canvasInGame.Scale)
183+
(int)(Graphics.Renderer.ScreenWidth / _canvasInGame.Scale),
184+
(int)(Graphics.Renderer.ScreenHeight / _canvasInGame.Scale)
185185
);
186186

187187
_canvasInGame.ShouldDrawBackground = false;

Intersect.Client.Core/Interface/Shared/FPSPanel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public FPSPanel(Base parent, string name = nameof(FPSPanel)) : base(parent: pare
3939

4040
MinimumSize = Graphics.Renderer.MeasureText(Strings.General.FpsLabelFormat.ToString(10_000), font) + new Pointf(16, 8);
4141

42-
DelegateDataProvider<int> fpsProvider = new(() => Graphics.Renderer.Fps)
42+
DelegateDataProvider<int> fpsProvider = new(() => Graphics.Renderer.FPS)
4343
{
4444
UserData = _label,
4545
};

Intersect.Client.Core/Interface/Shared/SettingsWindow.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ public SettingsWindow(Base parent) : base(parent: parent, title: Strings.Setting
373373
TextPadding = new Padding(8, 4, 0, 4),
374374
};
375375

376-
var availableVideoModes = Graphics.Renderer?.GetValidVideoModes().ToArray() ?? [];
376+
var availableVideoModes = (Graphics.Renderer?.ValidVideoModes).ToArray() ?? [];
377377
for (var videoModeIndex = 0; videoModeIndex < availableVideoModes.Length; videoModeIndex++)
378378
{
379379
var availableVideoMode = availableVideoModes[videoModeIndex];
@@ -931,7 +931,7 @@ public void Show(Base? returnTo)
931931

932932
// _uiScale.Value = Globals.Database.UIScale;
933933

934-
if (Graphics.Renderer?.GetValidVideoModes().Count > 0)
934+
if ((Graphics.Renderer?.ValidVideoModes).Count > 0)
935935
{
936936
if (Graphics.Renderer.HasOverrideResolution)
937937
{

Intersect.Client.Core/Maps/MapInstance.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1374,7 +1374,7 @@ public void DrawWeather()
13741374
var spawnTime = 25 + (int)(475 * (1f - WeatherIntensity / 100f));
13751375
spawnTime = (int)(spawnTime *
13761376
(480000f /
1377-
(Graphics.Renderer.GetScreenWidth() * Graphics.Renderer.GetScreenHeight())));
1377+
(Graphics.Renderer.ScreenWidth * Graphics.Renderer.ScreenHeight)));
13781378

13791379
_weatherParticleSpawnTime = Timing.Global.MillisecondsUtc + spawnTime;
13801380
}

Intersect.Client.Core/Maps/WeatherParticle.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public partial class WeatherParticle : IWeatherParticle
4343
public WeatherParticle(List<IWeatherParticle> RemoveParticle, int xvelocity, int yvelocity, AnimationBase anim)
4444
{
4545
TransmittionTimer = Timing.Global.MillisecondsUtc;
46-
bounds = new Rectangle(0, 0, Graphics.Renderer.GetScreenWidth(), Graphics.Renderer.GetScreenHeight());
46+
bounds = new Rectangle(0, 0, Graphics.Renderer.ScreenWidth, Graphics.Renderer.ScreenHeight);
4747

4848
xVelocity = xvelocity;
4949
yVelocity = yvelocity;
@@ -55,19 +55,19 @@ public WeatherParticle(List<IWeatherParticle> RemoveParticle, int xvelocity, int
5555
if (xVelocity > 0)
5656
{
5757
originalX = Globals.Random.Next(
58-
-Graphics.Renderer.GetScreenWidth() / 4 - animSize.X,
59-
Graphics.Renderer.GetScreenWidth() + animSize.X
58+
-Graphics.Renderer.ScreenWidth / 4 - animSize.X,
59+
Graphics.Renderer.ScreenWidth + animSize.X
6060
);
6161
}
6262
else if (xVelocity < 0)
6363
{
6464
originalX = Globals.Random.Next(
65-
animSize.X, (int)(Graphics.Renderer.GetScreenWidth() * 1.25f) + animSize.X
65+
animSize.X, (int)(Graphics.Renderer.ScreenWidth * 1.25f) + animSize.X
6666
);
6767
}
6868
else
6969
{
70-
originalX = Globals.Random.Next(-animSize.X, Graphics.Renderer.GetScreenWidth() + animSize.X);
70+
originalX = Globals.Random.Next(-animSize.X, Graphics.Renderer.ScreenWidth + animSize.X);
7171
}
7272

7373
if (yVelocity > 0)
@@ -76,18 +76,18 @@ public WeatherParticle(List<IWeatherParticle> RemoveParticle, int xvelocity, int
7676
}
7777
else if (yVelocity < 0)
7878
{
79-
originalY = Graphics.Renderer.GetScreenHeight() + animSize.Y;
79+
originalY = Graphics.Renderer.ScreenHeight + animSize.Y;
8080
}
8181
else
8282
{
83-
originalY = Globals.Random.Next(-animSize.Y, Graphics.Renderer.GetScreenHeight() + animSize.Y);
83+
originalY = Globals.Random.Next(-animSize.Y, Graphics.Renderer.ScreenHeight + animSize.Y);
8484
if (xVelocity > 0)
8585
{
8686
originalX = -animSize.X;
8787
}
8888
else if (xVelocity < 0)
8989
{
90-
originalX = Graphics.Renderer.GetScreenWidth();
90+
originalX = Graphics.Renderer.ScreenWidth;
9191
}
9292
}
9393

@@ -103,12 +103,12 @@ public WeatherParticle(List<IWeatherParticle> RemoveParticle, int xvelocity, int
103103
bounds.Height += Math.Abs(originalY);
104104
}
105105

106-
if (originalY > Graphics.Renderer.GetScreenHeight())
106+
if (originalY > Graphics.Renderer.ScreenHeight)
107107
{
108108
bounds.Height = originalY;
109109
}
110110

111-
if (originalX > Graphics.Renderer.GetScreenWidth())
111+
if (originalX > Graphics.Renderer.ScreenWidth)
112112
{
113113
bounds.Width = originalX;
114114
}

0 commit comments

Comments
 (0)