Add full support for losing levels (#2492)

WeylonSantana · pandinocoder · web-flow · commit 62f36d490315 · 2025-01-23T22:13:50.000+01:00
* refactor give exp editor

* added level down support do give exp command

* fix: level lost string

* reverse take exp loop

* rename enable level down variable

* fixing strings

* move common start common event and send chat to bottom

* cache class descriptor

* force take exp when is a event command

* refactor addlevels

* fix wrong condition

* fix: correct naming, mesage colors

* simplify experience code

* Give/TakeExperience parameter validation

---------

Co-authored-by: Robbie Lodico &lt;pandacoder@pm.me&gt;
diff --git a/Framework/Intersect.Framework.Core/GameObjects/Events/Commands/EventCommands.cs b/Framework/Intersect.Framework.Core/GameObjects/Events/Commands/EventCommands.cs
@@ -331,6 +331,11 @@ public partial class GiveExperienceCommand : EventCommand
     /// The Variable Id to use.
     /// </summary>
     public Guid VariableId { get; set; }
+
+    /// <summary>
+    /// If true, when a player have their experience reduced, they will be able to level down.
+    /// </summary>
+    public bool EnableLosingLevels { get; set; } = false;
 }
 
 public partial class ChangeLevelCommand : EventCommand
diff --git a/Framework/Intersect.Framework.Core/GameObjects/Events/CommonEventTrigger.cs b/Framework/Intersect.Framework.Core/GameObjects/Events/CommonEventTrigger.cs
@@ -39,4 +39,6 @@ public enum CommonEventTrigger
     MapChanged,
 
     UserVariableChange,
+
+    LevelDown,
 }
diff --git a/Intersect (Core)/CustomColors.cs b/Intersect (Core)/CustomColors.cs
@@ -194,6 +194,8 @@ public sealed partial class CombatNamespace
 
         public Color LevelUp = Color.Cyan;
 
+        public Color LevelLost = Color.Red;
+
         public Color MagicDamage = new Color(255, 255, 0, 255);
 
         public Color Missed = new Color(255, 255, 255, 255);
diff --git a/Intersect.Editor/Forms/Editors/Events/Event Commands/EventCommand_GiveExperience.Designer.cs b/Intersect.Editor/Forms/Editors/Events/Event Commands/EventCommand_GiveExperience.Designer.cs
diff --git a/Intersect.Editor/Forms/Editors/Events/Event Commands/EventCommand_GiveExperience.cs b/Intersect.Editor/Forms/Editors/Events/Event Commands/EventCommand_GiveExperience.cs
@@ -5,32 +5,35 @@
 
 namespace Intersect.Editor.Forms.Editors.Events.Event_Commands;
 
-
 public partial class EventCommandGiveExperience : UserControl
 {
+    private readonly FrmEvent _eventEditor;
 
-    private readonly FrmEvent mEventEditor;
-
-    private GiveExperienceCommand mMyCommand;
+    private readonly GiveExperienceCommand _command;
 
     public EventCommandGiveExperience(GiveExperienceCommand refCommand, FrmEvent editor)
     {
         InitializeComponent();
-        mMyCommand = refCommand;
-        mEventEditor = editor;
+        _command = refCommand;
+        _eventEditor = editor;
         InitLocalization();
 
-        rdoVariable.Checked = mMyCommand.UseVariable;
-        rdoGlobalVariable.Checked = mMyCommand.VariableType == VariableType.ServerVariable;
-        rdoGuildVariable.Checked = mMyCommand.VariableType == VariableType.GuildVariable;
+        rdoVariable.Checked = _command.UseVariable;
+        rdoGlobalVariable.Checked = _command.VariableType == VariableType.ServerVariable;
+        rdoGuildVariable.Checked = _command.VariableType == VariableType.GuildVariable;
+
+        nudExperience.Minimum = -long.MaxValue;
+        nudExperience.Maximum = long.MaxValue;
 
-        SetupAmountInput();
+        chkEnableLevelDown.Checked = _command.EnableLosingLevels;
+
+        SetupAmountInput(default, default);
     }
 
     private void InitLocalization()
     {
-        grpGiveExperience.Text = Strings.EventGiveExperience.title;
-        lblExperience.Text = Strings.EventGiveExperience.label;
+        grpGiveExperience.Text = Strings.EventGiveExperience.Title;
+        lblExperience.Text = Strings.EventGiveExperience.Label;
 
         lblVariable.Text = Strings.EventGiveExperience.Variable;
 
@@ -45,60 +48,40 @@ private void InitLocalization()
         rdoGlobalVariable.Text = Strings.EventGiveExperience.ServerVariable;
         rdoGuildVariable.Text = Strings.EventGiveExperience.GuildVariable;
 
-        btnSave.Text = Strings.EventGiveExperience.okay;
-        btnCancel.Text = Strings.EventGiveExperience.cancel;
+        chkEnableLevelDown.Text = Strings.EventGiveExperience.EnableLosingLevels;
+
+        btnSave.Text = Strings.General.Okay;
+        btnCancel.Text = Strings.General.Cancel;
     }
 
     private void btnSave_Click(object sender, EventArgs e)
     {
-        mMyCommand.Exp = (long) nudExperience.Value;
+        _command.Exp = (long)nudExperience.Value;
+
         if (rdoPlayerVariable.Checked)
         {
-            mMyCommand.VariableType = VariableType.PlayerVariable;
-            mMyCommand.VariableId = PlayerVariableDescriptor.IdFromList(cmbVariable.SelectedIndex, VariableDataType.Integer);
+            _command.VariableType = VariableType.PlayerVariable;
+            _command.VariableId = PlayerVariableDescriptor.IdFromList(cmbVariable.SelectedIndex, VariableDataType.Integer);
         }
         else if (rdoGlobalVariable.Checked)
         {
-            mMyCommand.VariableType = VariableType.ServerVariable;
-            mMyCommand.VariableId = ServerVariableDescriptor.IdFromList(cmbVariable.SelectedIndex, VariableDataType.Integer);
+            _command.VariableType = VariableType.ServerVariable;
+            _command.VariableId = ServerVariableDescriptor.IdFromList(cmbVariable.SelectedIndex, VariableDataType.Integer);
         }
         else if (rdoGuildVariable.Checked)
         {
-            mMyCommand.VariableType = VariableType.GuildVariable;
-            mMyCommand.VariableId = GuildVariableDescriptor.IdFromList(cmbVariable.SelectedIndex, VariableDataType.Integer);
+            _command.VariableType = VariableType.GuildVariable;
+            _command.VariableId = GuildVariableDescriptor.IdFromList(cmbVariable.SelectedIndex, VariableDataType.Integer);
         }
-        mMyCommand.UseVariable = !rdoManual.Checked;
-        mEventEditor.FinishCommandEdit();
-    }
-
-    private void btnCancel_Click(object sender, EventArgs e)
-    {
-        mEventEditor.CancelCommandEdit();
-    }
 
-    private void rdoManual_CheckedChanged(object sender, EventArgs e)
-    {
-        SetupAmountInput();
-    }
-
-    private void rdoVariable_CheckedChanged(object sender, EventArgs e)
-    {
-        SetupAmountInput();
+        _command.UseVariable = !rdoManual.Checked;
+        _command.EnableLosingLevels = chkEnableLevelDown.Checked;
+        _eventEditor.FinishCommandEdit();
     }
 
-    private void rdoPlayerVariable_CheckedChanged(object sender, EventArgs e)
-    {
-        SetupAmountInput();
-    }
-
-    private void rdoGlobalVariable_CheckedChanged(object sender, EventArgs e)
-    {
-        SetupAmountInput();
-    }
-
-    private void rdoGuildVariable_CheckedChanged(object sender, EventArgs e)
+    private void btnCancel_Click(object sender, EventArgs e)
     {
-        SetupAmountInput();
+        _eventEditor.CancelCommandEdit();
     }
 
     private void VariableBlank()
@@ -114,7 +97,7 @@ private void VariableBlank()
         }
     }
 
-    private void SetupAmountInput()
+    private void SetupAmountInput(object? sender, EventArgs? e)
     {
         grpManualAmount.Visible = rdoManual.Checked;
         grpVariableAmount.Visible = !rdoManual.Checked;
@@ -124,9 +107,9 @@ private void SetupAmountInput()
         {
             cmbVariable.Items.AddRange(PlayerVariableDescriptor.GetNamesByType(VariableDataType.Integer));
             // Do not update if the wrong type of variable is saved
-            if (mMyCommand.VariableType == VariableType.PlayerVariable)
+            if (_command.VariableType == VariableType.PlayerVariable)
             {
-                var index = PlayerVariableDescriptor.ListIndex(mMyCommand.VariableId, VariableDataType.Integer);
+                var index = PlayerVariableDescriptor.ListIndex(_command.VariableId, VariableDataType.Integer);
                 if (index > -1)
                 {
                     cmbVariable.SelectedIndex = index;
@@ -145,9 +128,9 @@ private void SetupAmountInput()
         {
             cmbVariable.Items.AddRange(ServerVariableDescriptor.GetNamesByType(VariableDataType.Integer));
             // Do not update if the wrong type of variable is saved
-            if (mMyCommand.VariableType == VariableType.ServerVariable)
+            if (_command.VariableType == VariableType.ServerVariable)
             {
-                var index = ServerVariableDescriptor.ListIndex(mMyCommand.VariableId, VariableDataType.Integer);
+                var index = ServerVariableDescriptor.ListIndex(_command.VariableId, VariableDataType.Integer);
                 if (index > -1)
                 {
                     cmbVariable.SelectedIndex = index;
@@ -166,9 +149,9 @@ private void SetupAmountInput()
         {
             cmbVariable.Items.AddRange(GuildVariableDescriptor.GetNamesByType(VariableDataType.Integer));
             // Do not update if the wrong type of variable is saved
-            if (mMyCommand.VariableType == VariableType.GuildVariable)
+            if (_command.VariableType == VariableType.GuildVariable)
             {
-                var index = GuildVariableDescriptor.ListIndex(mMyCommand.VariableId, VariableDataType.Integer);
+                var index = GuildVariableDescriptor.ListIndex(_command.VariableId, VariableDataType.Integer);
                 if (index > -1)
                 {
                     cmbVariable.SelectedIndex = index;
@@ -184,6 +167,6 @@ private void SetupAmountInput()
             }
         }
 
-        nudExperience.Value = Math.Max(1, mMyCommand.Exp);
+        nudExperience.Value = _command.Exp;
     }
 }
diff --git a/Intersect.Editor/Forms/Editors/Events/Event Commands/EventCommand_GiveExperience.resx b/Intersect.Editor/Forms/Editors/Events/Event Commands/EventCommand_GiveExperience.resx
@@ -1,17 +1,17 @@
 ﻿<?xml version="1.0" encoding="utf-8"?>
 <root>
-  <!-- 
+  <!--
     Microsoft ResX Schema 
-    
+
     Version 2.0
-    
-    The primary goals of this format is to allow a simple XML format 
-    that is mostly human readable. The generation and parsing of the 
-    various data types are done through the TypeConverter classes 
+
+    The primary goals of this format is to allow a simple XML format
+    that is mostly human readable. The generation and parsing of the
+    various data types are done through the TypeConverter classes
     associated with the data types.
-    
+
     Example:
-    
+
     ... ado.net/XML headers & schema ...
     <resheader name="resmimetype">text/microsoft-resx</resheader>
     <resheader name="version">2.0</resheader>
@@ -26,36 +26,36 @@
         <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
         <comment>This is a comment</comment>
     </data>
-                
-    There are any number of "resheader" rows that contain simple 
+
+    There are any number of "resheader" rows that contain simple
     name/value pairs.
-    
-    Each data row contains a name, and value. The row also contains a 
-    type or mimetype. Type corresponds to a .NET class that support 
-    text/value conversion through the TypeConverter architecture. 
-    Classes that don't support this are serialized and stored with the 
+
+    Each data row contains a name, and value. The row also contains a
+    type or mimetype. Type corresponds to a .NET class that support
+    text/value conversion through the TypeConverter architecture.
+    Classes that don't support this are serialized and stored with the
     mimetype set.
-    
-    The mimetype is used for serialized objects, and tells the 
-    ResXResourceReader how to depersist the object. This is currently not 
+
+    The mimetype is used for serialized objects, and tells the
+    ResXResourceReader how to depersist the object. This is currently not
     extensible. For a given mimetype the value must be set accordingly:
-    
-    Note - application/x-microsoft.net.object.binary.base64 is the format 
-    that the ResXResourceWriter will generate, however the reader can 
+
+    Note - application/x-microsoft.net.object.binary.base64 is the format
+    that the ResXResourceWriter will generate, however the reader can
     read any of the formats listed below.
-    
+
     mimetype: application/x-microsoft.net.object.binary.base64
-    value   : The object must be serialized with 
+    value   : The object must be serialized with
             : System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
             : and then encoded with base64 encoding.
     
     mimetype: application/x-microsoft.net.object.soap.base64
-    value   : The object must be serialized with 
+    value   : The object must be serialized with
             : System.Runtime.Serialization.Formatters.Soap.SoapFormatter
             : and then encoded with base64 encoding.
 
     mimetype: application/x-microsoft.net.object.bytearray.base64
-    value   : The object must be serialized into a byte array 
+    value   : The object must be serialized into a byte array
             : using a System.ComponentModel.TypeConverter
             : and then encoded with base64 encoding.
     -->
diff --git a/Intersect.Editor/Localization/Strings.cs b/Intersect.Editor/Localization/Strings.cs
@@ -2800,6 +2800,7 @@ public partial struct EventEditor
             {16, @"Inventory Changed"},
             {17, @"Map Changed"},
             {18, @"User Variable Changed"},
+            {19, @"Level Down"},
         };
 
         public static LocalizedString conditions = @"Conditions";
@@ -2947,20 +2948,17 @@ public partial struct EventEndQuest
 
     public partial struct EventGiveExperience
     {
+        [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
+        public static LocalizedString AmountType = @"Amount Type";
 
-        public static LocalizedString cancel = @"Cancel";
-
-        public static LocalizedString label = @"Give Experience:";
-
-        public static LocalizedString okay = @"Ok";
-
-        public static LocalizedString title = @"Give Experience";
+        [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
+        public static LocalizedString EnableLosingLevels = @"Enable losing levels?";
 
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
-        public static LocalizedString AmountType = @"Amount Type";
+        public static LocalizedString GuildVariable = @"Guild Variable";
 
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
-        public static LocalizedString Variable = @"Variable";
+        public static LocalizedString Label = @"Give Experience:";
 
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
         public static LocalizedString Manual = @"Manual";
@@ -2972,8 +2970,10 @@ public partial struct EventGiveExperience
         public static LocalizedString ServerVariable = @"Global Variable";
 
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
-        public static LocalizedString GuildVariable = @"Guild Variable";
+        public static LocalizedString Title = @"Give Experience";
 
+        [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
+        public static LocalizedString Variable = @"Variable";
     }
 
     public partial struct EventGotoLabel
diff --git a/Intersect.Server.Core/Entities/Events/CommandProcessing.cs b/Intersect.Server.Core/Entities/Events/CommandProcessing.cs
@@ -421,7 +421,7 @@ private static void ProcessCommand(
         Stack<CommandInstance> callStack
     )
     {
-        player.LevelUp();
+        player.AddLevels();
     }
 
     //Give Experience Command
@@ -454,7 +454,14 @@ Stack<CommandInstance> callStack
             }
         }
 
-        player.GiveExperience(quantity);
+        if(quantity > 0)
+        {
+            player.GiveExperience(quantity);
+        }
+        else if (quantity < 0)
+        {
+            player.TakeExperience(Math.Abs(quantity), command.EnableLosingLevels, force: true);
+        }
     }
 
     //Change Level Command
diff --git a/Intersect.Server.Core/Entities/Player.cs b/Intersect.Server.Core/Entities/Player.cs
diff --git a/Intersect.Server.Core/Localization/Strings.cs b/Intersect.Server.Core/Localization/Strings.cs

Original file line number	Diff line number	Diff line change
`@@ -39,4 +39,6 @@ public enum CommonEventTrigger`
`39`	`39`	`MapChanged,`
`40`	`40`
`41`	`41`	`UserVariableChange,`
	`42`	`+`
	`43`	`+ LevelDown,`
`42`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,32 +5,35 @@`
`5`	`5`
`6`	`6`	`namespace Intersect.Editor.Forms.Editors.Events.Event_Commands;`
`7`	`7`
`8`		`-`
`9`	`8`	`public partial class EventCommandGiveExperience : UserControl`
`10`	`9`	`{`
	`10`	`+ private readonly FrmEvent _eventEditor;`
`11`	`11`
`12`		`- private readonly FrmEvent mEventEditor;`
`13`		`-`
`14`		`- private GiveExperienceCommand mMyCommand;`
	`12`	`+ private readonly GiveExperienceCommand _command;`
`15`	`13`
`16`	`14`	`public EventCommandGiveExperience(GiveExperienceCommand refCommand, FrmEvent editor)`
`17`	`15`	`{`
`18`	`16`	`InitializeComponent();`
`19`		`- mMyCommand = refCommand;`
`20`		`- mEventEditor = editor;`
	`17`	`+ _command = refCommand;`
	`18`	`+ _eventEditor = editor;`
`21`	`19`	`InitLocalization();`
`22`	`20`
`23`		`- rdoVariable.Checked = mMyCommand.UseVariable;`
`24`		`- rdoGlobalVariable.Checked = mMyCommand.VariableType == VariableType.ServerVariable;`
`25`		`- rdoGuildVariable.Checked = mMyCommand.VariableType == VariableType.GuildVariable;`
	`21`	`+ rdoVariable.Checked = _command.UseVariable;`
	`22`	`+ rdoGlobalVariable.Checked = _command.VariableType == VariableType.ServerVariable;`
	`23`	`+ rdoGuildVariable.Checked = _command.VariableType == VariableType.GuildVariable;`
	`24`	`+`
	`25`	`+ nudExperience.Minimum = -long.MaxValue;`
	`26`	`+ nudExperience.Maximum = long.MaxValue;`
`26`	`27`
`27`		`- SetupAmountInput();`
	`28`	`+ chkEnableLevelDown.Checked = _command.EnableLosingLevels;`
	`29`	`+`
	`30`	`+ SetupAmountInput(default, default);`
`28`	`31`	`}`
`29`	`32`
`30`	`33`	`private void InitLocalization()`
`31`	`34`	`{`
`32`		`- grpGiveExperience.Text = Strings.EventGiveExperience.title;`
`33`		`- lblExperience.Text = Strings.EventGiveExperience.label;`
	`35`	`+ grpGiveExperience.Text = Strings.EventGiveExperience.Title;`
	`36`	`+ lblExperience.Text = Strings.EventGiveExperience.Label;`
`34`	`37`
`35`	`38`	`lblVariable.Text = Strings.EventGiveExperience.Variable;`
`36`	`39`
`@@ -45,60 +48,40 @@ private void InitLocalization()`
`45`	`48`	`rdoGlobalVariable.Text = Strings.EventGiveExperience.ServerVariable;`
`46`	`49`	`rdoGuildVariable.Text = Strings.EventGiveExperience.GuildVariable;`
`47`	`50`
`48`		`- btnSave.Text = Strings.EventGiveExperience.okay;`
`49`		`- btnCancel.Text = Strings.EventGiveExperience.cancel;`
	`51`	`+ chkEnableLevelDown.Text = Strings.EventGiveExperience.EnableLosingLevels;`
	`52`	`+`
	`53`	`+ btnSave.Text = Strings.General.Okay;`
	`54`	`+ btnCancel.Text = Strings.General.Cancel;`
`50`	`55`	`}`
`51`	`56`
`52`	`57`	`private void btnSave_Click(object sender, EventArgs e)`
`53`	`58`	`{`
`54`		`- mMyCommand.Exp = (long) nudExperience.Value;`
	`59`	`+ _command.Exp = (long)nudExperience.Value;`
	`60`	`+`
`55`	`61`	`if (rdoPlayerVariable.Checked)`
`56`	`62`	`{`
`57`		`- mMyCommand.VariableType = VariableType.PlayerVariable;`
`58`		`- mMyCommand.VariableId = PlayerVariableDescriptor.IdFromList(cmbVariable.SelectedIndex, VariableDataType.Integer);`
	`63`	`+ _command.VariableType = VariableType.PlayerVariable;`
	`64`	`+ _command.VariableId = PlayerVariableDescriptor.IdFromList(cmbVariable.SelectedIndex, VariableDataType.Integer);`
`59`	`65`	`}`
`60`	`66`	`else if (rdoGlobalVariable.Checked)`
`61`	`67`	`{`
`62`		`- mMyCommand.VariableType = VariableType.ServerVariable;`
`63`		`- mMyCommand.VariableId = ServerVariableDescriptor.IdFromList(cmbVariable.SelectedIndex, VariableDataType.Integer);`
	`68`	`+ _command.VariableType = VariableType.ServerVariable;`
	`69`	`+ _command.VariableId = ServerVariableDescriptor.IdFromList(cmbVariable.SelectedIndex, VariableDataType.Integer);`
`64`	`70`	`}`
`65`	`71`	`else if (rdoGuildVariable.Checked)`
`66`	`72`	`{`
`67`		`- mMyCommand.VariableType = VariableType.GuildVariable;`
`68`		`- mMyCommand.VariableId = GuildVariableDescriptor.IdFromList(cmbVariable.SelectedIndex, VariableDataType.Integer);`
	`73`	`+ _command.VariableType = VariableType.GuildVariable;`
	`74`	`+ _command.VariableId = GuildVariableDescriptor.IdFromList(cmbVariable.SelectedIndex, VariableDataType.Integer);`
`69`	`75`	`}`
`70`		`- mMyCommand.UseVariable = !rdoManual.Checked;`
`71`		`- mEventEditor.FinishCommandEdit();`
`72`		`- }`
`73`		`-`
`74`		`- private void btnCancel_Click(object sender, EventArgs e)`
`75`		`- {`
`76`		`- mEventEditor.CancelCommandEdit();`
`77`		`- }`
`78`	`76`
`79`		`- private void rdoManual_CheckedChanged(object sender, EventArgs e)`
`80`		`- {`
`81`		`- SetupAmountInput();`
`82`		`- }`
`83`		`-`
`84`		`- private void rdoVariable_CheckedChanged(object sender, EventArgs e)`
`85`		`- {`
`86`		`- SetupAmountInput();`
	`77`	`+ _command.UseVariable = !rdoManual.Checked;`
	`78`	`+ _command.EnableLosingLevels = chkEnableLevelDown.Checked;`
	`79`	`+ _eventEditor.FinishCommandEdit();`
`87`	`80`	`}`
`88`	`81`
`89`		`- private void rdoPlayerVariable_CheckedChanged(object sender, EventArgs e)`
`90`		`- {`
`91`		`- SetupAmountInput();`
`92`		`- }`
`93`		`-`
`94`		`- private void rdoGlobalVariable_CheckedChanged(object sender, EventArgs e)`
`95`		`- {`
`96`		`- SetupAmountInput();`
`97`		`- }`
`98`		`-`
`99`		`- private void rdoGuildVariable_CheckedChanged(object sender, EventArgs e)`
	`82`	`+ private void btnCancel_Click(object sender, EventArgs e)`
`100`	`83`	`{`
`101`		`- SetupAmountInput();`
	`84`	`+ _eventEditor.CancelCommandEdit();`
`102`	`85`	`}`
`103`	`86`
`104`	`87`	`private void VariableBlank()`
`@@ -114,7 +97,7 @@ private void VariableBlank()`
`114`	`97`	`}`
`115`	`98`	`}`
`116`	`99`
`117`		`- private void SetupAmountInput()`
	`100`	`+ private void SetupAmountInput(object? sender, EventArgs? e)`
`118`	`101`	`{`
`119`	`102`	`grpManualAmount.Visible = rdoManual.Checked;`
`120`	`103`	`grpVariableAmount.Visible = !rdoManual.Checked;`
`@@ -124,9 +107,9 @@ private void SetupAmountInput()`
`124`	`107`	`{`
`125`	`108`	`cmbVariable.Items.AddRange(PlayerVariableDescriptor.GetNamesByType(VariableDataType.Integer));`
`126`	`109`	`// Do not update if the wrong type of variable is saved`
`127`		`- if (mMyCommand.VariableType == VariableType.PlayerVariable)`
	`110`	`+ if (_command.VariableType == VariableType.PlayerVariable)`
`128`	`111`	`{`
`129`		`- var index = PlayerVariableDescriptor.ListIndex(mMyCommand.VariableId, VariableDataType.Integer);`
	`112`	`+ var index = PlayerVariableDescriptor.ListIndex(_command.VariableId, VariableDataType.Integer);`
`130`	`113`	`if (index > -1)`
`131`	`114`	`{`
`132`	`115`	`cmbVariable.SelectedIndex = index;`
`@@ -145,9 +128,9 @@ private void SetupAmountInput()`
`145`	`128`	`{`
`146`	`129`	`cmbVariable.Items.AddRange(ServerVariableDescriptor.GetNamesByType(VariableDataType.Integer));`
`147`	`130`	`// Do not update if the wrong type of variable is saved`
`148`		`- if (mMyCommand.VariableType == VariableType.ServerVariable)`
	`131`	`+ if (_command.VariableType == VariableType.ServerVariable)`
`149`	`132`	`{`
`150`		`- var index = ServerVariableDescriptor.ListIndex(mMyCommand.VariableId, VariableDataType.Integer);`
	`133`	`+ var index = ServerVariableDescriptor.ListIndex(_command.VariableId, VariableDataType.Integer);`
`151`	`134`	`if (index > -1)`
`152`	`135`	`{`
`153`	`136`	`cmbVariable.SelectedIndex = index;`
`@@ -166,9 +149,9 @@ private void SetupAmountInput()`
`166`	`149`	`{`
`167`	`150`	`cmbVariable.Items.AddRange(GuildVariableDescriptor.GetNamesByType(VariableDataType.Integer));`
`168`	`151`	`// Do not update if the wrong type of variable is saved`
`169`		`- if (mMyCommand.VariableType == VariableType.GuildVariable)`
	`152`	`+ if (_command.VariableType == VariableType.GuildVariable)`
`170`	`153`	`{`
`171`		`- var index = GuildVariableDescriptor.ListIndex(mMyCommand.VariableId, VariableDataType.Integer);`
	`154`	`+ var index = GuildVariableDescriptor.ListIndex(_command.VariableId, VariableDataType.Integer);`
`172`	`155`	`if (index > -1)`
`173`	`156`	`{`
`174`	`157`	`cmbVariable.SelectedIndex = index;`
`@@ -184,6 +167,6 @@ private void SetupAmountInput()`
`184`	`167`	`}`
`185`	`168`	`}`
`186`	`169`
`187`		`- nudExperience.Value = Math.Max(1, mMyCommand.Exp);`
	`170`	`+ nudExperience.Value = _command.Exp;`
`188`	`171`	`}`
`189`	`172`	`}`
Original file line number	Diff line number	Diff line change
`@@ -421,7 +421,7 @@ private static void ProcessCommand(`
`421`	`421`	`Stack<CommandInstance> callStack`
`422`	`422`	`)`
`423`	`423`	`{`
`424`		`- player.LevelUp();`
	`424`	`+ player.AddLevels();`
`425`	`425`	`}`
`426`	`426`
`427`	`427`	`//Give Experience Command`
`@@ -454,7 +454,14 @@ Stack<CommandInstance> callStack`
`454`	`454`	`}`
`455`	`455`	`}`
`456`	`456`
`457`		`- player.GiveExperience(quantity);`
	`457`	`+ if(quantity > 0)`
	`458`	`+ {`
	`459`	`+ player.GiveExperience(quantity);`
	`460`	`+ }`
	`461`	`+ else if (quantity < 0)`
	`462`	`+ {`
	`463`	`+ player.TakeExperience(Math.Abs(quantity), command.EnableLosingLevels, force: true);`
	`464`	`+ }`
`458`	`465`	`}`
`459`	`466`
`460`	`467`	`//Change Level Command`