fix(2431): Ensure that target inventory has slots populated

Author: pandinocoder

Intersect (Core)/Collections/Slotting/SlotList.cs

@@ -85,6 +85,25 @@ public TSlot this[int slotIndex]
         set => _slots[slotIndex] = value;
     }
 
+    public void Ensure(int slotIndex)
+    {
+        if (_slots.ContainsKey(slotIndex))
+        {
+            return;
+        }
+
+        _slots[slotIndex] = _factory(slotIndex);
+    }
+
+    public void FillToCapacity()
+    {
+        var targetCapacity = Capacity;
+        for (var targetSlotIndex = 0; Count < targetCapacity && targetSlotIndex < targetCapacity; ++targetSlotIndex)
+        {
+            Ensure(targetSlotIndex);
+        }
+    }
+
     public int FindIndex(Func<TSlot, bool> predicate)
     {
         var copy = this.ToArray();

Intersect.Server.Core/Entities/BankInterface.cs

@@ -124,6 +124,8 @@ public bool TryDepositItem(Item? slot, int inventorySlotIndex, int quantityHint,
         var maximumStack = itemDescriptor.Stackable ? itemDescriptor.MaxBankStack : 1;
         var sourceQuantity = Item.FindQuantityOfItem(itemDescriptor.Id, sourceSlots);
 
+        _bank.FillToCapacity();
+
         var targetSlots = _bank.ToArray();
 
         lock (_lock)
@@ -335,6 +337,8 @@ public bool TryWithdrawItem(Item? slot, int bankSlotIndex, int quantityHint, int
         var sourceSlots = _bank.ToArray();
         var sourceQuantity = Item.FindQuantityOfItem(itemDescriptor.Id, sourceSlots);
 
+        _player.Items.FillToCapacity();
+
         var targetSlots = _player.Items.ToArray();
 
         lock (_lock)