Skip to content

Commit 8cd877c

Browse files
committed
Panda review
1 parent 3bae3b8 commit 8cd877c

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

Intersect.Client.Core/Interface/Game/TargetContextMenu.cs

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public TargetContextMenu(Canvas gameCanvas) : base(gameCanvas, nameof(TargetCont
5353
_guildMenuItem.Clicked += guildRequest_Clicked;
5454

5555
_privateMessageMenuItem = AddItem(Strings.EntityContextMenu.PrivateMessage);
56-
_privateMessageMenuItem.Clicked += privateMessageRequest_Clicked;
56+
_privateMessageMenuItem.Clicked += privateMessageRequest_Clicked;
5757

5858
LoadJsonUi(GameContentManager.UI.InGame, Graphics.Renderer?.GetResolutionString());
5959
}
@@ -132,16 +132,25 @@ public void ToggleHidden(object? target)
132132
}
133133
}
134134

135-
136135
private void TryShowTargetButton(bool shouldShow)
137136
{
138137
_targetNameMenuItem.SetText(shouldShow ? _entity.Name : string.Empty);
139138

140-
if (shouldShow && !Children.Contains(_targetNameMenuItem))
139+
if (shouldShow)
141140
{
142-
Children.Insert(0, _targetNameMenuItem);
141+
var indexOf = Children.IndexOf(_targetNameMenuItem);
142+
143+
if (indexOf > 0)
144+
{
145+
Children.RemoveAt(indexOf);
146+
}
147+
148+
if (indexOf != 0)
149+
{
150+
Children.Insert(0, _targetNameMenuItem);
151+
}
143152
}
144-
else if (!shouldShow && Children.Contains(_targetNameMenuItem))
153+
else
145154
{
146155
Children.Remove(_targetNameMenuItem);
147156
}

0 commit comments

Comments
 (0)