Fix and add usage to the knockback skill effect

Author: Kamus

Framework/Intersect.Framework.Core/GameObjects/Spells/SpellCombatDescriptor.cs

@@ -83,6 +83,11 @@ public string PercentageStatDiffJson
 
     public SpellEffect Effect { get; set; }
 
+    /// <summary>
+    /// Number of tiles to push the target when Knockback effect is applied.
+    /// </summary>
+    public int KnockbackTiles { get; set; } = 1;
+
     public string TransformSprite { get; set; }
 
     [Column("OnHit")]

Intersect.Editor/Forms/Editors/frmSpell.Designer.cs

@@ -535,6 +535,8 @@ private void cmbExtraEffect_SelectedIndexChanged(object sender, EventArgs e)
         lblSprite.Visible = false;
         cmbTransform.Visible = false;
         picSprite.Visible = false;
+        lblKnockbackTiles.Visible = false;
+        nudKnockbackTiles.Visible = false;
 
         if (cmbExtraEffect.SelectedIndex == 6) //Transform
         {
@@ -567,6 +569,13 @@ private void cmbExtraEffect_SelectedIndexChanged(object sender, EventArgs e)
                 picSprite.BackgroundImage = null;
             }
         }
+
+        if (cmbExtraEffect.SelectedIndex == (int)SpellEffect.Knockback) // Knockback
+        {
+            lblKnockbackTiles.Visible = true;
+            nudKnockbackTiles.Visible = true;
+            nudKnockbackTiles.Value = Math.Max(1, mEditorItem.Combat.KnockbackTiles);
+        }
     }
 
     private void frmSpell_FormClosed(object sender, FormClosedEventArgs e)
@@ -1100,4 +1109,9 @@ private void cmbTickAnimation_SelectedIndexChanged(object sender, EventArgs e)
         Guid animationId = AnimationDescriptor.IdFromList(cmbTickAnimation.SelectedIndex - 1);
         mEditorItem.TickAnimation = AnimationDescriptor.Get(animationId);
     }
+
+    private void nudKnockbackTiles_ValueChanged(object sender, EventArgs e)
+    {
+        mEditorItem.Combat.KnockbackTiles = (int)nudKnockbackTiles.Value;
+    }
 }

Intersect.Editor/Forms/Editors/frmSpell.cs

@@ -5364,6 +5364,9 @@ public partial struct SpellEditor
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
         public static LocalizedString TickAnimation = @"Tick Animation:";
 
+        [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
+        public static LocalizedString knockbacktiles = @"Tiles:";
+
         public static LocalizedString magicresist = @"Magic Resist:";
 
         public static LocalizedString manacost = @"Mana Cost:";

Intersect.Editor/Localization/Strings.cs

@@ -208,6 +208,17 @@ public Status(Entity en, Entity attacker, SpellDescriptor spell, SpellEffect typ
             }
 
         }
+
+        // If this is a Knockback effect, apply the displacement (push target away from attacker)
+        if (Type == SpellEffect.Knockback && spell.Combat.KnockbackTiles > 0)
+        {
+            // Calculate direction from attacker to target, then that's the direction to push
+            var knockbackDirection = Attacker.GetDirectionTo(en);
+            if (knockbackDirection != Direction.None)
+            {
+                var dash = new Dash(en, spell.Combat.KnockbackTiles, knockbackDirection, false, false, false, false);
+            }
+        }
     }
 
     public long[] Shield { get; set; } = new long[Enum.GetValues<Vital>().Length];

Intersect.Server.Core/Entities/Combat/Status.cs

@@ -1535,6 +1535,9 @@ protected override void BuildModel(ModelBuilder modelBuilder)
                             b1.Property<int>("HotDotInterval")
                                 .HasColumnType("INTEGER");
 
+                            b1.Property<int>("KnockbackTiles")
+                                .HasColumnType("INTEGER");
+
                             b1.Property<int>("OnHitDuration")
                                 .HasColumnType("INTEGER")
                                 .HasColumnName("OnHit");