fix: ♻️ Apply review changes (I)

Author: Arufonsu

Intersect.Client.Framework/Gwen/Control/Base.cs

@@ -766,9 +766,13 @@ public virtual void Dispose()
         Animation.Cancel(this);
 
         // [Fix]: "InvalidOperationException: Collection was modified (during iteration); enumeration operation may not execute".
-        // (Creates a copy of the children list to avoid modifying the collection during iteration).
-        var childrenCopy = new List<Base>(mChildren);
-        childrenCopy.ForEach(child => child.Dispose());
+        // (Creates an array copy of the children to avoid modifying the collection during iteration).
+        var children = mChildren.ToArray();
+        foreach (var child in children)
+        {
+            child.Dispose();
+        }
+
         mChildren?.Clear();
 
         mInnerPanel?.Dispose();

Intersect.Client/Core/Input.cs

@@ -135,13 +135,13 @@ public static void OnKeyPressed(Keys modifier, Keys key)
             {
                 var simplifiedEscapeMenuSetting = Globals.Database.SimplifiedEscapeMenu;
 
-                if (!simplifiedEscapeMenuSetting)
+                if (simplifiedEscapeMenuSetting)
                 {
-                    Interface.Interface.GameUi?.EscapeMenu?.ToggleHidden();
+                    Interface.Interface.GameUi?.SimplifiedEscapeMenu?.ToggleHidden();
                 }
                 else
                 {
-                    Interface.Interface.GameUi?.SimplifiedEscapeMenu?.ToggleHidden();
+                    Interface.Interface.GameUi?.EscapeMenu?.ToggleHidden();
                 }
             }
         }

Intersect.Client/Interface/Game/Menu.cs

@@ -359,13 +359,13 @@ private static void MenuButtonClicked(Base sender, ClickedEventArgs arguments)
     {
         var simplifiedEscapeMenuSetting = Globals.Database.SimplifiedEscapeMenu;
 
-        if (!simplifiedEscapeMenuSetting)
+        if (simplifiedEscapeMenuSetting)
         {
-            Interface.GameUi?.EscapeMenu?.ToggleHidden();
+            Interface.GameUi?.SimplifiedEscapeMenu?.ToggleHidden();
         }
         else
         {
-            Interface.GameUi?.SimplifiedEscapeMenu?.ToggleHidden();
+            Interface.GameUi?.EscapeMenu?.ToggleHidden();
         }
     }