Fixes out of bounds exception on world scale slider (#2757)

Author: jcsnider

Intersect.Client.Core/Interface/Shared/SettingsWindow.cs

@@ -829,29 +829,28 @@ protected override void OnVisibilityChanged(object? sender, VisibilityChangedEve
 
     private void UpdateWorldScaleControls()
     {
-        var worldScaleNotches = new double[] { 1, 2, 4 }.Select(n => n * Graphics.MinimumWorldScale).ToList();
-        while (worldScaleNotches.Last() < Graphics.MaximumWorldScale)
+        if (!Options.IsLoaded)
         {
-            worldScaleNotches.Add(worldScaleNotches.Last() * 2);
+            _worldScale.IsHidden = true;
+            return;
         }
 
-        if (Options.IsLoaded)
-        {
-            _worldScale.IsDisabled = false;
-            _worldScale.SetToolTipText(null);
+        _worldScale.IsHidden = false;
+        _worldScale.IsDisabled = false;
+        _worldScale.SetToolTipText(null);
 
-            Globals.Database.WorldZoom = (float)MathHelper.Clamp(
-                Globals.Database.WorldZoom,
-                worldScaleNotches.Min(),
-                worldScaleNotches.Max()
-            );
-        }
-        else
+        var worldScaleNotches = new double[] { 1, 2, 4 }.Select(n => n * Graphics.MinimumWorldScale).ToList();
+        while (worldScaleNotches.Last() < Graphics.MaximumWorldScale)
         {
-            _worldScale.SetToolTipText(Strings.Settings.WorldScaleTooltip);
-            _worldScale.IsDisabled = true;
+            worldScaleNotches.Add(worldScaleNotches.Last() * 2);
         }
 
+        Globals.Database.WorldZoom = (float)MathHelper.Clamp(
+            Globals.Database.WorldZoom,
+            worldScaleNotches.Min(),
+            worldScaleNotches.Max()
+        );
+
         _worldScale.SetRange(worldScaleNotches.Min(), worldScaleNotches.Max());
         _worldScale.Notches = worldScaleNotches.ToArray();
         _worldScale.Value = Globals.Database.WorldZoom;
@@ -1175,7 +1174,10 @@ private void SettingsApplyBtn_Clicked(Base sender, MouseButtonState arguments)
 
         // Video Settings.
         Globals.Database.EnableScrollingWorldZoom = _enableScrollingWorldZoomCheckbox.IsChecked;
-        Globals.Database.WorldZoom = (float)_worldScale.Value;
+        if (!_worldScale.IsHidden)
+        {
+            Globals.Database.WorldZoom = (float)_worldScale.Value;
+        }
 
         var resolutionItem = _resolutionList.SelectedItem;
         var targetResolution = resolutionItem?.UserData as int? ?? -1;