unify items (#2634)

* unify "items" files under SlotItem class

* created PopulateSlotContainer

* making items having 1 context menu shared between all items

* initialize menu context on construtor

Author: WeylonSantana

Intersect.Client.Core/Interface/Game/Bag/BagItem.cs

@@ -5,6 +5,7 @@
 using Intersect.Client.Framework.Input;
 using Intersect.Client.General;
 using Intersect.Client.Interface.Game.DescriptionWindows;
+using Intersect.Client.Interface.Game.Inventory;
 using Intersect.Client.Networking;
 using Intersect.Configuration;
 using Intersect.Framework.Core;
@@ -280,15 +281,20 @@ public void Update()
                     {
                         for (var i = 0; i < Options.Instance.Player.MaxInventory; i++)
                         {
-                            if (invWindow.Items[i].RenderBounds().IntersectsWith(dragRect))
+                            if(invWindow.Items[i] is not InventoryItem inventoryItem)
                             {
-                                if (FloatRect.Intersect(invWindow.Items[i].RenderBounds(), dragRect).Width *
-                                    FloatRect.Intersect(invWindow.Items[i].RenderBounds(), dragRect).Height >
+                                continue;
+                            }
+
+                            if (inventoryItem.RenderBounds().IntersectsWith(dragRect))
+                            {
+                                if (FloatRect.Intersect(inventoryItem.RenderBounds(), dragRect).Width *
+                                    FloatRect.Intersect(inventoryItem.RenderBounds(), dragRect).Height >
                                     bestIntersect)
                                 {
                                     bestIntersect =
-                                        FloatRect.Intersect(invWindow.Items[i].RenderBounds(), dragRect).Width *
-                                        FloatRect.Intersect(invWindow.Items[i].RenderBounds(), dragRect).Height;
+                                        FloatRect.Intersect(inventoryItem.RenderBounds(), dragRect).Width *
+                                        FloatRect.Intersect(inventoryItem.RenderBounds(), dragRect).Height;
 
                                     bestIntersectIndex = i;
                                 }

Intersect.Client.Core/Interface/Game/Bank/BankItem.cs

@@ -6,6 +6,7 @@
 using Intersect.Client.General;
 using Intersect.Client.Interface.Game.Chat;
 using Intersect.Client.Interface.Game.DescriptionWindows;
+using Intersect.Client.Interface.Game.Inventory;
 using Intersect.Client.Localization;
 using Intersect.Client.Networking;
 using Intersect.Configuration;
@@ -330,7 +331,11 @@ public void Update()
                     );
                     for (var inventoryIndex = 0; inventoryIndex < inventorySlotLimit; inventoryIndex++)
                     {
-                        var inventorySlotComponent = inventorySlots[inventoryIndex];
+                        if (inventorySlots[inventoryIndex] is not InventoryItem inventorySlotComponent)
+                        {
+                            continue;
+                        }
+
                         var inventorySlotRenderBounds = inventorySlotComponent.RenderBounds();
                         if (!inventorySlotRenderBounds.IntersectsWith(dragRect))
                         {