Merge pull request #25 from AsenaJs/patch/config-name-undefined

Patch: Config name not found bug fixed

Author: LibirSoft

.changeset/funny-buses-appear.md

@@ -0,0 +1,5 @@
+---
+'@asenajs/asena': patch
+---
+
+Config service name undefined bug fixed

README.md

@@ -1,11 +1,11 @@
 # Asena
 
-Asena is a NestJS-like IoC web framework built on top of Hono and Bun. It combines the power of dependency injection
+Asena is a NestJS-like IoC web framework built on top of Bun. It combines the power of dependency injection
 with the performance of Bun runtime and the flexibility of Adapter design system.
 
 ## Documentation
 
-For detailed documentation, please visit [not ready yet](https://asena.sh). Documentation is still in progress, but updates are being made regularly.
+For detailed documentation, please visit [not ready yet](https://asena.sh). Documentation is still in progress, but updates are being made regularly. You can check this project [AsenaExample](https://github.com/LibirSoft/AsenaExample). I am always updating it to latest usages.
 
 ## Key Features
 
@@ -19,12 +19,6 @@ For detailed documentation, please visit [not ready yet](https://asena.sh). Docu
 - **TypeScript Support**: Full TypeScript support with strict mode
 - **Modular Architecture**: Easy to extend and customize
 
-## Installation
-
-```bash
-bun add @asenajs/asena
-```
-
 ## Quick Start
 
 The easiest way to create a new Asena project is using the CLI:
@@ -36,6 +30,7 @@ asena create
 ```
 
 This will create a new project with the following structure:
+
 ```
 ├── src/
 │ ├── controllers/
@@ -47,6 +42,8 @@ This will create a new project with the following structure:
 ├── .eslintignore
 └── .prettierrc.js
 ```
+## Alternative start
+
 
 Alternatively, you can create a project manually:
 
@@ -89,24 +86,26 @@ For decorators working properly, you need to add some settings to your tsconfig.
   }
 }
 ```
-
-Then, install the required packages:
-
+After that you need to make sure to edit your tsConfig.json it should look like this
+Then, install these packages:
+* `@asenajs/asena`: Base package
+* `@asenajs/hono-adapter`: For web-server. Asena currently only support hono adapter.
+* `@asenajs/asena-logger`: For better logs
 ```bash
-bun add @asenajs/asena @asenajs/hono-adapter 
+bun install @asenajs/asena @asenajs/hono-adapter @asenajs/asena-logger
 ```
 
-Add @asenajs/asena-cli to your package. This package provides a CLI for creating and managing Asena projects.
+* `@asenajs/asena-cli`: This package provides a CLI for creating and managing Asena projects.
 
 ```bash
-bun add -D @asenajs/asena-cli
+bun install -D @asenajs/asena-cli
 ```
-
-Then, create a new asena-config.ts file using the CLI:
+After installation, you need to create asena-config.ts file you can create it with asena-cli
 
 ```bash
 asena init
 ```
+this will create you asena-config file.
 
 `Note`: Built options directly copy of bun options, you can check bun documentation for more
 options. [Bun Documentation](https://bun.sh/docs/bundler#reference)
@@ -115,15 +114,14 @@ Create index.ts file under your src folder:
 
 ```typescript
 // src/index.ts
-import { AsenaServer } from '@asenajs/asena';
-import { DefaultLogger } from "@asenajs/asena/logger";
-import { createHonoAdapter } from '@asenajs/hono-adapter';
-
-const [adapter, logger] = createHonoAdapter(new DefaultLogger());
-await new AsenaServer(adapter)
-  .logger(logger)
-  .port(3000)
-  .start(true);
+import {AsenaServer} from '@asenajs/asena';
+import {createHonoAdapter} from '@asenajs/hono-adapter';
+import {logger} from './logger/logger';
+
+const [honoAdapter,asenaLogger] = createHonoAdapter(logger);
+
+
+await new AsenaServer(honoAdapter, asenaLogger).port(3000).start();
 ```
 
 To run asena you need at least one controller. Create a new controller:
@@ -136,10 +134,10 @@ import { Get } from '@asenajs/asena/web';
 
 @Controller('/hello')
 export class TestController {
-    @Get('/world')
-    public async getHello(context: Context) {
-        return context.send('Hello World');
-    }
+  @Get('/world')
+  public async getHello(context: Context) {
+    return context.send('Hello World');
+  }
 }
 ```
 
@@ -160,8 +158,7 @@ bun index.asena.js
 ## CLI Commands
 
 For more information about CLI commands and usage, please visit:
-[Asena CLI Documentation](https://github.com/AsenaJs/Asena-cli/blob/master/README.md)
-
+[Asena CLI Documentation](https://asena.sh/docs/cli/overview.html)
 
 ## Project Structure
 
@@ -172,7 +169,6 @@ lib/
 ├── ioc/         # Dependency injection container
 ├── utils/       # Utility functions
 ├── test/        # Test utilities
-└── logger/      # Logging system
 ```
 
 ## Core Concepts

lib/server/AsenaServer.ts

@@ -66,7 +66,7 @@ export class AsenaServer<A extends AsenaAdapter<any, any>> {
     const config = await readConfigFile();
 
     if (!config) {
-      this._logger.warn('Config file not found');
+      this._logger.warn('asena-config file not found');
     }
 
     this._ioc = new IocEngine(config);
@@ -264,7 +264,7 @@ export class AsenaServer<A extends AsenaAdapter<any, any>> {
       }
     }
 
-    const name = getTypedMetadata<string>(ComponentConstants.NameKey, configInstance);
+    const name = getOwnTypedMetadata<string>(ComponentConstants.NameKey, configInstance.constructor);
 
     this._logger.info(`Config ${yellow(name)} applied`);
   }

lib/server/src/services/PrepareConfigService.ts

@@ -37,7 +37,7 @@ export class PrepareConfigService extends PrepareService {
 
     const name = getTypedMetadata<string>(ComponentConstants.NameKey, config[0].constructor);
 
-    this.logger.info(`Config found ${yellow(name)}`);
+    this.logger.info(`AsenaConfig service found ${yellow(name)}`);
 
     return configInstance;
   }

lib/server/src/services/PrepareMiddlewareService.ts

@@ -22,16 +22,20 @@ export class PrepareMiddlewareService extends PrepareService {
 
     for (const middleware of middlewares) {
       const name = getTypedMetadata<string>(ComponentConstants.NameKey, middleware);
-      const override = getTypedMetadata<string[]>(ComponentConstants.OverrideKey, middleware);
-      const isOverride = override ? override.includes('handle') : false;
 
       const instances = await this.container.resolve<AsenaMiddlewareService>(name);
 
       if (!instances) continue;
 
       const normalizedInstances = Array.isArray(instances) ? instances : [instances];
+      let override: string[];
+      let isOverride: boolean;
 
       for (const instance of normalizedInstances) {
+        override = getTypedMetadata<string[]>(ComponentConstants.OverrideKey, instance);
+
+        isOverride = override ? override.includes('handle') : false;
+
         preparedMiddlewares.push({
           handle: instance.handle.bind(instance),
           override: isOverride,

lib/server/src/services/PrepareStaticServeConfigService.ts

@@ -1,5 +1,5 @@
 import { PrepareService } from '../PrepareService';
-import { getTypedMetadata } from '../../../utils/typedMetadata';
+import { getOwnTypedMetadata, getTypedMetadata } from '../../../utils/typedMetadata';
 import { ComponentConstants } from '../../../ioc/constants';
 import type { AsenaStaticServeService, StaticServeClass } from '../../web/middleware';
 import type { BaseStaticServeParams } from '../../../adapter';
@@ -17,21 +17,21 @@ export class PrepareStaticServeConfigService extends PrepareService {
       return;
     }
 
-    const name = getTypedMetadata<string>(ComponentConstants.NameKey, staticServeClass);
-    const root = getTypedMetadata<string>(ComponentConstants.StaticServeRootKey, staticServeClass);
+    const name = getOwnTypedMetadata<string>(ComponentConstants.NameKey, staticServeClass);
+    const root = getOwnTypedMetadata<string>(ComponentConstants.StaticServeRootKey, staticServeClass);
 
-    const staticServeService: AsenaStaticServeService<any>[] | AsenaStaticServeService<any> =
+    const staticServeServiceInstance: AsenaStaticServeService<any>[] | AsenaStaticServeService<any> =
       await this.container.resolve<AsenaStaticServeService<any>>(name);
 
-    if (!staticServeService) {
+    if (!staticServeServiceInstance) {
       throw new Error(`Static Serve service ${name} not found.`);
     }
 
-    if (Array.isArray(staticServeService)) {
+    if (Array.isArray(staticServeServiceInstance)) {
       throw new Error('Static serve service cannot be array');
     }
 
-    const overrides: string[] = getTypedMetadata<string[]>(ComponentConstants.OverrideKey, staticServeService);
+    const overrides: string[] = getTypedMetadata<string[]>(ComponentConstants.OverrideKey, staticServeServiceInstance);
 
     const baseStaticServeParams: BaseStaticServeParams = {
       extra: undefined,
@@ -41,24 +41,24 @@ export class PrepareStaticServeConfigService extends PrepareService {
       onNotFound: undefined,
     };
 
-    if (staticServeService.extra) {
-      baseStaticServeParams.extra = staticServeService.extra;
+    if (staticServeServiceInstance.extra) {
+      baseStaticServeParams.extra = staticServeServiceInstance.extra;
     }
 
-    if (staticServeService.rewriteRequestPath) {
-      baseStaticServeParams.rewriteRequestPath = staticServeService.rewriteRequestPath;
+    if (staticServeServiceInstance.rewriteRequestPath) {
+      baseStaticServeParams.rewriteRequestPath = staticServeServiceInstance.rewriteRequestPath;
     }
 
-    if (staticServeService.onFound) {
+    if (staticServeServiceInstance.onFound) {
       baseStaticServeParams.onFound = {
-        handler: staticServeService.onFound.bind(staticServeService),
+        handler: staticServeServiceInstance.onFound.bind(staticServeServiceInstance),
         override: overrides?.includes('onFound'),
       };
     }
 
-    if (staticServeService.onNotFound) {
+    if (staticServeServiceInstance.onNotFound) {
       baseStaticServeParams.onNotFound = {
-        handler: staticServeService.onNotFound.bind(staticServeService),
+        handler: staticServeServiceInstance.onNotFound.bind(staticServeServiceInstance),
         override: overrides?.includes('onNotFound'),
       };
     }

lib/test/server/src/PrepareConfigService.test.ts

@@ -1,7 +1,6 @@
 import { beforeEach, describe, expect, mock, test } from 'bun:test';
 import { PrepareConfigService } from '../../../server/src/services/PrepareConfigService';
 import { ComponentType } from '../../../ioc/types';
-import { ComponentConstants } from '../../../ioc/constants';
 import type { AsenaConfig } from '../../../server/config';
 import { Config } from '../../../server/decorators';
 import { yellow } from '../../../logger';
@@ -55,21 +54,11 @@ describe('PrepareConfigService', () => {
 
     mockContainer.resolveAll.mockImplementation(() => [mockConfig]);
 
-    const getTypedMetadataMock = mock().mockReturnValue('TestConfig');
-
-    mock.module('../../../utils/typedMetadata', () => {
-      return {
-        getTypedMetadata: getTypedMetadataMock,
-      };
-    });
-
     const result = await service.prepare();
 
     expect(mockContainer.resolveAll).toHaveBeenCalledWith(ComponentType.CONFIG);
-    expect(getTypedMetadataMock).toHaveBeenCalledWith(ComponentConstants.NameKey, mockConfig.constructor);
-    expect(mockLogger.info).toHaveBeenCalledWith(`Config found ${yellow('TestConfig')}`);
+    expect(mockLogger.info).toHaveBeenCalledWith(`AsenaConfig service found ${yellow('TestConfig')}`);
     expect(result).toBe(mockConfig);
-    getTypedMetadataMock.mockClear();
   });
 
   test('should return when config not found in instance object', async () => {