Fixing issue with GetStatusCodes not binding API response

Author: AshleyPoole

SSLLWrapper/Domain/ResponsePopulation.cs

@@ -50,15 +50,15 @@ public Endpoint EndpointModel(HttpWebResponse webResponse, Endpoint endpointMode
 			return endpointModel;
 		}
 
-		public StatusDetails StatusDetailsModel(HttpWebResponse webResponse, StatusDetails statusDetails)
+		public StatusCodes StatusCodesModel(HttpWebResponse webResponse, StatusCodes statusCodes)
 		{
 			var webResult = _webResponseReader.GetResponsePayload(webResponse);
 
-			statusDetails = JsonConvert.DeserializeObject<StatusDetails>(webResult, JsonSerializerSettings);
-			statusDetails.Header.statusCode = _webResponseReader.GetStatusCode(webResponse);
-			statusDetails.Header.statusDescription = _webResponseReader.GetStatusDescription(webResponse);
+			statusCodes = JsonConvert.DeserializeObject<StatusCodes>(webResult, JsonSerializerSettings);
+			statusCodes.Header.statusCode = _webResponseReader.GetStatusCode(webResponse);
+			statusCodes.Header.statusDescription = _webResponseReader.GetStatusDescription(webResponse);
 
-			return statusDetails;
+			return statusCodes;
 		}
 	}
 }

SSLLWrapper/Models/Response/StatusCodes.cs

@@ -0,0 +1,13 @@
+namespace SSLLWrapper.Models.Response
+{
+	public class StatusCodes : BaseModel
+	{
+		public StatusDetails StatusDetails { get; set; }
+
+		public StatusCodes()
+		{
+			StatusDetails = new StatusDetails();
+		}
+			
+	}
+}

SSLLWrapper/Models/Response/StatusDetails.cs renamed to SSLLWrapper/Models/Response/StatusCodesSubModels/StatusDetails.cs

@@ -1,6 +1,6 @@
 namespace SSLLWrapper.Models.Response
 {
-	public class StatusDetails : BaseModel
+	public class StatusDetails
 	{
 		public string TESTING_PROTOCOL_INTOLERANCE_399 { get; set; }
 		public string PREPARING_REPORT { get; set; }

SSLLWrapper/SSLLService.cs

@@ -173,9 +173,9 @@ public Endpoint GetEndpointData(string host, string s, FromCache fromCache)
 		    return endpointModel;
 	    }
 
-	    public StatusDetails GetStatusCodes()
+	    public StatusCodes GetStatusCodes()
 	    {
-		    var statusDetailsModel = new StatusDetails();
+			var statusCodesModel = new StatusCodes();
 
 			// Building request model
 		    var requestModel = _requestModelFactory.NewStatusCodesRequestModel(ApiUrl, "getStatusCodes");
@@ -186,15 +186,15 @@ public StatusDetails GetStatusCodes()
 			    var webResponse = _apiProvider.MakeGetRequest(requestModel);
 
 				// Binding result to model
-			    statusDetailsModel = _responsePopulation.StatusDetailsModel(webResponse, statusDetailsModel);
+			    statusCodesModel = _responsePopulation.StatusCodesModel(webResponse, statusCodesModel);
 		    }
 		    catch (Exception ex)
 		    {
-				statusDetailsModel.HasErrorOccurred = true;
-				statusDetailsModel.Errors.Add(new Error { message = ex.ToString() });
+				statusCodesModel.HasErrorOccurred = true;
+				statusCodesModel.Errors.Add(new Error { message = ex.ToString() });
 		    }
 
-		    return statusDetailsModel;
+		    return statusCodesModel;
 	    }
     }
 }

SSLLWrapper/SSLLWrapper.csproj

@@ -45,6 +45,7 @@
   </ItemGroup>
   <ItemGroup>
     <Compile Include="External\SSLLabsApi.cs" />
+    <Compile Include="Models\Response\StatusCodes.cs" />
     <Compile Include="SSLLService.cs" />
     <Compile Include="Domain\WebResponseReader.cs" />
     <Compile Include="Interfaces\IApiProvider.cs" />
@@ -69,7 +70,7 @@
     <Compile Include="Models\Response\EndpointSubModels\Details.cs" />
     <Compile Include="Models\Response\Info.cs" />
     <Compile Include="Models\RequestModel.cs" />
-    <Compile Include="Models\Response\StatusDetails.cs" />
+    <Compile Include="Models\Response\StatusCodesSubModels\StatusDetails.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
   </ItemGroup>
   <ItemGroup>