Skip to content

Commit e0120e5

Browse files
committed
Complete Analyze method
1 parent 6a1d563 commit e0120e5

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

SSLLWrapper.ConsoleAppTester/Program.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ static void AnalyzeTester()
1818
var analyze = apiService.Analyze("http://www.ashleypoole.co.uk");
1919

2020
Console.WriteLine("Has Error Occoured: {0}", analyze.HasErrorOccurred);
21-
Console.WriteLine("First Error Message: {0}", analyze.Errors.First().message);
2221
Console.WriteLine("Status Code: {0}", analyze.Headers.statusCode);
2322
Console.WriteLine("Status: {0}", analyze.status);
2423

SSLLWrapper/ApiService.cs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public InfoModel Info()
7070
var webResult = _webResponseHelper.GetResponsePayload(webResponse);
7171

7272
// ** TO DO - Check for error before converting to model. Expand model to include error properties?
73-
infoModel = (InfoModel)JsonConvert.DeserializeObject(webResult, JsonSerializerSettings);
73+
infoModel = JsonConvert.DeserializeObject<InfoModel>(webResult, JsonSerializerSettings);
7474

7575
if (infoModel.engineVersion != null)
7676
{
@@ -104,18 +104,20 @@ public AnalyzeModel Analyze(string host, Publish publish, ClearCache clearCache,
104104
return analyzeModel;
105105
}
106106

107-
// Building request model before issuing Api request
107+
// Building request model
108108
var requestModel = _requestModelHelper.AnalyzeProperties(ApiUrl, "analyze", host, publish.ToString().ToLower(), clearCache.ToString().ToLower(),
109109
fromCache.ToString().ToLower(), all.ToString().ToLower());
110110

111111
try
112112
{
113+
// Making Api request and gathering response
113114
var webResponse = _api.MakeGetRequest(requestModel);
114115
var webResult = _webResponseHelper.GetResponsePayload(webResponse);
115116

116-
// ** TO DO - Check for error before converting to model. Expand model to include error properties?
117-
analyzeModel = (AnalyzeModel)JsonConvert.DeserializeObject(webResult, JsonSerializerSettings);
118-
117+
// Trying to bind result to model
118+
analyzeModel = JsonConvert.DeserializeObject<AnalyzeModel>(webResult, JsonSerializerSettings);
119+
analyzeModel.Headers.statusCode = _webResponseHelper.GetStatusCode(webResponse);
120+
analyzeModel.Headers.statusDescription = _webResponseHelper.GetStatusDescription(webResponse);
119121
}
120122
catch (Exception ex)
121123
{

0 commit comments

Comments
 (0)