feat: update clock sysvar in BlockComponentProcessor (anza-xyz#595)

Now that we can process `BlockComponent`s during replay, update the
clock sysvar when we observe the block footer.

This PR exposes the Alpenglow clock to `BlockComponentProcessor`, which
we'll next modify to enforce the Alpenglow clock bounds outlined in
solana-foundation/solana-improvement-documents#363.

Author: ksn6

core/src/block_creation_loop.rs

@@ -26,6 +26,7 @@ use {
     solana_runtime::{
         bank::{Bank, NewBankOptions},
         bank_forks::BankForks,
+        block_component_processor::BlockComponentProcessor,
         leader_schedule_utils::{last_of_consecutive_leader_slots, leader_slot_index},
     },
     solana_version::version,
@@ -136,17 +137,15 @@ enum StartLeaderError {
     ),
 }
 
-fn produce_block_footer(block_producer_time_nanos: u64) -> VersionedBlockMarker {
-    let footer = BlockFooterV1 {
+fn produce_block_footer(block_producer_time_nanos: u64) -> BlockFooterV1 {
+    BlockFooterV1 {
         bank_hash: Hash::default(),
         block_producer_time_nanos,
         block_user_agent: format!("agave/{}", version!()).into_bytes(),
         final_cert: None,
         skip_reward_cert: None,
         notar_reward_cert: None,
-    };
-
-    VersionedBlockMarker::new_block_footer(footer)
+    }
 }
 
 /// The block creation loop.
@@ -402,7 +401,7 @@ fn record_and_complete_block(
     let mut w_poh_recorder = poh_recorder.write().unwrap();
     let block_producer_time_nanos = w_poh_recorder.working_bank_block_producer_time_nanos();
     let footer = produce_block_footer(block_producer_time_nanos);
-    w_poh_recorder.send_marker(footer)?;
+    w_poh_recorder.send_marker(VersionedBlockMarker::new_block_footer(footer.clone()))?;
 
     // Alpentick and clear bank
     let bank = w_poh_recorder
@@ -419,9 +418,14 @@ fn record_and_complete_block(
     // Set the tick height for the bank to max_tick_height - 1, so that PohRecorder::flush_cache()
     // will properly increment the tick_height to max_tick_height.
     bank.set_tick_height(max_tick_height - 1);
-    // Write the single tick for this slot
+
+    BlockComponentProcessor::update_bank_with_footer(
+        bank.clone(),
+        &footer,
+    );
+
     drop(bank);
-    w_poh_recorder.tick_alpenglow(max_tick_height);
+    w_poh_recorder.tick_alpenglow(max_tick_height, footer);
 
     Ok(())
 }

ledger/src/blockstore_processor.rs

@@ -1578,7 +1578,12 @@ pub fn confirm_slot(
             }
             BlockComponent::BlockMarker(marker) => {
                 processor
-                    .on_marker(&marker, migration_status, is_final)
+                    .on_marker(
+                        bank.clone_without_scheduler(),
+                        &marker,
+                        migration_status,
+                        is_final,
+                    )
                     .inspect_err(|err| {
                         warn!("Block component processing failed for slot {slot}: {err:?}",);
                     })?;

poh/src/poh_recorder.rs

@@ -23,7 +23,7 @@ use {
     log::*,
     solana_clock::{BankId, NUM_CONSECUTIVE_LEADER_SLOTS, Slot},
     solana_entry::{
-        block_component::VersionedBlockMarker,
+        block_component::{BlockFooterV1, VersionedBlockMarker},
         entry::Entry,
         poh::{Poh, PohEntry},
     },
@@ -930,7 +930,7 @@ impl PohRecorder {
             .as_nanos() as u64
     }
 
-    pub fn tick_alpenglow(&mut self, slot_max_tick_height: u64) {
+    pub fn tick_alpenglow(&mut self, slot_max_tick_height: u64, _footer: BlockFooterV1) {
         let (poh_entry, tick_lock_contention_us) = measure_us!({
             let mut poh_l = self.poh.lock().unwrap();
             poh_l.tick()

runtime/src/bank.rs

@@ -1452,7 +1452,12 @@ impl Bank {
         let (_, update_sysvars_time_us) = measure_us!({
             new.update_slot_hashes();
             new.update_stake_history(Some(parent.epoch()));
-            new.update_clock(Some(parent.epoch()));
+
+            // If Alpenglow is enabled, update the clock from the footer.
+            if new.get_alpenglow_genesis_certificate().is_none() {
+                new.update_clock(Some(parent.epoch()));
+            }
+
             new.update_last_restart_slot()
         });
 

runtime/src/block_component_processor.rs

@@ -1,8 +1,11 @@
 use {
+    crate::bank::Bank,
     agave_votor_messages::migration::MigrationStatus,
     solana_entry::block_component::{
-        BlockMarkerV1, VersionedBlockFooter, VersionedBlockHeader, VersionedBlockMarker,
+        BlockFooterV1, BlockMarkerV1, VersionedBlockFooter, VersionedBlockHeader,
+        VersionedBlockMarker,
     },
+    std::sync::Arc,
     thiserror::Error,
 };
 
@@ -63,6 +66,7 @@ impl BlockComponentProcessor {
 
     pub fn on_marker(
         &mut self,
+        bank: Arc<Bank>,
         marker: &VersionedBlockMarker,
         migration_status: &MigrationStatus,
         is_final: bool,
@@ -75,7 +79,7 @@ impl BlockComponentProcessor {
         let VersionedBlockMarker::V1(marker) = marker;
 
         match marker {
-            BlockMarkerV1::BlockFooter(footer) => self.on_footer(footer.inner()),
+            BlockMarkerV1::BlockFooter(footer) => self.on_footer(bank, footer.inner()),
             BlockMarkerV1::BlockHeader(header) => self.on_header(header.inner()),
             // We process UpdateParent messages on shred ingest, so no callback needed here.
             BlockMarkerV1::UpdateParent(_) => Ok(()),
@@ -91,7 +95,8 @@ impl BlockComponentProcessor {
 
     fn on_footer(
         &mut self,
-        _footer: &VersionedBlockFooter,
+        bank: Arc<Bank>,
+        footer: &VersionedBlockFooter,
     ) -> Result<(), BlockComponentProcessorError> {
         // The block header must be the first component of each block.
         if !self.has_header {
@@ -102,6 +107,9 @@ impl BlockComponentProcessor {
             return Err(BlockComponentProcessorError::MultipleBlockFooters);
         }
 
+        let VersionedBlockFooter::V1(footer) = footer;
+        Self::update_bank_with_footer(bank, footer);
+
         self.has_footer = true;
         Ok(())
     }
@@ -117,4 +125,11 @@ impl BlockComponentProcessor {
         self.has_header = true;
         Ok(())
     }
+
+    pub fn update_bank_with_footer(bank: Arc<Bank>, footer: &BlockFooterV1) {
+        // Update clock sysvar from footer timestamp.
+        bank.update_clock_from_footer(footer.block_producer_time_nanos as i64);
+
+        // TODO: rewards
+    }
 }