Skip to content

Commit b0527f0

Browse files
fix(storage): set path via ๐˜ค๐˜ฉ๐˜ช๐˜ญ๐˜ฅ for ๐˜ฅ๐˜ฆ๐˜ญ๐˜ฆ๐˜ต๐˜ฆ
1๏ธโƒฃ ๐˜ต๐˜ฐ๐˜ฌ๐˜ฆ๐˜ฏ param is now optional 2๏ธโƒฃ file path is now set via ๐™˜๐™๐™ž๐™ก๐™™ method, same way used for other methods, instead of ๐˜ฏ๐˜ข๐˜ฎ๐˜ฆ param which is removed.
1 parent 23cb95b commit b0527f0

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

โ€Žfirebase/storage/__init__.pyโ€Ž

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ def put(self, file, token=None):
131131

132132
return request_object.json()
133133

134-
def delete(self, name, token):
134+
def delete(self, token=None):
135135
""" Delete file from storage.
136136
137137
| For more details:
@@ -145,17 +145,23 @@ def delete(self, name, token):
145145
https://firebase.google.com/docs/storage/web/delete-files#delete_a_file
146146
147147
148-
:type name: str
149-
:param name: Cloud path to file.
150-
151148
:type token: str
152-
:param token: Firebase Auth User ID Token
149+
:param token: (Optional) Firebase Auth User ID Token, defaults
150+
to :data:`None`.
153151
"""
154152

153+
# reset path
154+
path = self.path
155+
self.path = None
156+
157+
# remove leading backlash
158+
if path.startswith('/'):
159+
path = path[1:]
160+
155161
if self.credentials:
156-
self.bucket.delete_blob(name)
162+
self.bucket.delete_blob(path)
157163
else:
158-
request_ref = self.storage_bucket + "/o?name={0}".format(name)
164+
request_ref = self.storage_bucket + "/o?name={0}".format(path)
159165

160166
if token:
161167
headers = {"Authorization": "Firebase " + token}

โ€Žtests/test_storage.pyโ€Ž

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ def test_download(self, storage):
2323
assert os.path.exists('tests/static/downloaded.txt')
2424

2525
def test_delete(self, storage):
26-
assert storage.delete('firebase-test-001/uploaded-file.txt', None) is None
26+
os.remove('tests/static/downloaded.txt')
27+
assert storage.child('firebase-test-001/uploaded-file.txt').delete() is None
2728

2829
def test_list_of_files(self, storage):
2930
assert storage.list_files()

0 commit comments

Comments
ย (0)