fix(storage): set path via 𝘤𝘩𝘪𝘭𝘥 for 𝘥𝘰𝘸𝘯𝘭𝘰𝘢𝘥

1️⃣  removes unnecessary param 𝘱𝘢𝘵𝘩 which is need only when having admin access.
2️⃣  resolves need of path to file via 𝘱𝘢𝘵𝘩 param instead of using path built via 𝒄𝒉𝒊𝒍𝒅 method.

Author: AsifArmanRahman

firebase/storage/__init__.py

@@ -165,7 +165,7 @@ def delete(self, name, token):
 
 			raise_detailed_error(request_object)
 
-	def download(self, path, filename, token=None):
+	def download(self, filename, token=None):
 		""" Download file from storage.
 
 		| For more details:
@@ -179,9 +179,6 @@ def download(self, path, filename, token=None):
 			https://firebase.google.com/docs/storage/web/download-files#download_data_via_url
 
 
-		:type path: str
-		:param path: Path to cloud file
-
 		:type filename:  str
 		:param filename: File name to be downloaded as.
 
@@ -190,28 +187,31 @@ def download(self, path, filename, token=None):
 			to :data:`None`.
 		"""
 
-		# remove leading backlash
-		url = self.get_url(token)
+		if self.credentials:
 
-		if path.startswith('/'):
-			path = path[1:]
+			# reset path
+			path = self.path
+			self.path = None
+
+			# remove leading backlash
+			if path.startswith('/'):
+				path = path[1:]
 
-		if self.credentials:
 			blob = self.bucket.get_blob(path)
-			if not blob is None:
+			if blob is not None:
 				blob.download_to_filename(filename)
 
 		elif token:
 			headers = {"Authorization": "Firebase " + token}
-			r = requests.get(url, stream=True, headers=headers)
+			r = requests.get(self.get_url(token), stream=True, headers=headers)
 
 			if r.status_code == 200:
 				with open(filename, 'wb') as f:
 					for chunk in r:
 						f.write(chunk)
 
 		else:
-			r = requests.get(url, stream=True)
+			r = requests.get(self.get_url(token), stream=True)
 
 			if r.status_code == 200:
 				with open(filename, 'wb') as f:

tests/test_storage.py

@@ -2,7 +2,7 @@
 #   Licensed under MIT (https://github.com/AsifArmanRahman/firebase/blob/main/LICENSE)
 
 # --------------------------------------------------------------------------------------
-
+import os.path
 
 import pytest
 
@@ -18,6 +18,10 @@ def test_put(self, storage):
 	def test_get_url(self, storage):
 		assert storage.child('firebase-test-001').child('uploaded-file.txt').get_url(None)
 
+	def test_download(self, storage):
+		assert storage.child('firebase-test-001').child('uploaded-file.txt').download('tests/static/downloaded.txt') is None
+		assert os.path.exists('tests/static/downloaded.txt')
+
 	def test_delete(self, storage):
 		assert storage.delete('firebase-test-001/uploaded-file.txt', None) is None