Skip to content

Conversation

o-az
Copy link

@o-az o-az commented Nov 14, 2024

Fixes # .

Changes proposed in this pull request:

Deno now supports node process. It requires it to be imported from node:process then it should work the same way. This change means it's no longer necessary to check whether the runtime is Deno

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

o-az added 2 commits November 14, 2024 05:07
Deno now supports node process. It requires it to be imported from `node:process` then it should work the same way. This change means it's no longer necessary to check whether the runtime is Deno
@o-az o-az marked this pull request as ready for review November 14, 2024 13:14
Copy link
Member

@CountBleck CountBleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we still need isDeno...did you actually test this code with Deno before sending a PR?

@o-az o-az closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants