Skip to content

Commit 5df0c1f

Browse files
ds5678SamboyCoding
authored andcommitted
Address feedback
1 parent 1a8c45e commit 5df0c1f

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

Cpp2IL.Core/OutputFormats/AsmResolverDummyDllOutputFormat.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ private List<AssemblyDefinition> BuildStubAssemblies(ApplicationAnalysisContext
150150
var corlib = context.Assemblies.First(a => a.Name == "mscorlib");
151151
MostRecentCorLib = BuildStubAssembly(corlib, null, null);
152152

153+
// The runtime info is irrelevant because we're creating our own corlib, but AsmResolver still requires that we specify one.
153154
var runtimeContext = new RuntimeContext(DotNetRuntimeInfo.NetCoreApp(9, 0), (bool?)null, MostRecentCorLib);
154155
runtimeContext.AddAssembly(MostRecentCorLib);
155156

Cpp2IL.Core/Utils/AsmResolver/AsmResolverAssemblyPopulator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -542,7 +542,7 @@ private static void AddExplicitInterfaceImplementations(TypeDefinition type, Typ
542542
var method = methodContext.GetExtraData<MethodDefinition>("AsmResolverMethod") ?? throw new($"AsmResolver method not found in method analysis context for {methodContext}");
543543
type.MethodImplementations.Add(new MethodImplementation(interfaceMethod, method));
544544
var resolutionStatus = interfaceMethod.Resolve(runtimeContext, out var interfaceMethodResolved);
545-
if (resolutionStatus is ResolutionStatus.Success && interfaceMethodResolved != null)
545+
if (resolutionStatus == ResolutionStatus.Success && interfaceMethodResolved != null)
546546
{
547547
if (interfaceMethodResolved.IsGetMethod && !method.IsGetMethod)
548548
{

0 commit comments

Comments
 (0)