update lint (#43)

Update lint rules.
Ignore lint rules to build.
Fix some lint rules.

Author: afucher

.eslintrc.js

@@ -1,16 +1,67 @@
 module.exports = {
-  env: {
-    browser: true,
-    es2021: true
+  'env': {
+    'browser': true,
+    'commonjs': true,
+    'es6': true
   },
-  extends: 'standard-with-typescript',
-  overrides: [
+  'extends': [
+    'eslint:recommended',
+    'plugin:@typescript-eslint/eslint-recommended'
   ],
-  parserOptions: {
-    ecmaVersion: 'latest',
-    sourceType: 'module',
-    project: ['tsconfig.json']
+  'globals': {
+    'Atomics': 'readonly',
+    'SharedArrayBuffer': 'readonly'
   },
-  rules: {
-  }
-}
+  'parser': '@typescript-eslint/parser',
+  'parserOptions': {
+    'sourceType': 'module',
+    'ecmaVersion': 2018
+  },
+  'plugins': [
+    '@typescript-eslint'
+  ],
+  'rules': {
+    'indent': [
+      'error',
+      2,
+      { 'SwitchCase': 1 }
+    ],
+    'linebreak-style': [
+      'error',
+      'unix'
+    ],
+    'quotes': [
+      'error',
+      'single',
+      { 'allowTemplateLiterals': true }
+    ],
+    'semi': [
+      'error',
+      'never'
+    ],
+    'no-var': ['error'],
+    '@typescript-eslint/member-delimiter-style': [
+      'error',
+      {
+        'multiline': {
+          'delimiter': 'none',
+          'requireLast': true
+        },
+        'singleline': {
+          'delimiter': 'semi',
+          'requireLast': false
+        }
+      }
+    ],
+    '@typescript-eslint/explicit-function-return-type': 'off',
+    '@typescript-eslint/no-unused-vars': ['warn', { 'vars': 'all', 'args': 'after-used', 'ignoreRestSiblings': false }],
+    'no-unused-vars': 'off',
+    '@typescript-eslint/restrict-plus-operands': 'off',
+    //'@typescript-eslint/no-unused-vars': 'off',
+    '@typescript-eslint/prefer-optional-chain': 'off',
+    '@typescript-eslint/naming-convention': 'off',
+    '@typescript-eslint/strict-boolean-expressions': 'off',
+    '@typescript-eslint/prefer-nullish-coalescing': 'off',
+    'no-prototype-builtins': 'off'
+  },
+}

dist/astrochart.js

@@ -1,19 +1,19 @@
-import { AstroData } from '../radix';
-import { Settings } from '../settings';
-import Transit from '../transit';
+import { type AstroData } from '../radix';
+import { type Settings } from '../settings';
+import type Transit from '../transit';
 import Timer from './timer';
 /**
- * Transit chart animator
- *
- * Animates the object on a circle.
- *
- * @class
- * @public
- * @constructor
- * @param {Object} from, {"Sun":[12], "Moon":[60]}
- * @param {Object} to, {"Sun":[30], "Moon":[180]}
- * @param {Object} settings, {cx:100, cy:100, radius:200, prefix:"astro-chart-"}
- */
+   * Transit chart animator
+   *
+   * Animates the object on a circle.
+   *
+   * @class
+   * @public
+   * @constructor
+   * @param {Object} from, {"Sun":[12], "Moon":[60]}
+   * @param {Object} to, {"Sun":[30], "Moon":[180]}
+   * @param {Object} settings, {cx:100, cy:100, radius:200, prefix:"astro-chart-"}
+   */
 declare class Animator {
     transit: Transit;
     isReverse: boolean;
@@ -25,17 +25,19 @@ declare class Animator {
     context: this;
     cuspsElement: any;
     data: AstroData;
+    duration: number;
+    callback: () => void;
     constructor(transit: Transit, settings: Settings);
     /**
-* Animate objects
-
-* @param {Object} data, targetPositions
-* @param {Integer} duration - seconds
-* @param {boolean} isReverse
-* @param {Function} callbck - start et the end of animation
-*/
-    animate: (data: any, duration: number, isReverse: boolean, callback: () => void) => void;
-    update: (deltaTime: number) => void;
+     * Animate objects
+  
+     * @param {Object} data, targetPositions
+      * @param {Integer} duration - seconds
+      * @param {boolean} isReverse
+      * @param {Function} callbck - start et the end of animation
+     */
+    animate(data: any, duration: number, isReverse: boolean, callback: () => void): void;
+    update(deltaTime?: number): void;
     updateCusps(expectedNumberOfLoops: number): void;
     updatePlanets(expectedNumberOfLoops: number): void;
 }

dist/project/src/animation/animator.d.ts

@@ -3,7 +3,7 @@ declare class Timer {
     callback: (delta: number) => void;
     boundTick_: FrameRequestCallback;
     lastGameLoopFrame: number;
-    requestID_: number;
+    requestID_: number | undefined;
     constructor(callback: (delta: number) => void, debug: boolean);
     start(): void;
     stop(): void;

dist/project/src/animation/timer.d.ts

@@ -1,5 +1,5 @@
-import { Points } from './radix';
-import { AspectData, Settings } from './settings';
+import { type Points } from './radix';
+import { type AspectData, type Settings } from './settings';
 export interface FormedAspect {
     point: {
         name: string;
@@ -18,14 +18,14 @@ export interface FormedAspect {
     precision: string;
 }
 /**
- * Aspects calculator
- *
- * @class
- * @public
- * @constructor
- * @param {AspectPoints} points; {"Sun":[0], "Moon":[90], "Neptune":[120], "As":[30]}
- * @param {Object | null } settings
- */
+   * Aspects calculator
+   *
+   * @class
+   * @public
+   * @constructor
+   * @param {AspectPoints} points; {"Sun":[0], "Moon":[90], "Neptune":[120], "As":[30]}
+   * @param {Object | null } settings
+   */
 declare class AspectCalculator {
     settings: Partial<Settings>;
     toPoints: Points;
@@ -55,23 +55,7 @@ declare class AspectCalculator {
      * @param {Object} points - transiting points; {"Sun":[0, 1], "Uranus":[90, -1], "NAME":[ANGLE, SPEED]};
      * @return {Array<Object>} [{"aspect":{"name":"conjunction", "degree":120}"", "point":{"name":"Sun", "position":123}, "toPoint":{"name":"Moon", "position":345}, "precision":0.5}]]
      */
-    transit(points: Points): {
-        aspect: {
-            name: string;
-            degree: number;
-            orbit: number;
-            color: string;
-        };
-        point: {
-            name: string;
-            position: number;
-        };
-        toPoint: {
-            name: string;
-            position: number;
-        };
-        precision: string;
-    }[];
+    transit(points: Points): FormedAspect[];
     hasAspect(point: number, toPoint: number, aspect: AspectData): boolean;
     calcPrecision(point: number, toPoint: number, aspect: number): number;
     isTransitPointApproachingToAspect(aspect: number, toPoint: number, point: number): boolean;

dist/project/src/aspect.d.ts

@@ -1,5 +1,5 @@
-import { Settings } from './settings';
-import Radix, { AstroData } from './radix';
+import { type Settings } from './settings';
+import Radix, { type AstroData } from './radix';
 import SVG from './svg';
 /**
  * Displays astrology charts.
@@ -20,17 +20,17 @@ declare class Chart {
     settings: Settings;
     constructor(elementId: string, width: number, height: number, settings?: Partial<Settings>);
     /**
-     * Display radix horoscope
-     *
-     * @param {Object} data
-     * @example
-     *	{
-     *		"points":{"Moon":[0], "Sun":[30],  ... },
-     *		"cusps":[300, 340, 30, 60, 75, 90, 116, 172, 210, 236, 250, 274]
-     *	}
-     *
-     * @return {astrology.Radix} radix
-     */
+   * Display radix horoscope
+   *
+   * @param {Object} data
+   * @example
+   *  {
+   *    "points":{"Moon":[0], "Sun":[30],  ... },
+   *    "cusps":[300, 340, 30, 60, 75, 90, 116, 172, 210, 236, 250, 274]
+   *  }
+   *
+   * @return {Radix} radix
+   */
     radix(data: AstroData): Radix;
     /**
      * Scale chart
@@ -43,6 +43,6 @@ declare class Chart {
      * For debug only.
      *
      */
-    calibrate(): this;
+    calibrate(): Chart;
 }
 export default Chart;

dist/project/src/chart.d.ts

@@ -1,35 +1,33 @@
-import { FormedAspect } from './aspect';
+import { type FormedAspect } from './aspect';
 import Transit from './transit';
-import SVG from './svg';
-import { Settings } from './settings';
-export declare type Points = {
-    [key: string]: number[];
-};
-export declare type LocatedPoint = {
-    name?: string;
+import type SVG from './svg';
+import { type Settings } from './settings';
+export type Points = Record<string, number[]>;
+export interface LocatedPoint {
+    name: string;
     x: number;
     y: number;
     r: number;
     angle: number;
     pointer?: number;
     index?: number;
-};
-export declare type AstroData = {
+}
+export interface AstroData {
     planets: Points;
     cusps: number[];
-};
+}
 /**
- * Radix charts.
- *
- * @class
- * @public
- * @constructor
- * @param {this.settings.SVG} paper
- * @param {int} cx
- * @param {int} cy
- * @param {int} radius
- * @param {Object} data
- */
+   * Radix charts.
+   *
+   * @class
+   * @public
+   * @constructor
+    * @param {this.settings.SVG} paper
+   * @param {int} cx
+   * @param {int} cy
+   * @param {int} radius
+   * @param {Object} data
+   */
 declare class Radix {
     settings: Settings;
     data: AstroData;
@@ -46,8 +44,8 @@ declare class Radix {
     context: this;
     constructor(paper: SVG, cx: number, cy: number, radius: number, data: AstroData, settings: Settings);
     /**
- * Draw background
- */
+     * Draw background
+     */
     drawBg(): void;
     /**
      * Draw universe.
@@ -66,13 +64,13 @@ declare class Radix {
      * Draw aspects
      * @param{Array<Object> | null} customAspects - posible custom aspects to draw;
      */
-    aspects(customAspects?: FormedAspect[] | null): this;
+    aspects(customAspects?: FormedAspect[] | null): Radix;
     /**
      * Add points of interest for aspects calculation
      * @param {Obect} points, {"As":[0],"Ic":[90],"Ds":[180],"Mc":[270]}
      * @see (this.settings.AspectCalculator( toPoints) )
      */
-    addPointsOfInterest(points: Points): this;
+    addPointsOfInterest(points: Points): Radix;
     drawRuler(): void;
     /**
      * Draw circles
@@ -83,12 +81,12 @@ declare class Radix {
      *
      * @param {Object} data
      * @example
-     *	{
-     *		"planets":{"Moon":[0], "Sun":[30],  ... },
-     *		"cusps":[300, 340, 30, 60, 75, 90, 116, 172, 210, 236, 250, 274],	*
-     *	}
+     *  {
+     *    "planets":{"Moon":[0], "Sun":[30],  ... },
+     *    "cusps":[300, 340, 30, 60, 75, 90, 116, 172, 210, 236, 250, 274],  *
+     *  }
      *
-     * @return {this.settings.Transit} transit
+     * @return {Transit} transit
      */
     transit(data: AstroData): Transit;
 }

dist/project/src/radix.d.ts

@@ -1,18 +1,16 @@
-import SVG from "./svg";
+import type SVG from './svg';
 export interface AspectData {
     degree: number;
     orbit: number;
     color: string;
 }
-export interface Aspect {
-    [key: string]: AspectData;
-}
+export type Aspect = Record<string, AspectData>;
 export interface Dignity {
     name: string;
     position: number;
     orbit: number;
 }
-export declare type Settings = {
+export interface Settings {
     SYMBOL_SCALE: number;
     COLOR_BACKGROUND: string;
     POINTS_COLOR: string;
@@ -98,7 +96,7 @@ export declare type Settings = {
     COLOR_AQUARIUS: string;
     COLOR_PISCES: string;
     COLORS_SIGNS: string[];
-    CUSTOM_SYMBOL_FN: (name: string, x: number, y: number, context: SVG) => Element | null;
+    CUSTOM_SYMBOL_FN: null | ((name: string, x: number, y: number, context: SVG) => Element);
     SHIFT_IN_DEGREES: number;
     STROKE_ONLY: boolean;
     ADD_CLICK_AREA: boolean;
@@ -112,6 +110,6 @@ export declare type Settings = {
     DIGNITIES_EXACT_EXALTATION_DEFAULT: Dignity[];
     ANIMATION_CUSPS_ROTATION_SPEED: number;
     DEBUG: boolean;
-};
+}
 declare const default_settings: Settings;
 export default default_settings;