Skip to content

Commit 65a7da7

Browse files
committed
updates to amplicon and metagenomics validation
1 parent d7ded26 commit 65a7da7

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

GL-validate-amplicon

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,9 @@ def check_multiqc_outputs(sample_names):
208208
""" makes sure all samples' read files are in the multiqc outputs """
209209

210210
# checking raw
211-
zip_file = zipfile.ZipFile(fastqc_dir + str(args.output_prefix) + "raw_multiqc_data.zip")
211+
raw_multiqc_data_path = fastqc_dir + str(args.output_prefix) + "raw_multiqc_data.zip"
212+
check_for_file_and_contents(raw_multiqc_data_path)
213+
zip_file = zipfile.ZipFile(raw_multiqc_data_path)
212214
df = pd.read_csv(zip_file.open("multiqc_general_stats.txt"), sep = "\t", usecols = ["Sample"])
213215
file_prefixes_in_multiqc = df["Sample"].tolist()
214216

@@ -232,7 +234,9 @@ def check_multiqc_outputs(sample_names):
232234
report_failure("The raw multiqc output is missing the expected '" + sample + suffix + "' entry.")
233235

234236
# checking filtered
235-
zip_file = zipfile.ZipFile(fastqc_dir + str(args.output_prefix) + "filtered_multiqc_data.zip")
237+
filt_multiqc_data_path = fastqc_dir + str(args.output_prefix) + "filtered_multiqc_data.zip"
238+
check_for_file_and_contents(filt_multiqc_data_path)
239+
zip_file = zipfile.ZipFile(filt_multiqc_data_path)
236240
df = pd.read_csv(zip_file.open("multiqc_general_stats.txt"), sep = "\t", usecols = ["Sample"])
237241
file_prefixes_in_multiqc = df["Sample"].tolist()
238242

GL-validate-metagenomics

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ processing_tar_file = "processing_info.tar"
8181
expected_tar_contents = ["/Snakefile", "/config.yaml", "/envs", "/logs", "/scripts", "/unique-sample-IDs.txt"]
8282

8383
expected_log_file_suffixes = ["-CAT.log", "-assembly.log", "-bam-summarize-and-metabat.log", "-bowtie2-build.log",
84-
"-kofamscan.log", "-pileup.log", "-prodigal.log", "-humann3-run.log"]
84+
"-bbduk.log", "-kofamscan.log", "-pileup.log", "-prodigal.log", "-humann3-run.log"]
8585

8686

8787
validation_log = str(args.GLDS_ID) + "-metagenomics-validation.log"
@@ -541,11 +541,6 @@ def check_processing_tar(samples):
541541
if target_log not in entries:
542542
report_failure("The '" + str(processing_tar_file) + "' does not have the '" + str(target_log) + "' log file as expected.")
543543

544-
target_log = str(logs_dir) + "bbduk-" + str(sample) + ".log"
545-
546-
if target_log not in entries:
547-
report_failure("The '" + str(processing_tar_file) + "' does not have the '" + str(target_log) + "' log file as expected.")
548-
549544

550545
if __name__ == "__main__":
551546
main()

GL-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env bash
22

3-
version='1.0.13'
3+
version='1.0.14'
44

55
GREEN='\033[0;32m'
66
NC='\033[0m'

0 commit comments

Comments
 (0)