Merge pull request #424 from rbngzlv/remove-relation-key-on-dirty

Fix regression trying to save empty translations

Author: Gummibeer

src/Translatable/Translatable.php

@@ -347,6 +347,7 @@ protected function isTranslationDirty(Model $translation): bool
     {
         $dirtyAttributes = $translation->getDirty();
         unset($dirtyAttributes[$this->getLocaleKey()]);
+        unset($dirtyAttributes[$this->getTranslationRelationKey()]);
 
         return count($dirtyAttributes) > 0;
     }

tests/TranslatableTest.php

@@ -778,6 +778,25 @@ public function empty_translated_attribute(): void
         self::assertNull($vegetable->name);
     }
 
+    #[Test]
+    public function empty_translations_are_not_saved(): void
+    {
+        $vegetable = new Vegetable();
+        $vegetable->fill([
+            'en' => [],
+            'de' => ['name' => 'Erbsen'],
+        ]);
+
+        $vegetable->save();
+
+        self::assertDatabaseHas('vegetable_translations', [
+            'locale' => 'de',
+            'name' => 'Erbsen',
+        ]);
+
+        self::assertDatabaseMissing('vegetable_translations', ['locale' => 'en']);
+    }
+
     #[Test]
     public function numeric_translated_attribute(): void
     {