Merge pull request #11 from Astrotomic/fix-scrutinizer

Fix scrutinizer

Author: Gummibeer

.codeclimate.yml

@@ -38,5 +38,7 @@ plugins:
         enabled: false
       Design/TooManyPublicMethods:
         enabled: false
+      CyclomaticComplexity:
+        enabled: false
   phan:
     enabled: false

.scrutinizer.yml

@@ -9,9 +9,11 @@ build:
     before:
       - mysql -e 'create database translatable_test;'
       - echo "CREATE USER 'homestead'@'localhost' IDENTIFIED BY 'secret'; \n GRANT ALL PRIVILEGES ON * . * TO 'homestead'@'localhost'; \nFLUSH PRIVILEGES; \n" | mysql -u root
-  tests:
-    override:
-      - command: echo 1
+  nodes:
+    analysis:
+      tests:
+        override:
+          - php-scrutinizer-run
 
 tools:
   external_code_coverage:

src/Translatable/Translatable.php

@@ -63,7 +63,11 @@ public function getTranslation(?string $locale = null, bool $withFallback = null
             if ($translation = $this->getTranslationByLocaleKey($fallbackLocale)) {
                 return $translation;
             }
-            if ($fallbackLocale !== $configFallbackLocale && $translation = $this->getTranslationByLocaleKey($configFallbackLocale)) {
+            if (
+                is_string($configFallbackLocale)
+                && $fallbackLocale !== $configFallbackLocale
+                && $translation = $this->getTranslationByLocaleKey($configFallbackLocale)
+            ) {
                 return $translation;
             }
         }
@@ -306,7 +310,7 @@ protected function saveTranslations(): bool
 
     public function replicateWithTranslations(array $except = null): Model
     {
-        $newInstance = parent::replicate($except);
+        $newInstance = $this->replicate($except);
 
         unset($newInstance->translations);
         foreach ($this->translations as $translation) {
@@ -328,6 +332,8 @@ protected function isTranslationDirty(Model $translation): bool
     public function getNewTranslation(string $locale): Model
     {
         $modelName = $this->getTranslationModelName();
+
+        /** @var Model $translation */
         $translation = new $modelName();
         $translation->setAttribute($this->getLocaleKey(), $locale);
         $this->translations->add($translation);