interpret args

Author: timkpaine

algocoin/custom_strategies.py

@@ -24,7 +24,7 @@ def __init__(self, size: int) -> None:
 
     def onBuy(self, res: TradeResponse) -> None:
         if not res.success:
-            slog.critical('order failure: %s' % res)
+            slog.critical('order failure: %s', res)
             return
 
         if self._intitialvalue is None:
@@ -34,7 +34,7 @@ def onBuy(self, res: TradeResponse) -> None:
 
         self.bought = res.volume*res.price
         self.bought_qty = res.volume
-        slog.critical('d->g:bought %.2f @ %.2f for %.2f' % (res.volume, res.price, self.bought))
+        slog.critical('d->g:bought %.2f @ %.2f for %.2f', res.volume, res.price, self.bought)
 
     def onSell(self, res: TradeResponse) -> None:
         if not res.success:
@@ -44,7 +44,7 @@ def onSell(self, res: TradeResponse) -> None:
         sold = res.volume*res.price
         profit = sold - self.bought
         self.profits += profit
-        slog.critical('g->d:sold %.2f @ %.2f for %.2f - %.2f - %.2f' % (res.volume, res.price, sold, profit, self.profits))
+        slog.critical('g->d:sold %.2f @ %.2f for %.2f - %.2f - %.2f', res.volume, res.price, sold, profit, self.profits)
         self.bought = 0.0
         self.bought_qty = 0.0
 

algocoin/lib/exchanges/gemini.py

@@ -58,8 +58,7 @@ def run(self, engine) -> None:
 
                 self._running = True
 
-                log.info('')
-                log.info('Starting algo trading')
+                log.critical('\n\nStarting algo trading\n\n')
             try:
                 while True:
                     self.receive()
@@ -107,7 +106,7 @@ def buy(self, req: TradeRequest) -> TradeResponse:
         }'''
         # FIXME check these
         if order.get('result') == 'error':
-            log.critical("Order Error - %s" % order)
+            log.critical("Order Error - %s", order)
             raise Exception('Order Error!')
 
         executed_amount = float(order['executed_amount'])
@@ -152,7 +151,7 @@ def sell(self, req: TradeRequest) -> TradeResponse:
                                        order_execution=None)
 
         if order.get('result') == 'error':
-            log.critical("Order Error - %s" % order)
+            log.critical("Order Error - %s", order)
             raise Exception('Order Error!')
 
         executed_amount = float(order['executed_amount'])

algocoin/lib/parser.py

@@ -74,7 +74,12 @@ def _parse_strategy(strategy, config) -> None:
             continue
         splits = [x for x in strat.split(',') if x]
         cls = locate(splits[0])
-        args = tuple(splits[1:]) if len(splits) > 1 else ()
+
+        args = []
+        for x in splits[1:]:
+            args.append(float(x) if x.isdigit() else x)
+        args = tuple(args)
+
         strat_configs.append(StrategyConfig(clazz=cls, args=args))
     config.strategy_options = strat_configs
 
@@ -113,7 +118,7 @@ def _parse_args_to_dict(argv: list) -> dict:
 
 
 def _parse_live_options(argv, config: TradingEngineConfig) -> None:
-    log.critical("WARNING: Live trading. money will be lost ;^)")
+    log.critical("\n\nWARNING: Live trading. money will be lost ;^)\n\n")
     if argv.get('exchange'):
         config.exchange_options.exchange_type = str_to_exchange(argv['exchange'])
     elif argv.get('exchanges'):
@@ -124,7 +129,8 @@ def _parse_live_options(argv, config: TradingEngineConfig) -> None:
 
 
 def _parse_sandbox_options(argv, config) -> None:
-    log.critical("Sandbox trading")
+    log.critical("\n\nSandbox trading\n\n")
+
     if argv.get('exchange'):
         config.exchange_options.exchange_type = str_to_exchange(argv['exchange'])
     elif argv.get('exchanges'):
@@ -135,8 +141,7 @@ def _parse_sandbox_options(argv, config) -> None:
 
 
 def _parse_backtest_options(argv, config) -> None:
-    log.critical("Backtesting")
-
+    log.critical("\n\nBacktesting\n\n")
     config.backtest_options = BacktestConfig()
 
     if argv.get('exchange'):
@@ -181,7 +186,7 @@ def parse_command_line_config(argv: list) -> TradingEngineConfig:
         if argv.get('print'):
             config.print = True
 
-    log.critical("Config : %s", str(config))
+    log.debug("Config : %s", str(config))
 
     return config
 

algocoin/lib/utils.py

@@ -270,7 +270,7 @@ def set_verbose(level):
     # dlog.propagate = False  # too much
     # tlog.propagate = True
     # mlog.propagate = True
-    if level > 1:
+    if level >= 2:
         log.setLevel(logging.DEBUG)
         slog.setLevel(logging.DEBUG)
         dlog.setLevel(logging.DEBUG)

algocoin/main.py

@@ -20,7 +20,7 @@ def main(argv: list) -> None:
     te = TradingEngine(config)
     application = ServerApplication(te)
 
-    log.critical('Server listening on port: %s', port)
+    log.critical('\n\nServer listening on port: %s\n\n', port)
     application.listen(port)
     t = threading.Thread(target=tornado.ioloop.IOLoop.current().start)
     t.daemon = True  # So it terminates on exit

config/sandbox_gemini.cfg

@@ -1,5 +1,5 @@
 [general]
-verbose=2
+verbose=0
 print=0
 TradingType=sandbox