Skip to content

Commit 807a7bf

Browse files
zcuderchen zhang
andauthored
fix local ollama embedding now working (#188)
Co-authored-by: chen zhang <[email protected]>
1 parent d2230a7 commit 807a7bf

File tree

5 files changed

+4
-22
lines changed

5 files changed

+4
-22
lines changed

api/config/embedder.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,6 @@
88
"encoding_format": "float"
99
}
1010
},
11-
"embedder_ollama": {
12-
"client_class": "OllamaClient",
13-
"model_kwargs": {
14-
"model": "nomic-embed-text"
15-
}
16-
},
1711
"retriever": {
1812
"top_k": 20
1913
},

api/config/embedder.json.bak renamed to api/config/embedder.ollama.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,5 @@
11
{
22
"embedder": {
3-
"client_class": "OpenAIClient",
4-
"batch_size": 500,
5-
"model_kwargs": {
6-
"model": "text-embedding-3-small",
7-
"dimensions": 256,
8-
"encoding_format": "float"
9-
}
10-
},
11-
"embedder_ollama": {
123
"client_class": "OllamaClient",
134
"model_kwargs": {
145
"model": "nomic-embed-text"

api/data_pipeline.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ def prepare_data_pipeline(is_ollama_embedder: bool = None):
370370
splitter = TextSplitter(**configs["text_splitter"])
371371
embedder_config = get_embedder_config()
372372

373-
embedder = get_embedder(is_local_ollama=is_ollama_embedder)
373+
embedder = get_embedder()
374374

375375
if is_ollama_embedder:
376376
# Use Ollama document processor for single-document processing

api/rag.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ def __init__(self, provider="google", model=None, use_s3: bool = False): # noqa
229229

230230
# Initialize components
231231
self.memory = Memory()
232-
self.embedder = get_embedder(is_local_ollama=self.is_ollama_embedder)
232+
self.embedder = get_embedder()
233233

234234
# Patch: ensure query embedding is always single string for Ollama
235235
def single_string_embedder(query):

api/tools/embedder.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,8 @@
33
from api.config import configs
44

55

6-
def get_embedder(is_local_ollama: bool = False) -> adal.Embedder:
7-
if is_local_ollama:
8-
embedder_config = configs["embedder_ollama"]
9-
else:
10-
embedder_config = configs["embedder"]
6+
def get_embedder() -> adal.Embedder:
7+
embedder_config = configs["embedder"]
118

129
# --- Initialize Embedder ---
1310
model_client_class = embedder_config["model_client"]

0 commit comments

Comments
 (0)