use jspecify annotations

Author: sullis

client/pom.xml

@@ -48,6 +48,11 @@
 
     <dependencies>
         <!-- https://mvnrepository.com/artifact/commons-fileupload/commons-fileupload -->
+        <dependency>
+            <groupId>org.jspecify</groupId>
+            <artifactId>jspecify</artifactId>
+            <version>1.0.0</version>
+        </dependency>
         <dependency>
             <groupId>commons-fileupload</groupId>
             <artifactId>commons-fileupload</artifactId>

client/src/main/java/org/asynchttpclient/AsyncCompletionHandler.java

@@ -18,7 +18,7 @@
 
 import io.netty.handler.codec.http.HttpHeaders;
 import org.asynchttpclient.handler.ProgressAsyncHandler;
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.Nullable;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

client/src/main/java/org/asynchttpclient/AsyncCompletionHandlerBase.java

@@ -16,8 +16,7 @@
  */
 package org.asynchttpclient;
 
-
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.Nullable;
 
 /**
  * Simple {@link AsyncHandler} of type {@link Response}

client/src/main/java/org/asynchttpclient/AsyncHandler.java

@@ -18,7 +18,7 @@
 import io.netty.channel.Channel;
 import io.netty.handler.codec.http.HttpHeaders;
 import org.asynchttpclient.netty.request.NettyRequest;
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.Nullable;
 
 import javax.net.ssl.SSLSession;
 import java.net.InetSocketAddress;

client/src/main/java/org/asynchttpclient/AsyncHttpClientConfig.java

@@ -34,7 +34,7 @@
 import org.asynchttpclient.netty.channel.ConnectionSemaphoreFactory;
 import org.asynchttpclient.proxy.ProxyServer;
 import org.asynchttpclient.proxy.ProxyServerSelector;
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.Nullable;
 
 import java.io.IOException;
 import java.time.Duration;
@@ -263,14 +263,12 @@ public interface AsyncHttpClientConfig {
     /**
      * @return the array of enabled protocols
      */
-    @Nullable
-    String[] getEnabledProtocols();
+    String @Nullable[] getEnabledProtocols();
 
     /**
      * @return the array of enabled cipher suites
      */
-    @Nullable
-    String[] getEnabledCipherSuites();
+    String @Nullable[] getEnabledCipherSuites();
 
     /**
      * @return if insecure cipher suites must be filtered out (only used when not explicitly passing enabled cipher suites)

client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClient.java

@@ -30,7 +30,7 @@
 import org.asynchttpclient.handler.resumable.ResumableAsyncHandler;
 import org.asynchttpclient.netty.channel.ChannelManager;
 import org.asynchttpclient.netty.request.NettyRequestSender;
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.Nullable;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClientConfig.java

@@ -34,7 +34,7 @@
 import org.asynchttpclient.proxy.ProxyServer;
 import org.asynchttpclient.proxy.ProxyServerSelector;
 import org.asynchttpclient.util.ProxyUtils;
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.Nullable;
 
 import java.time.Duration;
 import java.util.Collections;
@@ -158,8 +158,8 @@ public class DefaultAsyncHttpClientConfig implements AsyncHttpClientConfig {
     private final boolean useInsecureTrustManager;
     private final boolean disableHttpsEndpointIdentificationAlgorithm;
     private final int handshakeTimeout;
-    private final @Nullable String[] enabledProtocols;
-    private final @Nullable String[] enabledCipherSuites;
+    private final String @Nullable[] enabledProtocols;
+    private final String @Nullable[] enabledCipherSuites;
     private final boolean filterInsecureCipherSuites;
     private final int sslSessionCacheSize;
     private final int sslSessionTimeout;
@@ -244,8 +244,8 @@ private DefaultAsyncHttpClientConfig(// http
                                          boolean useInsecureTrustManager,
                                          boolean disableHttpsEndpointIdentificationAlgorithm,
                                          int handshakeTimeout,
-                                         @Nullable String[] enabledProtocols,
-                                         @Nullable String[] enabledCipherSuites,
+            String @Nullable[] enabledProtocols,
+            String @Nullable[] enabledCipherSuites,
                                          boolean filterInsecureCipherSuites,
                                          int sslSessionCacheSize,
                                          int sslSessionTimeout,
@@ -586,12 +586,12 @@ public int getHandshakeTimeout() {
     }
 
     @Override
-    public @Nullable String[] getEnabledProtocols() {
+    public String @Nullable[] getEnabledProtocols() {
         return enabledProtocols;
     }
 
     @Override
-    public @Nullable String[] getEnabledCipherSuites() {
+    public String @Nullable[] getEnabledCipherSuites() {
         return enabledCipherSuites;
     }
 
@@ -831,8 +831,8 @@ public static class Builder {
         private boolean useInsecureTrustManager = defaultUseInsecureTrustManager();
         private boolean disableHttpsEndpointIdentificationAlgorithm = defaultDisableHttpsEndpointIdentificationAlgorithm();
         private int handshakeTimeout = defaultHandshakeTimeout();
-        private @Nullable String[] enabledProtocols = defaultEnabledProtocols();
-        private @Nullable String[] enabledCipherSuites = defaultEnabledCipherSuites();
+        private String @Nullable[] enabledProtocols = defaultEnabledProtocols();
+        private String @Nullable[] enabledCipherSuites = defaultEnabledCipherSuites();
         private boolean filterInsecureCipherSuites = defaultFilterInsecureCipherSuites();
         private int sslSessionCacheSize = defaultSslSessionCacheSize();
         private int sslSessionTimeout = defaultSslSessionTimeout();

client/src/main/java/org/asynchttpclient/DefaultRequest.java

@@ -24,7 +24,7 @@
 import org.asynchttpclient.request.body.generator.BodyGenerator;
 import org.asynchttpclient.request.body.multipart.Part;
 import org.asynchttpclient.uri.Uri;
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.Nullable;
 
 import java.io.File;
 import java.io.InputStream;

client/src/main/java/org/asynchttpclient/Param.java

@@ -15,7 +15,7 @@
  */
 package org.asynchttpclient;
 
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.Nullable;
 
 import java.util.ArrayList;
 import java.util.List;

client/src/main/java/org/asynchttpclient/Realm.java

@@ -20,7 +20,7 @@
 import org.asynchttpclient.util.AuthenticatorUtils;
 import org.asynchttpclient.util.StringBuilderPool;
 import org.asynchttpclient.util.StringUtils;
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.Nullable;
 
 import java.nio.charset.Charset;
 import java.security.MessageDigest;