♻️ Add input validation to helper function (#1807)

KATO-Hiro · KATO-Hiro · commit 36cc7b64fb5a · 2025-03-17T03:59:55.000Z
diff --git a/src/lib/utils/contest_table_provider.ts b/src/lib/utils/contest_table_provider.ts
@@ -165,7 +165,14 @@ class ABC212ToABC318Provider extends ContestTableProviderBase {
 }
 
 function parseContestRound(contestId: string, prefix: string): number {
-  return parseInt(contestId.replace(prefix, ''), 10);
+  const withoutPrefix = contestId.replace(prefix, '');
+
+  // Verify the prefix was present and the remaining string is numeric
+  if (withoutPrefix === contestId || !/^\d+$/.test(withoutPrefix)) {
+    throw new Error(`Invalid contest id has given: ${contestId}`);
+  }
+
+  return parseInt(withoutPrefix, 10);
 }
 
 // TODO: Add providers for other contest types if needs.

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,14 @@ class ABC212ToABC318Provider extends ContestTableProviderBase {`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`function parseContestRound(contestId: string, prefix: string): number {`
`168`		`- return parseInt(contestId.replace(prefix, ''), 10);`
	`168`	`+ const withoutPrefix = contestId.replace(prefix, '');`
	`169`	`+`
	`170`	`+ // Verify the prefix was present and the remaining string is numeric`
	`171`	`+ if (withoutPrefix === contestId \|\| !/^\d+$/.test(withoutPrefix)) {`
	`172`	+ throw new Error(`Invalid contest id has given: ${contestId}`);
	`173`	`+ }`
	`174`	`+`
	`175`	`+ return parseInt(withoutPrefix, 10);`
`169`	`176`	`}`
`170`	`177`
`171`	`178`	`// TODO: Add providers for other contest types if needs.`