🚨 Add tests for workbook schema (#2020)

Author: KATO-Hiro

src/lib/utils/url.ts

@@ -22,15 +22,23 @@ export function isValidUrl(rawUrl: string): boolean {
  *
  * A valid URL slug:
  * - Contains only lowercase letters (a-z), numbers (0-9), and hyphens (-)
+ * - Must start with a lowercase letter or number
+ * - Must end with a lowercase letter or number
+ * - Cannot contain uppercase letters or special characters
+ * - Cannot be entirely numeric
  * - Cannot start or end with a hyphen
  * - Cannot contain consecutive hyphens
  */
 export function isValidUrlSlug(slug: string): boolean {
-  const pattern = new RegExp(
-    '^[a-z0-9]+(-[a-z0-9]+)*$', // a-z, 0-9, and hyphen (-) allowed
-  );
+  if (!/^[a-z0-9]+(-[a-z0-9]+)*$/.test(slug)) {
+    return false;
+  }
+
+  if (/^\d+$/.test(slug)) {
+    return false;
+  }
 
-  return !!pattern.test(slug);
+  return true;
 }
 
 export function sanitizeUrl(rawUrl: string) {

src/test/lib/utils/url.test.ts

@@ -102,6 +102,14 @@ describe('URL', () => {
         { rawUrl: '-' },
         { rawUrl: '--' },
         { rawUrl: 'ー' },
+        { rawUrl: '-1' },
+        { rawUrl: '0' },
+        { rawUrl: '1' },
+        { rawUrl: '2' },
+        { rawUrl: '9' },
+        { rawUrl: '10' },
+        { rawUrl: '99' },
+        { rawUrl: '100' },
         { rawUrl: '１' },
         { rawUrl: '２' },
         { rawUrl: '９' },

src/test/lib/zod/workbook_schema.test.ts

@@ -85,6 +85,7 @@ describe('workbook schema', () => {
         authorId: '1',
         isPublished: true,
         urlSlug: 'a',
+        workBookType: WorkBookType.SOLUTION,
       });
       validateWorkBookSchema(workBookSchema, workbook);
     });
@@ -114,6 +115,7 @@ describe('workbook schema', () => {
         authorId: '1',
         isPublished: true,
         urlSlug: 'a'.repeat(30),
+        workBookType: WorkBookType.SOLUTION,
       });
       validateWorkBookSchema(workBookSchema, workbook);
     });
@@ -123,6 +125,7 @@ describe('workbook schema', () => {
         authorId: '1',
         isPublished: true,
         urlSlug: '',
+        workBookType: WorkBookType.SOLUTION,
       });
       validateWorkBookSchema(workBookSchema, workbook);
     });
@@ -132,6 +135,7 @@ describe('workbook schema', () => {
         authorId: '1',
         isPublished: true,
         urlSlug: null,
+        workBookType: WorkBookType.SOLUTION,
       });
       validateWorkBookSchema(workBookSchema, workbook);
     });
@@ -141,6 +145,7 @@ describe('workbook schema', () => {
         authorId: '1',
         isPublished: true,
         urlSlug: undefined,
+        workBookType: WorkBookType.SOLUTION,
       });
       validateWorkBookSchema(workBookSchema, workbook);
     });
@@ -299,6 +304,27 @@ describe('workbook schema', () => {
         authorId: '1',
         isPublished: true,
         urlSlug: 'a'.repeat(31),
+        workBookType: WorkBookType.SOLUTION,
+      });
+      validateWorkBookSchema(workBookSchema, workbook);
+    });
+
+    test('when an invalid url slug is given a numeric', () => {
+      const workbook: WorkBook = createWorkBookBase({
+        authorId: '1',
+        isPublished: true,
+        urlSlug: '1',
+        workBookType: WorkBookType.SOLUTION,
+      });
+      validateWorkBookSchema(workBookSchema, workbook);
+    });
+
+    test('when an invalid url slug is given numerics', () => {
+      const workbook: WorkBook = createWorkBookBase({
+        authorId: '1',
+        isPublished: true,
+        urlSlug: '10',
+        workBookType: WorkBookType.SOLUTION,
       });
       validateWorkBookSchema(workBookSchema, workbook);
     });
@@ -308,24 +334,27 @@ describe('workbook schema', () => {
         authorId: '1',
         isPublished: true,
         urlSlug: 'directed acyclic graph',
+        workBookType: WorkBookType.SOLUTION,
       });
       validateWorkBookSchema(workBookSchema, workbook);
     });
 
-    test('when an invalid url slug is given hyphen', () => {
+    test('when an invalid url slug is given with hyphen', () => {
       const workbook: WorkBook = createWorkBookBase({
         authorId: '1',
         isPublished: true,
         urlSlug: '-',
+        workBookType: WorkBookType.SOLUTION,
       });
       validateWorkBookSchema(workBookSchema, workbook);
     });
 
-    test('when an invalid url slug is given hyphens', () => {
+    test('when an invalid url slug is given with hyphens', () => {
       const workbook: WorkBook = createWorkBookBase({
         authorId: '1',
         isPublished: true,
         urlSlug: '--',
+        workBookType: WorkBookType.SOLUTION,
       });
       validateWorkBookSchema(workBookSchema, workbook);
     });