refactor: Use DTO (#2627)

Author: KATO-Hiro

docs/dev-notes/2025-09-23/contest-task-pair-mapping/plan.md

@@ -87,23 +87,32 @@ export async function getContestTaskPairs(): Promise<ContestTaskPairs> {
  * ContestTaskPair の新規レコードを作成
  */
 export async function createContestTaskPair(
-  contestId: string,
-  taskTableIndex: string,
-  taskId: string,
+  params: ContestTaskPairCreate,
 ): Promise<ContestTaskPair> {
+  const { contestId, taskTableIndex, taskId } = params;
+
   try {
-    return await db.contestTaskPair.create({
+    const contestTaskPair = await db.contestTaskPair.create({
       data: {
         contestId,
         taskTableIndex,
         taskId,
       },
     });
+
+    console.log('Created ContestTaskPair:', contestTaskPair);
+
+    return contestTaskPair;
   } catch (error) {
     if (error instanceof Prisma.PrismaClientKnownRequestError && error.code === 'P2002') {
-      const errorMessage = `ContestTaskPair already exists: contestId=${contestId}, taskId=${taskId}`;
-      console.error(errorMessage);
-      throw new Error(errorMessage);
+      console.log(`ContestTaskPair already exists: contestId=${contestId}, taskId=${taskId}`);
+      const existingPair = await getContestTaskPair(contestId, taskId);
+
+      if (!existingPair) {
+        throw new Error('Unexpected: record exists but cannot be fetched');
+      }
+
+      return existingPair;
     }
 
     console.error('Failed to create ContestTaskPair:', error);
@@ -115,12 +124,12 @@ export async function createContestTaskPair(
  * ContestTaskPair のレコードを更新
  */
 export async function updateContestTaskPair(
-  contestId: string,
-  taskTableIndex: string,
-  taskId: string,
+  params: ContestTaskPairUpdate,
 ): Promise<ContestTaskPair> {
+  const { contestId, taskTableIndex, taskId } = params;
+
   try {
-    return await db.contestTaskPair.update({
+    const updatedContestTaskPair = await db.contestTaskPair.update({
       where: {
         contestId_taskId: {
           contestId,
@@ -131,6 +140,10 @@ export async function updateContestTaskPair(
         taskTableIndex,
       },
     });
+
+    console.log('Updated ContestTaskPair:', updatedContestTaskPair);
+
+    return updatedContestTaskPair;
   } catch (error) {
     if (error instanceof Prisma.PrismaClientKnownRequestError && error.code === 'P2025') {
       const errorMessage = `Not found ContestTaskPair: contestId=${contestId}, taskId=${taskId}`;

src/lib/services/contest_task_pairs.ts

@@ -2,7 +2,12 @@ import { Prisma } from '@prisma/client';
 
 import { default as db } from '$lib/server/database';
 
-import type { ContestTaskPair, ContestTaskPairs } from '$lib/types/contest_task_pair';
+import type {
+  ContestTaskPair,
+  ContestTaskPairs,
+  ContestTaskPairCreate,
+  ContestTaskPairUpdate,
+} from '$lib/types/contest_task_pair';
 
 /**
  * Retrieves all ContestTaskPair records from the database.
@@ -38,19 +43,17 @@ export async function getContestTaskPair(
 /**
  * Creates a new ContestTaskPair record in the database.
  *
- * @param contestId - The ID of the contest.
- * @param taskTableIndex - The table index of the task.
- * @param taskId - The ID of the task.
+ * @param params - The parameters for creating a ContestTaskPair.
  *
  * @returns The created ContestTaskPair object or the existing one if it already exists.
  *
  * @throws Will throw an error if the creation fails.
  */
 export async function createContestTaskPair(
-  contestId: string,
-  taskTableIndex: string,
-  taskId: string,
+  params: ContestTaskPairCreate,
 ): Promise<ContestTaskPair> {
+  const { contestId, taskTableIndex, taskId } = params;
+
   try {
     const contestTaskPair = await db.contestTaskPair.create({
       data: {
@@ -83,19 +86,17 @@ export async function createContestTaskPair(
 /**
  * Updates an existing ContestTaskPair record in the database.
  *
- * @param contestId: The ID of the contest.
- * @param taskTableIndex: The table index of the task.
- * @param taskId: The ID of the task.
+ * @param params - The parameters for updating a ContestTaskPair.
  *
  * @returns The updated ContestTaskPair object.
  *
  * @throws Will throw an error if the update fails or if the record does not exist.
  */
 export async function updateContestTaskPair(
-  contestId: string,
-  taskTableIndex: string,
-  taskId: string,
+  params: ContestTaskPairUpdate,
 ): Promise<ContestTaskPair> {
+  const { contestId, taskTableIndex, taskId } = params;
+
   try {
     const updatedContestTaskPair = await db.contestTaskPair.update({
       where: {

src/lib/types/contest_task_pair.ts

@@ -15,7 +15,7 @@ export type ContestTaskPairCreate = {
   taskId: string;
 };
 
-export type ContestTaskPairUpdate = Partial<ContestTaskPairCreate>;
+export type ContestTaskPairUpdate = ContestTaskPairCreate;
 
 // For mapping and identification
 export type ContestTaskPairKey = `${string}:${string}`; // "contest_id:task_id"