Skip to content

Commit d396483

Browse files
committed
🚨 Fix inconsistent test block: “user is not admin” includes ADMIN cases (#2446)
1 parent d24abba commit d396483

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

src/test/lib/utils/authorship.test.ts

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,14 +220,26 @@ describe('Logged-in user id', () => {
220220
});
221221

222222
describe('when the user is not the author', () => {
223+
describe('and the user is admin', () => {
224+
const testCases = [
225+
{ userId: adminId, authorId: userId1, role: Roles.ADMIN, isPublished: false },
226+
{ userId: adminId, authorId: userId2, role: Roles.ADMIN, isPublished: false },
227+
];
228+
runTests(
229+
'canEdit',
230+
testCases,
231+
({ userId, authorId, role, isPublished }: AuthorshipForEdit) => {
232+
expect(canEdit(userId, authorId, role, isPublished)).toBe(false);
233+
},
234+
);
235+
});
236+
223237
describe('and the user is not admin', () => {
224238
const testCases = [
225239
{ userId: userId1, authorId: adminId, role: Roles.USER, isPublished: true },
226240
{ userId: userId1, authorId: adminId, role: Roles.USER, isPublished: false },
227241
{ userId: userId2, authorId: adminId, role: Roles.USER, isPublished: true },
228242
{ userId: userId2, authorId: adminId, role: Roles.USER, isPublished: false },
229-
{ userId: adminId, authorId: userId1, role: Roles.ADMIN, isPublished: false },
230-
{ userId: adminId, authorId: userId2, role: Roles.ADMIN, isPublished: false },
231243
{ userId: userId1, authorId: userId2, role: Roles.USER, isPublished: true },
232244
{ userId: userId1, authorId: userId2, role: Roles.USER, isPublished: false },
233245
{ userId: userId2, authorId: userId1, role: Roles.USER, isPublished: true },

0 commit comments

Comments
 (0)