Fixed issues from code review by CodeRabbit:

* min/max handling values outside of int64 range incorrectly;
* toJSON failing incorrectly if json_encode fails;
* indexOf having incorrect return type in doc comment;
* typo in error message;
* loose type check in createLambdaFromString (create_function was removed during merge of 2.0 branch).
Updated CodeRabbit config to talk like Rafiki.

Author: Athari

Tests/Unit/EnumerableTest.php

@@ -1180,6 +1180,12 @@ function testMax()
         $this->assertSame(
             5,
             E::from([ 3, 5, 4 ])->max());
+        $this->assertSame(
+            -1e100,
+            E::from([ -1e100 ])->max());
+        $this->assertSame(
+            -PHP_INT_MAX,
+            E::from([ -INF, -PHP_INT_MAX, -PHP_FLOAT_MAX ])->max());
 
         // max (selector)
         $this->assertSame(
@@ -1235,6 +1241,12 @@ function testMin()
         $this->assertSame(
             3,
             E::from([ 3, 5, 4 ])->min());
+        $this->assertSame(
+            1e100,
+            E::from([ 1e100 ])->min());
+        $this->assertSame(
+            PHP_INT_MAX,
+            E::from([ INF, PHP_INT_MAX, PHP_FLOAT_MAX ])->min());
 
         // min (selector)
         $this->assertSame(

YaLinqo/.github/.coderabbit.yaml

@@ -4,7 +4,7 @@
 # Complete reference: https://docs.coderabbit.ai/reference/configuration
 
 language: "en-US" # Set the language for reviews by using the corresponding ISO language code.
-tone_instructions: "" # Set the tone of reviews and chat. Example: 'You must use talk like Mr. T. I pity the fool who doesn't!' # Default: ""
+tone_instructions: "You must talk like the wise baboon Rafiki from The Lion King." # Set the tone of reviews and chat. Example: 'You must use talk like Mr. T. I pity the fool who doesn't!' # Default: ""
 early_access: false # Enable early-access features. # Default: false
 enable_free_tier: true # Enable free tier features for users not on a paid plan. # Default: true
 

YaLinqo/Enumerable.php

@@ -507,7 +507,7 @@ public function max($selector = null)
     {
         $selector = Utils::createLambda($selector, 'v,k', Functions::$value);
 
-        $max = -PHP_INT_MAX;
+        $max = -INF;
         $assigned = false;
         foreach ($this as $k => $v) {
             $max = max($max, $selector($v, $k));
@@ -555,7 +555,7 @@ public function min($selector = null)
     {
         $selector = Utils::createLambda($selector, 'v,k', Functions::$value);
 
-        $min = PHP_INT_MAX;
+        $min = INF;
         $assigned = false;
         foreach ($this as $k => $v) {
             $min = min($min, $selector($v, $k));
@@ -995,12 +995,16 @@ public function toDictionary($keySelector = null, $valueSelector = null): array
      * <p>This function only works with UTF-8 encoded data.
      * @param int $options Bitmask consisting of JSON_HEX_QUOT, JSON_HEX_TAG, JSON_HEX_AMP, JSON_HEX_APOS, JSON_NUMERIC_CHECK, JSON_PRETTY_PRINT, JSON_UNESCAPED_SLASHES, JSON_FORCE_OBJECT, JSON_UNESCAPED_UNICODE. Default: 0.
      * @return string A JSON encoded string on success or false on failure.
+     * @throws \UnexpectedValueException If json_encode fails.
      * @see json_encode
      * @package YaLinqo\Conversion
      */
     public function toJSON(int $options = 0): string
     {
-        return json_encode($this->toArrayDeep(), $options);
+        $result = json_encode($this->toArrayDeep(), $options);
+        if ($result === false)
+            throw new \UnexpectedValueException(json_last_error_msg());
+        return $result;
     }
 
     /**

YaLinqo/EnumerablePagination.php

@@ -319,7 +319,7 @@ public function singleOrFallback($fallback, $predicate = null)
      * <p><b>Syntax</b>: indexOf (value)
      * <p>To search for the zero-based index of the first occurence, call {@link toValues} method first.
      * @param mixed $value The value to locate in the sequence.
-     * @return mixed The key of the first occurrence of value, if found; otherwise, false.
+     * @return mixed The key of the first occurrence of value, if found; otherwise, null.
      * @package YaLinqo\Pagination
      */
     public function indexOf($value)

YaLinqo/Errors.php

@@ -30,5 +30,5 @@ class Errors
     /** Error message: "step must be a positive value." */
     const STEP_NEGATIVE = 'step must be a positive value.';
     /** Error message: "type must by one of built-in types." */
-    const UNSUPPORTED_BUILTIN_TYPE = 'type must by one of built-in types.';
+    const UNSUPPORTED_BUILTIN_TYPE = 'type must be one of built-in types.';
 }

YaLinqo/Utils.php

@@ -152,7 +152,7 @@ private static function createLambdaFromString(string $closure, string $closureA
             if (strlen($code) > 0 && $code[0] != '{')
                 $code = "return {$code};";
             $fun = eval("return function($args) { $code };");
-            if (!$fun)
+            if (!is_callable($fun))
                 throw new \InvalidArgumentException(self::ERROR_CANNOT_PARSE_LAMBDA);
             self::$lambdaCache[$closure][$closureArgs] = $fun;
             return $fun;