domain-dependency-list - return 404 for unknown domains (#3186)

Signed-off-by: Henry Avetisyan <hga@yahooinc.com>

Author: havetisyan

servers/zms/src/main/java/com/yahoo/athenz/zms/ZMSImpl.java

@@ -12801,6 +12801,10 @@ public ServiceIdentityList getDependentServiceList(ResourceContext ctx, String d
         String serviceDomainName = domainName.toLowerCase();
         setRequestDomain(ctx, serviceDomainName);
 
+        if (dbService.getDomain(serviceDomainName, false) == null) {
+            throw ZMSUtils.notFoundError("No such domain: " + serviceDomainName, caller);
+        }
+
         // first let's get the service dependencies from our own database
 
         ServiceIdentityList services = dbService.listServiceDependencies(serviceDomainName);

servers/zms/src/test/java/com/yahoo/athenz/zms/DomainDependencyTest.java

@@ -463,8 +463,15 @@ public void testDomainNotFound() {
         ZMSImpl zmsImpl = zmsTestInitializer.zmsInit();
         RsrcCtxWrapper ctx = zmsTestInitializer.getMockDomRsrcCtx();
 
-        ServiceIdentityList dependentServiceList = zmsImpl.getDependentServiceList(ctx, "some.unknown.domain");
-        assertTrue(dependentServiceList.getNames().isEmpty());
+        // asking for domain dependency on a non-existent domain should return 404 not found exception
+
+        try {
+            zmsImpl.getDependentServiceList(ctx, "some.unknown.domain");
+            fail();
+        } catch (ResourceException ex) {
+            assertEquals(ex.getCode(), 404);
+            assertTrue(ex.getMessage().contains("No such domain: some.unknown.domain"));
+        }
     }
 
     @Test