Skip to content

Commit de94bc2

Browse files
ZambrellaDoug ToddEchoEllet
authored
fix: link menu action Cupertino modal popup now does NOT use root nav (singerdmx#2332)
* fix: link menu action cupertino modal popup now does not use root navigator This is to fix a bug where when using nested navigators the modal popup wouldn't pop. This also brings the behavior into parity with the Android/Material equivalent. * chore: add comment referencing bug fix singerdmx#1170 --------- Co-authored-by: Doug Todd <[email protected]> Co-authored-by: Ellet <[email protected]>
1 parent 2f8c11d commit de94bc2

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

lib/src/editor/widgets/link.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,8 @@ class QuillTextLink {
150150
Future<LinkMenuAction> _showCupertinoLinkMenu(
151151
BuildContext context, String link) async {
152152
final result = await showCupertinoModalPopup<LinkMenuAction>(
153+
// Set useRootNavigator to false to fix https://github.com/singerdmx/flutter-quill/issues/1170
154+
useRootNavigator: false,
153155
context: context,
154156
builder: (ctx) {
155157
return CupertinoActionSheet(

0 commit comments

Comments
 (0)