👕 Fix linting issues

Author: Arcanemagus

lib/main.js

@@ -73,8 +73,7 @@ const parseClangRanges = (ranges) => {
  */
 const findTextEditor = (filePath) => {
   const allEditors = atom.workspace.getTextEditors();
-  const matchingEditor = allEditors.find(
-    textEditor => textEditor.getPath() === filePath);
+  const matchingEditor = allEditors.find(textEditor => textEditor.getPath() === filePath);
   return matchingEditor || false;
 };
 
@@ -97,38 +96,24 @@ export default {
       atom.config.observe('linter-clang.executablePath', (value) => {
         this.executablePath = value;
       }),
-    );
-    this.subscriptions.add(
       atom.config.observe('linter-clang.clangIncludePaths', (value) => {
         this.clangIncludePaths = value;
       }),
-    );
-    this.subscriptions.add(
       atom.config.observe('linter-clang.clangSuppressWarnings', (value) => {
         this.clangSuppressWarnings = value;
       }),
-    );
-    this.subscriptions.add(
       atom.config.observe('linter-clang.clangDefaultCFlags', (value) => {
         this.clangDefaultCFlags = value;
       }),
-    );
-    this.subscriptions.add(
       atom.config.observe('linter-clang.clangDefaultCppFlags', (value) => {
         this.clangDefaultCppFlags = value;
       }),
-    );
-    this.subscriptions.add(
       atom.config.observe('linter-clang.clangDefaultObjCFlags', (value) => {
         this.clangDefaultObjCFlags = value;
       }),
-    );
-    this.subscriptions.add(
       atom.config.observe('linter-clang.clangDefaultObjCppFlags', (value) => {
         this.clangDefaultObjCppFlags = value;
       }),
-    );
-    this.subscriptions.add(
       atom.config.observe('linter-clang.clangErrorLimit', (value) => {
         this.clangErrorLimit = value;
       }),
@@ -210,9 +195,7 @@ export default {
           args.push('--verbose');
         }
 
-        this.clangIncludePaths.forEach(path =>
-          args.push(`-I${path}`),
-        );
+        this.clangIncludePaths.forEach(path => args.push(`-I${path}`));
 
         let usingClangComplete = false;
         try {
@@ -222,7 +205,7 @@ export default {
             usingClangComplete = true;
             const workingDir = /-working-directory=(.+)/.exec(flag);
             if (workingDir !== null) {
-              basePath = workingDir[1];
+              [, basePath] = workingDir;
             }
           });
         } catch (error) {
@@ -269,7 +252,7 @@ export default {
           if (isCurrentFile) {
             file = filePath;
           } else if (isAbsolute(match[1])) {
-            file = match[1];
+            [, file] = match;
           } else {
             file = resolve(basePath, match[1]);
           }
@@ -300,6 +283,7 @@ export default {
             // There is a -Wflag specified, for now just re-insert that into the excerpt
             excerpt = `${match[6]} [${match[7]}]`;
           } else {
+            // eslint-disable-next-line prefer-destructuring
             excerpt = match[6];
           }
           const message = {

spec/.eslintrc.js

@@ -1,6 +1,14 @@
 module.exports = {
   env: {
     atomtest: true,
-    jasmine: true
+    jasmine: true,
+  },
+  rules: {
+    "import/no-extraneous-dependencies": [
+      "error",
+      {
+        "devDependencies": true
+      }
+    ]
   }
 };

spec/linter-clang-spec.js

@@ -1,11 +1,10 @@
 'use babel';
 
-// eslint-disable-next-line import/no-extraneous-dependencies
-import { beforeEach, it } from 'jasmine-fix';
-// Note, when testing if using fit you must import it!
 import { join } from 'path';
+// eslint-disable-next-line no-unused-vars
+import { it, fit, wait, beforeEach, afterEach } from 'jasmine-fix';
 
-const lint = require('../lib/main').provideLinter().lint;
+const { lint } = require('../lib/main').provideLinter();
 
 const miPath = join(__dirname, 'files', 'missing_import');
 const poPath = join(__dirname, 'files', 'pragma', 'pragma_once');