Merge pull request #193 from AtomLinter/arcanemagus/lintOnChange

Enable linting on change

Author: Arcanemagus

lib/main.js

@@ -73,7 +73,7 @@ export default {
     return {
       name: 'clang',
       scope: 'file',
-      lintsOnChange: false,
+      lintsOnChange: true,
       grammarScopes: ['source.c', 'source.cpp', 'source.objc', 'source.objcpp'],
       lint: async (editor) => {
         if (helpers === null) {
@@ -84,7 +84,13 @@ export default {
         }
 
         const filePath = editor.getPath();
+        if (filePath === undefined) {
+          // The editor has no path, meaning it hasn't been saved. Although
+          // clang could give us results for this, Linter needs a path
+          return [];
+        }
         const fileExt = extname(filePath);
+        const fileDir = dirname(filePath);
         const fileText = editor.getText();
 
         const args = [
@@ -96,6 +102,7 @@ export default {
           `-ferror-limit=${this.clangErrorLimit}`,
         ];
 
+        // Non-Public API!
         const grammar = editor.getGrammar().name;
 
         switch (grammar) {
@@ -148,17 +155,13 @@ export default {
           }
         }
 
-        args.push(filePath);
-
-        let [projectPath] = atom.project.relativizePath(filePath);
-        if (projectPath === null) {
-          projectPath = dirname(filePath);
-        }
+        args.push('-');
 
         const execOpts = {
+          stdin: fileText,
           stream: 'stderr',
           allowEmptyStderr: true,
-          cwd: projectPath,
+          cwd: fileDir,
         };
 
         const output = await helpers.exec(this.executablePath, args, execOpts);
@@ -187,9 +190,11 @@ export default {
             position = helpers.generateRange(editor, line, col);
           }
           const severity = /error/.test(match[8]) ? 'error' : 'warning';
+          // Handle paths other than the file being linted still
+          const file = match[1] === '<stdin>' ? filePath : match[1];
           toReturn.push({
             severity,
-            location: { file: match[1], position },
+            location: { file, position },
             excerpt: match[9],
           });
           match = regex.exec(output);

spec/linter-clang-spec.js

@@ -9,6 +9,14 @@ const lint = require('../lib/main').provideLinter().lint;
 const miPath = join(__dirname, 'files', 'missing_import');
 const poPath = join(__dirname, 'files', 'pragma', 'pragma_once');
 const validPath = join(__dirname, 'files', 'valid.c');
+const fileText = `// This is a comment, this will not return any errors.
+#include "nothing.h"
+
+int main(int argc, char const *argv[]) {
+  /* code */
+  return 0;
+}
+`;
 
 describe('The Clang provider for AtomLinter', () => {
   beforeEach(async () => {
@@ -97,4 +105,18 @@ describe('The Clang provider for AtomLinter', () => {
       expect(messages.length).toEqual(0);
     });
   });
+
+  it('works on a modified file', async () => {
+    // Open the valid file
+    const editor = await atom.workspace.open(validPath);
+    // Set the text to invalid text
+    editor.setText(fileText);
+    // Lint the editor
+    const messages = await lint(editor);
+    expect(messages.length).toBe(1);
+    expect(messages[0].severity).toBe('error');
+    expect(messages[0].excerpt).toBe("'nothing.h' file not found");
+    expect(messages[0].location.file).toBe(validPath);
+    expect(messages[0].location.position).toEqual([[1, 9], [1, 20]]);
+  });
 });