Merge pull request #107 from AtomLinter/greenkeeper/eslint-config-airbnb-base-12.0.0

Update eslint-config-airbnb-base to version 12.0.0 🚀

Author: Arcanemagus

lib/init.js

@@ -103,8 +103,7 @@ const isPhoenixProject = async (filePath) => {
 
 const findTextEditor = (filePath) => {
   const allEditors = atom.workspace.getTextEditors();
-  const matchingEditor = allEditors.find(
-    textEditor => textEditor.getPath() === filePath);
+  const matchingEditor = allEditors.find(textEditor => textEditor.getPath() === filePath);
   if (matchingEditor !== undefined) {
     return matchingEditor;
   }
@@ -284,10 +283,7 @@ const getDepsPa = async (filePath) => {
   const projectPath = await elixirProjectPath(filePath);
   try {
     return readdirSync(join(projectPath, buildDir))
-      .map(
-        item =>
-          join(projectPath, buildDir, item, 'ebin'),
-      );
+      .map(item => join(projectPath, buildDir, item, 'ebin'));
   } catch (e) {
     return [];
   }
@@ -347,18 +343,12 @@ export default {
       atom.config.observe('linter-elixirc.elixircPath', (value) => {
         elixircPath = value;
       }),
-    );
-    this.subscriptions.add(
       atom.config.observe('linter-elixirc.mixPath', (value) => {
         mixPath = value;
       }),
-    );
-    this.subscriptions.add(
       atom.config.observe('linter-elixirc.forceElixirc', (value) => {
         forceElixirc = value;
       }),
-    );
-    this.subscriptions.add(
       atom.config.observe('linter-elixirc.mixEnv', (value) => {
         mixEnv = value;
       }),

package.json

@@ -44,14 +44,18 @@
     "linter:2.0.0",
     "language-elixir"
   ],
+  "scripts": {
+    "lint": "eslint .",
+    "test": "apm test"
+  },
   "dependencies": {
     "atom-linter": "^10.0.0",
     "atom-package-deps": "^4.5.0",
     "tmp": "^0.0.33"
   },
   "devDependencies": {
-    "eslint": "^4.3.0",
-    "eslint-config-airbnb-base": "^11.3.1",
+    "eslint": "^4.6.0",
+    "eslint-config-airbnb-base": "^12.0.0",
     "eslint-plugin-import": "^2.7.0",
     "fs-extra": "^4.0.1"
   },

spec/.eslintrc.js

@@ -1,6 +1,14 @@
 module.exports = {
   env: {
+    atomtest: true,
     jasmine: true,
-    atomtest: true
+  },
+  rules: {
+    "import/no-extraneous-dependencies": [
+      "error",
+      {
+        "devDependencies": true
+      }
+    ]
   }
 };

spec/linter-elixirc-spec.js

@@ -4,6 +4,8 @@ import { join } from 'path';
 // eslint-disable-next-line import/no-extraneous-dependencies, import/no-unresolved
 import { remove } from 'fs-extra';
 
+const { lint } = require('../lib/init.js').provideLinter();
+
 const validPathElixirc = join(__dirname, 'fixtures', 'elixirc', 'valid.ex');
 const warningPathElixirc = join(__dirname, 'fixtures', 'elixirc', 'warning.ex');
 const errorMode1PathElixirc = join(__dirname, 'fixtures', 'elixirc', 'error-mode1.ex');
@@ -19,18 +21,14 @@ remove(mixBuildDirectory);
 describe('The elixirc provider for Linter', () => {
   describe('when not working inside a Mix project', () => {
     describe('and using the standard configuration', () => {
-      let lint;
-
       beforeEach(() => {
-        lint = require('../lib/init.js').provideLinter().lint;
         atom.workspace.destroyActivePaneItem();
 
         waitsForPromise(() =>
           Promise.all([
             atom.packages.activatePackage('linter-elixirc'),
             atom.packages.activatePackage('language-elixir'),
-          ]),
-        );
+          ]));
       });
 
       it('works with mode 1 errors', () => {
@@ -43,8 +41,7 @@ describe('The elixirc provider for Linter', () => {
             expect(messages[0].excerpt).toBe('(ArgumentError) Dangerous is not available');
             expect(messages[0].location.file).toBe(errorMode1PathElixirc);
             expect(messages[0].location.position).toEqual([[1, 0], [1, 32]]);
-          }),
-        );
+          }));
       });
 
       it('works with mode 2 errors', () => {
@@ -57,8 +54,7 @@ describe('The elixirc provider for Linter', () => {
             expect(messages[0].excerpt).toBe('(CompileError) module Usefulness is not loaded and could not be found');
             expect(messages[0].location.file).toBe(errorMode2PathElixirc);
             expect(messages[0].location.position).toEqual([[3, 2], [3, 20]]);
-          }),
-        );
+          }));
       });
 
       it('works with warnings', () => {
@@ -70,8 +66,7 @@ describe('The elixirc provider for Linter', () => {
             expect(messages[0].excerpt).toBe('variable "prepare_for_call" does not exist and is being expanded to "prepare_for_call()", please use parentheses to remove the ambiguity or change the variable name');
             expect(messages[0].location.file).toBe(warningPathElixirc);
             expect(messages[0].location.position).toEqual([[20, 4], [20, 20]]);
-          }),
-        );
+          }));
       });
 
       it('works with .exs files', () => {
@@ -83,34 +78,28 @@ describe('The elixirc provider for Linter', () => {
             expect(messages[0].excerpt).toBe('function simple_function/0 is unused');
             expect(messages[0].location.file).toBe(exsFilePathElixirc);
             expect(messages[0].location.position).toEqual([[1, 2], [1, 25]]);
-          }),
-        );
+          }));
       });
 
       it('finds nothing wrong with a valid file', () => {
         waitsForPromise(() =>
           atom.workspace.open(validPathElixirc).then(editor => lint(editor)).then((messages) => {
             expect(messages.length).toBe(0);
-          }),
-        );
+          }));
       });
     });
   });
 
   describe('when working inside a Mix project', () => {
     describe('and using the standard configuration', () => {
-      let lint;
-
       beforeEach(() => {
-        lint = require('../lib/init.js').provideLinter().lint;
         atom.workspace.destroyActivePaneItem();
 
         waitsForPromise(() =>
           Promise.all([
             atom.packages.activatePackage('linter-elixirc'),
             atom.packages.activatePackage('language-elixir'),
-          ]),
-        );
+          ]));
       });
 
       it('works with mode 2 errors', () => {
@@ -123,8 +112,7 @@ describe('The elixirc provider for Linter', () => {
             expect(messages[0].excerpt).toBe('(CompileError) Identicon.Image.__struct__/1 is undefined, cannot expand struct Identicon.Image');
             expect(messages[0].location.file).toBe(errorMode2PathMix);
             expect(messages[0].location.position).toEqual([[11, 4], [11, 30]]);
-          }),
-        );
+          }));
       });
 
       it('works with .exs files', () => {
@@ -136,27 +124,22 @@ describe('The elixirc provider for Linter', () => {
             expect(messages[0].excerpt).toBe('function simple_function/0 is unused');
             expect(messages[0].location.file).toBe(exsFilePathMix);
             expect(messages[0].location.position).toEqual([[1, 2], [1, 25]]);
-          }),
-        );
+          }));
       });
     });
   });
 });
 
 describe('when using the setting forceElixirc', () => {
-  let lint;
-
   beforeEach(() => {
     atom.config.set('linter-elixirc.forceElixirc', true);
-    lint = require('../lib/init.js').provideLinter().lint;
     atom.workspace.destroyActivePaneItem();
 
     waitsForPromise(() =>
       Promise.all([
         atom.packages.activatePackage('linter-elixirc'),
         atom.packages.activatePackage('language-elixir'),
-      ]),
-    );
+      ]));
   });
 
   it('works with warnings', () => {
@@ -168,7 +151,6 @@ describe('when using the setting forceElixirc', () => {
         expect(messages[0].excerpt).toBe('(CompileError) Identicon.Image.__struct__/1 is undefined, cannot expand struct Identicon.Image');
         expect(messages[0].location.file).toBe(errorMode2PathMix);
         expect(messages[0].location.position).toEqual([[11, 4], [11, 30]]);
-      }),
-    );
+      }));
   });
 });