Merge pull request #92 from mauricerkelly/fix-absolute-relative-path-issues

Fix absolute vs relative path issues

Author: mauricerkelly

lib/init.js

@@ -3,7 +3,7 @@
 // eslint-disable-next-line import/no-extraneous-dependencies, import/extensions
 import { CompositeDisposable, Range } from 'atom';
 import { find, generateRange, exec } from 'atom-linter';
-import { dirname, join, relative, sep } from 'path';
+import { dirname, join, relative, sep, isAbsolute } from 'path';
 import { existsSync, readFileSync, readdirSync } from 'fs';
 
 const tmp = require('tmp');
@@ -111,6 +111,13 @@ const findTextEditor = (filePath) => {
   return false;
 };
 
+const ensureAbsolutePath = (projectPath, filePath) => {
+  if (isAbsolute(filePath)) {
+    return filePath;
+  }
+  return join(projectPath, filePath);
+};
+
 const parseError = async (toParse, sourceFilePath) => {
   const messages = [];
   const re = regexp(
@@ -138,7 +145,7 @@ const parseError = async (toParse, sourceFilePath) => {
     let range;
     if (reResult[2] !== undefined) {
       excerpt = `(${reResult[1]}) ${reResult[2]}`;
-      filePath = join(projectPath, reResult[3]);
+      filePath = ensureAbsolutePath(projectPath, reResult[3]);
       const fileEditor = findTextEditor(filePath);
       if (fileEditor) {
         // If there is an open TextEditor instance for the file from the Error,
@@ -151,7 +158,7 @@ const parseError = async (toParse, sourceFilePath) => {
       }
     } else {
       excerpt = `(${reResult[1]}) ${reResult[7]}`;
-      filePath = join(projectPath, reResult[5]);
+      filePath = ensureAbsolutePath(projectPath, reResult[5]);
       const fileEditor = findTextEditor(filePath);
       if (fileEditor) {
         range = generateRange(fileEditor, reResult[6] - 1);
@@ -183,7 +190,7 @@ const parseWarning = async (toParse, sourceFilePath) => {
   let reResult = re.exec(toParse);
 
   while (reResult != null) {
-    const filePath = join(projectPath, reResult[2]);
+    const filePath = ensureAbsolutePath(projectPath, reResult[2]);
     try {
       let range;
       const fileEditor = findTextEditor(filePath);
@@ -221,7 +228,7 @@ const parseLegacyWarning = async (toParse, sourceFilePath) => {
   const projectPath = await elixirProjectPath(sourceFilePath);
   let reResult = re.exec(toParse);
   while (reResult !== null) {
-    const filePath = join(projectPath, reResult[1]);
+    const filePath = ensureAbsolutePath(projectPath, reResult[1]);
     try {
       let range;
       const fileEditor = findTextEditor(filePath);