fix: ensure we clear cache when .eslintrc changes

Also refrain from clearing cache when `.eslintrc` is removed or added 
from a `node_modules` path.

Author: savetheclocktower

lib/main.js

@@ -34,6 +34,16 @@ function eventInvolvesFile (event, fileName) {
   return event.path.endsWith(fileName) || (event.oldPath && event.oldPath.endsWith(fileName));
 }
 
+// Catch file-change events that involve any of `.eslintrc`, `.eslintrc.js`, or
+// `.eslintrc.yml`.
+function eventInvolvesEslintrc (event) {
+  return [event.path, event.oldPath].some((p) => {
+    return p && (
+      p.includes(`${Path.sep}.eslintrc`) || p.startsWith(`.eslintrc`)
+    );
+  });
+}
+
 export default {
 
   shouldAutoFix (textEditor) {
@@ -48,7 +58,7 @@ export default {
   },
 
   async activate () {
-    Config.initialize();
+    Config.initialize(atom.project.getPaths()[0]);
     this.workerPath = Path.join(__dirname, 'worker.js');
     this.jobManager = new JobManager();
 
@@ -78,18 +88,15 @@ export default {
           });
         }
       ),
+
       // Scan for new .linter-eslint config files when project paths change.
-      atom.project.onDidChangePaths(
-        projectPaths => {
-          this.projectPaths = projectPaths;
-          Config.rescan();
-        }
-      ),
+      atom.project.onDidChangePaths(() => Config.rescan()),
+
       // React to changes that happen either in a .linter-eslint file or the
       // base package settings.
       Config.onConfigDidChange(
         (config, prevConfig) => {
-          console.debug('Config.onConfigDidChange', config, prevConfig);
+          console.debug('Config changed:', config, prevConfig);
           if (helpers.configShouldInvalidateWorkerCache(config, prevConfig)) {
             this.clearESLintCache();
           }
@@ -101,11 +108,10 @@ export default {
 
           if (config.nodeBin !== prevConfig.nodeBin) {
             this.notified.invalidNodeBin = false;
-            console.log('Testing bin:', config.nodeBin, this.notified.invalid);
             NodePathTester
-              .schedule(config.nodeBin)
+              .test(config.nodeBin)
               .then((version) => {
-                console.log(`Switched Node to version`, version);
+                console.log(`Switched Node to version:`, version);
                 this.jobManager.createWorker();
               })
               .catch(() => {
@@ -114,6 +120,7 @@ export default {
           }
         }
       ),
+
       atom.commands.add('atom-text-editor', {
         'linter-eslint-node:fix-file': async () => {
           await this.fixJob();
@@ -123,11 +130,13 @@ export default {
         }
       }),
 
-      // Keep track of `.eslintignore` updates.
-      // TODO: If the changed file's relative project path includes
-      // `node_modules`, ignore it.
+      // Keep track of `.eslintignore` and `.eslintrc` updates.
       atom.project.onDidChangeFiles(events => {
         for (const event of events) {
+          // Without this, `npm install` inside an already-open project
+          // triggers a _bunch_ of cache clearances.
+          if (event.path.includes('node_modules')) { return false; }
+
           if (eventInvolvesFile(event, '.linter-eslint')) {
             Config.rescan();
           }
@@ -140,6 +149,10 @@ export default {
           if (eventInvolvesFile(event, '.eslintignore')) {
             this.clearESLintCache();
           }
+
+          if (eventInvolvesEslintrc(event)) {
+            this.clearESLintCache();
+          }
         }
       }),
 
@@ -372,7 +385,6 @@ export default {
   },
 
   handleError (err, type, editor = null) {
-    console.debug('handleError:', err);
     if (err.name && err.name === 'InvalidWorkerError') {
       // The worker script never got created. Aside from notifying the user
       // (which will be skipped if they've already gotten such a message in
@@ -555,7 +567,7 @@ export default {
             filteredResults.push(result);
           }
 
-          console.log('RETURNED RESULTS:', filteredResults);
+          console.debug('Linting results:', filteredResults);
           return filteredResults;
         } catch (err) {
           return this.handleError(err, 'lint', textEditor);