Merge pull request #340 from AtomLinter/issue335

Fix file import resolution

Author: IanVS

.eslintignore

@@ -1 +1,2 @@
 spec/files/bad.js
+spec/eslintignore/ignored.js

lib/worker.js

@@ -66,7 +66,6 @@ Communication.on('JOB', function(job) {
   } else process.env.NODE_PATH = ''
   require('module').Module._initPaths()
 
-  process.chdir(params.fileDir)
 
   if (params.global) {
     if (params.nodePath === '' && prefixPath === null) {
@@ -102,7 +101,14 @@ Communication.on('JOB', function(job) {
   }
 
   job.Response = new Promise(function(resolve) {
-    const filePath = (eslintignoreDir) ? Path.relative(eslintignoreDir, params.filePath) : params.filePath
+    let filePath
+    if (eslintignoreDir) {
+      filePath = Path.relative(eslintignoreDir, params.filePath)
+      process.chdir(eslintignoreDir)
+    } else {
+      filePath = Path.basename(params.filePath)
+      process.chdir(params.fileDir)
+    }
     const argv = [
       process.execPath,
       eslintPath,

package.json

@@ -19,9 +19,10 @@
   },
   "devDependencies": {
     "babel-eslint": "^4.1.5",
-    "eslint-plugin-react": "^3.10.0",
+    "eslint-config-airbnb": "latest",
     "eslint-config-steelbrain": "latest",
-    "eslint-config-airbnb": "latest"
+    "eslint-plugin-import": "^0.11.0",
+    "eslint-plugin-react": "^3.10.0"
   },
   "package-deps": [
     "linter"

spec/eslintignore/.eslintrc.yaml

@@ -0,0 +1,8 @@
+---
+
+  root: true
+
+  rules:
+    semi:
+      - 2
+      - never

spec/eslintignore/ignored.js

@@ -0,0 +1 @@
+var foo = 2;

spec/import-resolution/.eslintrc.yaml

@@ -0,0 +1,11 @@
+---
+
+  root: true
+
+  parser: babel-eslint
+
+  plugins:
+    - import
+
+  rules:
+    import/no-unresolved: 2

spec/import-resolution/exporting.js

@@ -0,0 +1 @@
+export const meaning = 42

spec/import-resolution/nested/importing.js

@@ -0,0 +1 @@
+import { meaning } from '../exporting'

spec/linter-eslint-spec.js

@@ -65,4 +65,28 @@ describe('The eslint provider for Linter', () => {
       });
     })
   });
+
+  describe('when resolving import paths using eslint-plugin-import', () => {
+    it('correctly resolves imports from parent', () => {
+      waitsForPromise(() => {
+        return atom.workspace.open(`${__dirname}/import-resolution/nested/importing.js`).then(editor => {
+          return lint(editor).then(messages => {
+            expect(messages.length).toEqual(0);
+          })
+        })
+      })
+    })
+  })
+
+  describe('when a file is specified in an .eslintignore file', () => {
+    it('will not give warnings for the file', () => {
+      waitsForPromise(() => {
+        return atom.workspace.open(`${__dirname}/eslintignore/ignored.js`).then(editor => {
+          return lint(editor).then(messages => {
+            expect(messages.length).toEqual(0);
+          })
+        })
+      })
+    })
+  })
 });