new error message about crash

removed julia fork to get default environment

Author: takbal

.gitignore

@@ -1,3 +1,4 @@
 .DS_Store
 npm-debug.log
 node_modules
+.package.json.full

README.md

@@ -13,39 +13,41 @@ This is a fork that replaces Lint.jl with StaticLint.jl from the Julia VSCode pl
 * julia-1.5.3
 * [linter-ui-default](https://atom.io/packages/linter-ui-default)
 * [linter](https://atom.io/packages/linter)
-* tested on ubuntu 18.04 and Windows
+* tested on Ubuntu 18.04 and Windows
 
 ## Caveats
 
 * The server needs a minute to spin up, then also some time to parse new Julia environments that this Atom instance
-  have not seen before. A pop-up is shown when parsing the environment starts, but not when it ends. After that, you need to
-  edit or reopen the files already in editing for linting to start. If the environment had been already parsed, linting new files is immediate.
+  have not seen before. A pop-up is shown when parsing a new environment starts (but not when it ends). After parsing finishes, you need to
+  edit or reopen those files that are already in the editor for linting to start. If the environment had been already parsed, linting new files is immediate.
 * The edited file has to be saved at least once for linting to start. This is by design of the linter package (https://github.com/steelbrain/linter/issues/1235)
 * The environment for each file is guessed from its path. If this fails, Julia's default environment is assumed.
 * The symbols are rebuilt if the modification time of the Project.toml or the Manifest.toml files change, for example,
 you add, remove or update packages. Linting is not available during this rebuild.
-* It works on Windows, but does not shuts down correctly.
+* It works on Windows, but the Julia server does not shuts down on its own there (yet).
 
 ## Internals
 
-I know nothing of Atom development or js, so the changes are likely messy there, please revise. Atom seems to be
-unable to shut down the server process, so the server exits by polling Atom's PID right now. This does not work on Windows yet.
-
 The code generates its private shared environment at the Julia depot in 'environments/linter-julia'. It also places a logfile there.
 
 Guessing the environment works by walking upwards in the path and looking for Project.toml. If nothing found, the default
 environment is assumed. The project's root file is then looked for at the canonical X/src/X.jl etc. locations.
 
+I know nothing of Atom development or js, so the changes are likely messy there, please revise. Atom seems to be
+unable to shut down the server process, so the server exits by polling Atom's PID right now. This does not work on Windows yet.
+
 ## Installation
 
 - Install the package through Atom's UI. You can also use the `apm` tool in the CLI:
 ```bash
 $ apm install takbal/linter-julia
 ```
 
-- You may need to tell linter-julia where to find the julia executable
+- You may need to tell linter-julia where to find the Julia executable
 (i.e. `/usr/bin/julia` or `C:\Julia-1.5.3\bin\julia.exe`). The default assumes 'julia' just works.
 
+- Julia must have the General registry added.
+
 ## Settings
 
 ![screenshot](https://raw.githubusercontent.com/AtomLinter/linter-julia/master/settings.png)

lib/index.js

@@ -62,7 +62,7 @@ export function activate() {
        }
        */
       if (global.linter_julia_started) {
-        atom.notifications.addInfo('linter-julia: please restart Atom for this change to work');
+        atom.notifications.addInfo('[Linter-Julia] please restart Atom for this change to work');
       }
     }),
     atom.config.observe('linter-julia.ignoreInfo', (value) => {
@@ -143,10 +143,10 @@ export function provideLinter() {
           try {
             parsed = JSON.parse(merged);
           } catch (_) {
-            const msg = '[Linter-Julia] Server returned non-JSON response';
-            atom.notifications.addError(`${msg}. See console for more info`);
+            atom.notifications.addError(`[Linter-Julia] server has likely crashed. Please check symbolserver.log.${process.pid}
+              in the "linter-julia" shared Julia environment, and restart Atom.`);
             // eslint-disable-next-line no-console
-            console.error(`${msg}: `, merged);
+            console.error('server returned: ', merged);
             resolve(null);
             return;
           }

lib/julia-server.jl

@@ -2,6 +2,9 @@ using Pkg, Sockets, Serialization, Logging
 
 import Base.Threads.@spawn
 
+# assumes the julia executable starts in the default environment
+const default_env = dirname(Pkg.project().path)
+
 # both this script and the symbol server is going to use this shared environment
 Pkg.activate("linter-julia", shared=true)
 
@@ -28,9 +31,6 @@ needed_packages = Dict(
     return(String(take!(buffer)))
 end
 
-# if you know a better way of getting the default Julia environment, please tell ...
-const julia_exec = joinpath(Sys.BINDIR, Base.julia_exename())
-const default_env = strip(read(`$julia_exec --startup-file=no -e "using Pkg; println(dirname(Pkg.project().path))"`, String))
 const store_location = dirname(Pkg.project().path)
 const port = ARGS[1]
 const atom_pid = parse(Int32, split(port,"_")[end])
@@ -448,9 +448,12 @@ end
 try
     server = listen(port)
 
-    # # this is looping until Atom dies
+    # this is looping until Atom dies
     while true
         conn = accept(server)
+        # there isn't too much point in @spawn this: only the server generation is slow, and that is MT anyway
+        # you would also need to add more threads that are not going do too much all of the time
+        # but you may get weird race conditions
         @async handle_connection(conn)
     end