Skip to content
This repository was archived by the owner on Aug 7, 2023. It is now read-only.

Commit c78d1f5

Browse files
committed
fixing tests: first message is empty due to env build. Try to do it in beforeAll()
1 parent b63c31e commit c78d1f5

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

lib/julia-server.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -490,9 +490,7 @@ try
490490
# this is looping until Atom dies
491491
while true
492492
conn = accept(server)
493-
# there isn't too much point in @spawn this: only the server generation is slow, and that is MT anyway
494-
# you would also need to add more threads that are not going do too much all of the time
495-
# but you may get weird race conditions
493+
# the pipe is fifo anyway and cannot deal with multiple connections
496494
@async handle_connection(conn)
497495
end
498496

spec/linter-julia-spec.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,13 @@ describe('The Julia StaticLint.jl provider for Linter', () => {
2020
await atom.packages.activatePackage('linter-julia');
2121
});
2222

23+
// avoid first pass empty messages by linting any files in the environment, then
24+
// waiting for the symbols to build
25+
beforeAll(function (done) {
26+
await atom.workspace.open(badFile);
27+
setTimeout(done, 15000);
28+
});
29+
2330
it('checks a file with syntax error and reports the correct message', async () => {
2431
const excerpt = 'Missing reference';
2532
const editor = await atom.workspace.open(badFile);

0 commit comments

Comments
 (0)