Merge pull request #187 from AtomLinter/json_output

convert output parsing to json

Author: mschuchard

lib/main.js

@@ -57,10 +57,8 @@ export default {
         const filePath = activeEditor.getPath();
         const [projectPath, projectRelativeFilePath] = atom.project.relativizePath(filePath);
 
-        // With the custom format the puppet-int ouput looks like this:
-        // error mongodb::service not in autoload module layout 3 7
-        const regexLine = /^(warning|error)\s(.*)\s(\d+)\s(\d+)$/;
-        const args = ['--relative', '--log-format', '%{kind} %{message} %{line} %{column}', '--error-level', errorLevel];
+        // Setup args
+        const args = ['--relative', '--json', '--error-level', errorLevel];
 
         const optionsMap = require('./flags.js');
 
@@ -82,23 +80,27 @@ export default {
             }
             const toReturn = [];
 
+            // Parse JSON output and immediately access zeroth element of redundant outer array
+            const info = JSON.parse(output)[0];
+
             // Check for proper warnings and errors from stdout
-            output.split(/\r?\n/).forEach((line) => {
-              const matches = regexLine.exec(line);
-              if (matches != null) {
-                const errLine = Number.parseInt(matches[3], 10) - 1;
-                const errCol = Number.parseInt(matches[4], 10) - 1;
+            if (info.length > 0) {
+              info.forEach((issue) => {
+                // bypass char line limit
+                const line = issue.line - 1;
+                const col = issue.column - 1;
 
                 toReturn.push({
-                  severity: matches[1],
-                  excerpt: matches[2],
+                  severity: issue.kind,
+                  excerpt: issue.message,
                   location: {
+                    // bug in atom-linter cannot use issue.path
                     file: filePath,
-                    position: helpers.generateRange(activeEditor, errLine, errCol),
+                    position: helpers.generateRange(activeEditor, line, col),
                   },
                 });
-              }
-            });
+              });
+            }
             return toReturn;
           });
       },