Skip to content
This repository was archived by the owner on Aug 7, 2023. It is now read-only.

Commit b2327a1

Browse files
authored
Merge pull request #155 from AtomLinter/min_version_bump
bump minimum supported version to 2.0.0
2 parents 44c15c5 + 5db9dbf commit b2327a1

File tree

4 files changed

+8
-13
lines changed

4 files changed

+8
-13
lines changed

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ language: ruby
55
matrix:
66
include:
77
- os: linux
8-
rvm: 2.3.4
8+
rvm: 2.3.7
99

1010
- os: linux
11-
rvm: 2.3.4
11+
rvm: 2.3.7
1212
env: ATOM_CHANNEL=beta
1313

1414
env:

README.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,11 @@ installed, please follow the instructions [here](http://puppet-lint.com/).
1212

1313
Basically, you should execute `gem install puppet-lint` or `bundle install puppet-lint`.
1414

15+
The minimum supported version of `puppet-lint` is 2.0.0.
16+
1517
### Compatibility
1618

17-
__Since the 0.5.0 version this package is no longer compatible with old
18-
versions of puppet-lint__ because we are now using a custom log format with
19-
`%{line}` and `%{column}` placeholders. If you have an old version of Puppet-Lint
20-
installed, then please follow the instructions for the `puppet-lint` gem installation
21-
to ensure that you have the latest version of Puppet-Lint.
19+
__Since the 0.5.0 version this package is no longer compatible with old versions of puppet-lint__ because we are now using a custom log format with `%{line}` and `%{column}` placeholders. If you have an old version of Puppet-Lint installed, then please follow the instructions for the `puppet-lint` gem installation to ensure that you have the latest version of Puppet-Lint.
2220

2321
### Plugin installation
2422

lib/flags.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ module.exports = {
2323
skipVariableContainsDash: '--no-variable_contains_dash-check',
2424
skipHardTabs: '--no-hard_tabs-check',
2525
skipTrailingWhitespace: '--no-trailing_whitespace-check',
26-
skip80Chars: '--no-80chars-check',
2726
skip140Chars: '--no-140chars-check',
2827
skip2spSoftTabs: '--no-2sp_soft_tabs-check',
2928
skipArrowAlignment: '--no-arrow_alignment-check',

lib/main.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,11 @@ export default {
2525

2626
// Check if puppet-lint has support for the %{column} placeholder
2727
helpers.exec(executablePath, ['--help']).then((output) => {
28-
const regexColumn = /%{column}/;
29-
30-
if (regexColumn.exec(output) === null) {
28+
if (/no-140chars-check/.exec(output) === null) {
3129
atom.notifications.addError(
32-
'You are using an old version of puppet-lint!',
30+
'You are using an unsupported version of puppet-lint!',
3331
{
34-
detail: 'Please upgrade your version of puppet-lint.\n' +
32+
detail: 'Please upgrade your version of puppet-lint to >= 2.0.0.\n' +
3533
'Check the README for further information.',
3634
},
3735
);

0 commit comments

Comments
 (0)