Fix warnings + disable warnings for libjamesdsp

Author: timschneeb

.gitmodules

@@ -1,4 +1,3 @@
- 
 [submodule "src/subprojects/EELEditor"]
 	path = src/subprojects/EELEditor
-	url = https://github.com/thepbone/EELEditor
+	url = git@github.com:thepbone/EELEditor

libjamesdsp/libjamesdsp.pro

@@ -7,6 +7,8 @@ CONFIG += c++17
 
 QMAKE_CFLAGS += -std=gnu11 -O2
 
+CONFIG += warn_off # Disable warnings for library
+
 DEFINES += CUSTOM_CMD
 
 BASEPATH = $$PWD/subtree/Main/libjamesdsp/jni/jamesdsp/jdsp/

src/audio/pipewire/PwJamesDspPlugin.h

@@ -4,9 +4,13 @@
 #include "PwBasePlugin.h"
 #include "IDspElement.h"
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wall"
 extern "C" {
 #include "jdsp_header.h"
 }
+#pragma GCC diagnostic pop
+
 
 class PwJamesDspPlugin : public PwPluginBase, public IDspElement {
 public:

src/audio/pulseaudio/pipeline/JamesDspElement.h

@@ -4,10 +4,6 @@
 #include "IDspElement.h"
 #include "FilterElement.h"
 
-extern "C" {
-#include <jdsp_header.h>
-}
-
 class DspConfig;
 class JamesDspElement : public FilterElement, public IDspElement
 {

src/audio/pulseaudio/wrapper/gstjamesdsp.h

@@ -5,7 +5,11 @@
 #include <gst/audio/audio.h>
 
 G_BEGIN_DECLS
+
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wall"
 #include <jdsp_header.h>
+#pragma GCC diagnostic pop
 
 #define GST_TYPE_JAMESDSP            (gst_jamesdsp_get_type())
 #define GST_JAMESDSP(obj)            (G_TYPE_CHECK_INSTANCE_CAST((obj),GST_TYPE_JAMESDSP,Gstjamesdsp))

src/interface/fragment/SettingsFragment.cpp

@@ -101,7 +101,7 @@ SettingsFragment::SettingsFragment(TrayIcon *trayIcon,
 	ui->paletteSelect->addItem("Stone",      "stone");
 	ui->paletteSelect->addItem("Custom",     "custom");
 
-	for ( const auto &i : QStyleFactory::keys())
+    for ( const auto& i : QStyleFactory::keys())
 	{
 		ui->themeSelect->addItem(i);
 	}
@@ -193,7 +193,7 @@ SettingsFragment::SettingsFragment(TrayIcon *trayIcon,
 	{
 		AppConfig::instance().setLiveprogPath(ui->liveprog_path->text());
 	});
-	connect(ui->liveprog_autoextract, &QCheckBox::clicked, [this]()
+    connect(ui->liveprog_autoextract, &QCheckBox::clicked, this, [this]()
 	{
         AppConfig::instance().set(AppConfig::LiveprogAutoExtract, ui->liveprog_autoextract->isChecked());
 	});
@@ -295,12 +295,12 @@ SettingsFragment::SettingsFragment(TrayIcon *trayIcon,
 	connect(ui->github, &QPushButton::clicked, this, [] {
 		QDesktopServices::openUrl(QUrl("https://github.com/Audio4Linux/JDSP4Linux"));
 	});
-	connect(ui->menu_edit, &QMenuEditor::targetChanged, [this, trayIcon]
+    connect(ui->menu_edit, &QMenuEditor::targetChanged, this, [this, trayIcon]
 	{
 		auto menu = ui->menu_edit->exportMenu();
 		trayIcon->updateTrayMenu(menu);
 	});
-	connect(ui->menu_edit, &QMenuEditor::resetPressed, [this, trayIcon]
+    connect(ui->menu_edit, &QMenuEditor::resetPressed, this, [this, trayIcon]
 	{
 		QMessageBox::StandardButton reply = QMessageBox::question(this, "Warning", "Do you really want to restore the default layout?",
 		                                                          QMessageBox::Yes | QMessageBox::No);

src/src.pro

@@ -11,7 +11,7 @@ greaterThan(QT_MAJOR_VERSION, 4): QT += widgets
 TARGET = jamesdsp
 TEMPLATE = app
 !msvc {
-    QMAKE_CXXFLAGS += "-Wno-old-style-cast -Wno-double-promotion -Wno-unused-function"
+    QMAKE_CXXFLAGS += "-Wno-missing-field-initializers -Wno-unused-variable"
 }
 
 USE_PULSEAUDIO: DEFINES += USE_PULSEAUDIO

src/subprojects/EELEditor

@@ -4,6 +4,13 @@
 #include <QFile>
 #include <QTime>
 
+#define C_RESET "\u001b[0m"
+#define C_RED "\u001b[31m"
+#define C_YELLOW "\u001b[33m"
+#define C_WHITE "\u001b[37m"
+#define C_FAINTWHITE "\u001b[2;37m"
+#define C_BACKRED "\u001b[41;37m"
+
 void Log::debug(const QString &log)
 {
     write(log, Debug);

src/utils/Log.cpp

@@ -38,13 +38,6 @@ class Log
         Critical
     };
 
-    static constexpr char* C_RESET = "\u001b[0m";
-    static constexpr char* C_RED = "\u001b[31m";
-    static constexpr char* C_YELLOW = "\u001b[33m";
-    static constexpr char* C_WHITE = "\u001b[37m";
-    static constexpr char* C_FAINTWHITE = "\u001b[2;37m";
-    static constexpr char* C_BACKRED = "\u001b[41;37m";
-
 	static void debug(const QString &log);
 	static void information(const QString &log);
 	static void warning(const QString &log);