Implement optional crash reporter + fix singleinstancemonitor

Author: timschneeb

src/MainWindow.cpp

@@ -1252,7 +1252,7 @@ void MainWindow::launchFirstRunSetup()
 {
     QHBoxLayout            *lbLayout = new QHBoxLayout;
     QMessageOverlay        *lightBox = new QMessageOverlay(this);
-    FirstLaunchWizard      *wiz      = new FirstLaunchWizard(_audioService, lightBox);
+    FirstLaunchWizard      *wiz      = new FirstLaunchWizard(lightBox);
     QGraphicsOpacityEffect *eff      = new QGraphicsOpacityEffect(lightBox);
     QPropertyAnimation     *a        = new QPropertyAnimation(eff, "opacity");
 

src/config/AppConfig.cpp

@@ -39,6 +39,8 @@ AppConfig::AppConfig()
     DEFINE_KEY(VdcDefaultPath, ENCLOSE_QUOTES(getPath("vdc")));
     DEFINE_KEY(LiveprogDefaultPath, ENCLOSE_QUOTES(getPath("liveprog")));
 
+    DEFINE_KEY(SendCrashReports, true);
+
     connect(this, &AppConfig::updated, this, &AppConfig::notify);
 
     load();

src/config/AppConfig.h

@@ -67,7 +67,9 @@ class AppConfig :
 
         ConvolverDefaultPath,
         VdcDefaultPath,
-        LiveprogDefaultPath
+        LiveprogDefaultPath,
+
+        SendCrashReports
     };
     Q_ENUM(Key);
 

src/crash/airbag.c

@@ -859,7 +859,7 @@ static void sigHandler(int sigNum, siginfo_t *si, void *ucontext)
     safe_printf(fd, "\n");
     printBacktrace(s_fd,s_execname);
     char sh[512] = {0};
-    (void)sprintf(sh,"{ echo '%sSystem:' & cat /proc/version & lsb_release -a; } >> %s", section, STACKTRACE_LOG);
+    (void)sprintf(sh,"{ echo '%sSystem:'; cat /proc/version; cat /var/lib/dbus/machine-id; lsb_release -a; } >> %s", section, STACKTRACE_LOG);
     (void)system(sh);
 
     if (s_cb)

src/crash/stacktrace.h

@@ -23,6 +23,7 @@ static void * OFFSET_FRAMES_BUFFER[STACK_FRAMES_BUFFERSIZE];
 static char const * EXECUTION_FILENAME;
 static int LOG_FD = 2;
 static char const * STACKTRACE_LOG = "/tmp/jamesdsp/crash.dmp";
+static char const * STACKTRACE_LOG_OLD = "/tmp/jamesdsp/crash-prev.dmp";
 /*-----------------------------------------------------------------------------------*/
 /*
  * Use add2line on the obtained addresses to get a readable sting

src/interface/fragment/FirstLaunchWizard.cpp

@@ -1,5 +1,3 @@
-#include <IAudioService.h>
-
 #include "FirstLaunchWizard.h"
 #include "ui_FirstLaunchWizard.h"
 
@@ -16,33 +14,43 @@
 #include <QTimer>
 #include <QUrl>
 
-FirstLaunchWizard::FirstLaunchWizard(IAudioService *audioService, QWidget *parent) :
+FirstLaunchWizard::FirstLaunchWizard(QWidget *parent) :
 	QWidget(parent),
-    ui(new Ui::FirstLaunchWizard),
-    audioService(audioService)
+    ui(new Ui::FirstLaunchWizard)
 {
     ui->setupUi(this);
     ui->stackedWidget->setCurrentIndex(0);
 
-	QTimer::singleShot(500, [&] {
+    QTimer::singleShot(500, this, [=] {
 		ui->p1_icon->startAnimation();
     });
-	ui->p3_icon->startAnimation();
-	ui->p4_icon->startAnimation();
+    ui->p3_icon->startAnimation();
+    ui->p3b_icon->startAnimation();
+    ui->p4_icon->startAnimation();
 
 	ui->stackedWidget->setAnimation(QEasingCurve::Type::OutCirc);
-	connect(ui->p1_next, &QPushButton::clicked, [&] {
+    connect(ui->p1_next, &QPushButton::clicked, this, [&] {
         ui->stackedWidget->slideInIdx(1);
 	});
-	connect(ui->p3_next, &QPushButton::clicked, [&] {
+    connect(ui->p3_next, &QPushButton::clicked, this, [&] {
         ui->stackedWidget->slideInIdx(2);
 	});
-	connect(ui->p4_next,     &QPushButton::clicked, [&] {
+    connect(ui->p3b_next, &QPushButton::clicked, this, [&] {
+        ui->stackedWidget->slideInIdx(3);
+    });
+    connect(ui->p4_next, &QPushButton::clicked, this, [&] {
 		emit wizardFinished();
 	});
-	connect(ui->p4_telegram, &QPushButton::clicked, [&] {
+    connect(ui->p4_telegram, &QPushButton::clicked, [] {
 		QDesktopServices::openUrl(QUrl("https://t.me/joinchat/FTKC2A2bolHkFAyO-fuPjw"));
-	});
+    });
+
+    connect(ui->p3b_viewReports, &QPushButton::clicked, [] {
+        QDesktopServices::openUrl(QUrl("https://gist.github.com/ThePBone/3c757623c31400e799ab786ad3bf0709"));
+    });
+
+    ui->p3b_rejectReports->setChecked(!AppConfig::instance().get<bool>(AppConfig::SendCrashReports));
+    ui->p3b_allowReports->setChecked(AppConfig::instance().get<bool>(AppConfig::SendCrashReports));
 
     ui->p3_systray_disable->setChecked(!AppConfig::instance().get<bool>(AppConfig::TrayIconEnabled));
     ui->p3_systray_enable->setChecked(AppConfig::instance().get<bool>(AppConfig::TrayIconEnabled));
@@ -54,6 +62,9 @@ FirstLaunchWizard::FirstLaunchWizard(IAudioService *audioService, QWidget *paren
     connect(ui->p3_systray_disable, &QRadioButton::clicked, this, &FirstLaunchWizard::onSystrayRadioSelected);
     connect(ui->p3_systray_enable,  &QRadioButton::clicked, this, &FirstLaunchWizard::onSystrayRadioSelected);
     connect(ui->p3_systray_minOnBoot, &QCheckBox::stateChanged, this, &FirstLaunchWizard::onSystrayAutostartToggled);
+
+    connect(ui->p3b_rejectReports, &QRadioButton::clicked, this, &FirstLaunchWizard::onCrashReportRadioSelected);
+    connect(ui->p3b_allowReports,  &QRadioButton::clicked, this, &FirstLaunchWizard::onCrashReportRadioSelected);
 }
 
 FirstLaunchWizard::~FirstLaunchWizard()
@@ -72,11 +83,6 @@ void FirstLaunchWizard::showEvent(QShowEvent *ev)
 
 void FirstLaunchWizard::onSystrayRadioSelected()
 {
-    if (lockslot)
-    {
-        return;
-    }
-
     AppConfig::instance().set(AppConfig::TrayIconEnabled, ui->p3_systray_enable->isChecked());
     ui->p3_systray_minOnBoot->setEnabled(ui->p3_systray_enable->isChecked());
 }
@@ -95,3 +101,8 @@ void FirstLaunchWizard::onSystrayAutostartToggled(bool isChecked)
         QFile(path).remove();
     }
 }
+
+void FirstLaunchWizard::onCrashReportRadioSelected()
+{
+    AppConfig::instance().set(AppConfig::SendCrashReports, ui->p3b_allowReports->isChecked());
+}

src/interface/fragment/FirstLaunchWizard.h

@@ -17,7 +17,7 @@ class FirstLaunchWizard :
 	Q_OBJECT
 
 public:
-    explicit FirstLaunchWizard(IAudioService *audioService,QWidget *parent = nullptr);
+    explicit FirstLaunchWizard(QWidget *parent = nullptr);
 	~FirstLaunchWizard();
 
 protected:
@@ -29,11 +29,10 @@ class FirstLaunchWizard :
 private slots:
     void onSystrayRadioSelected();
     void onSystrayAutostartToggled(bool isChecked);
+    void onCrashReportRadioSelected();
 
 private:
-	Ui::FirstLaunchWizard *ui;
-	bool lockslot = false;
-    IAudioService* audioService;
+    Ui::FirstLaunchWizard *ui;
 
 };