Add openUrl fallback solutions

Author: timschneeb

src/MainWindow.cpp

@@ -40,9 +40,9 @@
 #include <eeleditor.h>
 #include <AeqSelector.h>
 #include <LiquidEqualizerWidget.h>
+#include <utils/DesktopServices.h>
 //#include <spectrograph.h>
 
-#include <QDesktopServices>
 #include <QButtonGroup>
 #include <QClipboard>
 #include <QDebug>
@@ -388,13 +388,8 @@ MainWindow::MainWindow(bool     statupInTray,
         installUnitData();
 
         if (debuggerIsAttached() || system("which ddctoolbox > /dev/null 2>&1")) { // Workaround: do not call system() when GDB is attached
-            connect(ui->ddctoolbox_install, &QAbstractButton::clicked, []{
-                int ret = system("xdg-open https://github.com/thepbone/DDCToolbox"); // QDesktopServices::openUrl broken on some KDE systems with Qt 5.15
-                if(ret > 0)
-                {
-                    Log::error("MainWindow: xdg-open failed. Trying gio instead.");
-                    system("gio open https://github.com/thepbone/DDCToolbox");
-                }
+            connect(ui->ddctoolbox_install, &QAbstractButton::clicked, [this]{
+                DesktopServices::openUrl("https://github.com/thepbone/DDCToolbox", this);
             });
         } else {
             ui->ddctoolbox_install->setText("Launch application");

src/interface/fragment/FirstLaunchWizard.cpp

@@ -14,6 +14,8 @@
 #include <QTimer>
 #include <QUrl>
 
+#include <utils/DesktopServices.h>
+
 FirstLaunchWizard::FirstLaunchWizard(QWidget *parent) :
 	QWidget(parent),
     ui(new Ui::FirstLaunchWizard)
@@ -41,12 +43,12 @@ FirstLaunchWizard::FirstLaunchWizard(QWidget *parent) :
     connect(ui->p4_next, &QPushButton::clicked, this, [&] {
 		emit wizardFinished();
 	});
-    connect(ui->p4_telegram, &QPushButton::clicked, [] {
-		QDesktopServices::openUrl(QUrl("https://t.me/joinchat/FTKC2A2bolHkFAyO-fuPjw"));
+    connect(ui->p4_telegram, &QPushButton::clicked, [this] {
+        DesktopServices::openUrl("https://t.me/joinchat/FTKC2A2bolHkFAyO-fuPjw", this);
     });
 
-    connect(ui->p3b_viewReports, &QPushButton::clicked, [] {
-        QDesktopServices::openUrl(QUrl("https://gist.github.com/ThePBone/3c757623c31400e799ab786ad3bf0709"));
+    connect(ui->p3b_viewReports, &QPushButton::clicked, [this] {
+        DesktopServices::openUrl("https://gist.github.com/ThePBone/3c757623c31400e799ab786ad3bf0709", this);
     });
 
     ui->p3b_rejectReports->setChecked(!AppConfig::instance().get<bool>(AppConfig::SendCrashReports));

src/interface/fragment/SettingsFragment.cpp

@@ -11,13 +11,13 @@
 #include "interface/TrayIcon.h"
 #include "MainWindow.h"
 #include "utils/AutoStartManager.h"
+#include "utils/DesktopServices.h"
 
 #include <AeqSelector.h>
 
 #include <AeqPackageManager.h>
 #include <QCloseEvent>
 #include <QDebug>
-#include <QDesktopServices>
 #include <QGraphicsOpacityEffect>
 #include <QMessageBox>
 #include <QProcess>
@@ -428,7 +428,7 @@ void SettingsFragment::onLiveprogAutoExtractToggled()
 
 void SettingsFragment::onGithubLinkClicked()
 {
-    QDesktopServices::openUrl(QUrl("https://github.com/Audio4Linux/JDSP4Linux"));
+    DesktopServices::openUrl("https://github.com/Audio4Linux/JDSP4Linux", this);
 }
 
 void SettingsFragment::onAeqDatabaseManageClicked()

src/src.pro

@@ -80,6 +80,7 @@ SOURCES += \
     main.cpp \
     utils/AutoStartManager.cpp \
     utils/CrashReportSender.cpp \
+    utils/DesktopServices.cpp \
     utils/Log.cpp \
     utils/SingleInstanceMonitor.cpp \
     utils/dbus/ClientProxy.cpp \
@@ -156,6 +157,7 @@ HEADERS += \
     utils/AutoStartManager.h \
     utils/CrashReportSender.h \
     utils/DebuggerUtils.h \
+    utils/DesktopServices.h \
     utils/Log.h \
     utils/SingleInstanceMonitor.h \
     utils/VersionMacros.h \

src/utils/DesktopServices.cpp

@@ -0,0 +1,29 @@
+#include "DesktopServices.h"
+
+#include "utils/Log.h"
+
+#include <QMessageBox>
+
+bool DesktopServices::openUrl(const QString &url, QWidget* parent)
+{
+    // QDesktopServices::openUrl broken on some KDE systems with Qt 5.15
+    if(system(QString("xdg-open %1").arg(url).toStdString().c_str()) > 0)
+    {
+        Log::warning("DesktopServices::openUrl: xdg-open failed. Trying gio instead.");
+        if(system(QString("gio open %1").arg(url).toStdString().c_str()) > 0)
+        {
+            Log::warning("DesktopServices::openUrl: gio failed. Trying kde-open5 instead.");
+            if(system(QString("kde-open5 %1").arg(url).toStdString().c_str()) > 0)
+            {
+                if(parent != nullptr)
+                {
+                    QMessageBox::critical(parent, "Something went wrong", "Failed to open URL using 'xdg-open', 'gio open', and 'kde-open5'.\n"
+                                                                          "Please copy this URL manually: " + url);
+                }
+                return false;
+            }
+        }
+    }
+
+    return true;
+}

src/utils/DesktopServices.h

@@ -0,0 +1,14 @@
+#ifndef DESKTOPSERVICES_H
+#define DESKTOPSERVICES_H
+
+#include <QString>
+
+class QWidget;
+
+class DesktopServices
+{
+public:
+    static bool openUrl(const QString& url, QWidget *parent = nullptr);
+};
+
+#endif // DESKTOPSERVICES_H