Add option to disable crash-handler at compile time

Author: timschneeb

src/Global.h

@@ -0,0 +1,3 @@
+#if defined(Q_OS_UNIX) && /*defined(QT_NO_DEBUG) &&*/ !defined(NO_CRASH_HANDLER)
+#define ENABLE_CRASH_HANDLER
+#endif

src/interface/fragment/FirstLaunchWizard.cpp

@@ -14,6 +14,8 @@
 #include <QTimer>
 #include <QUrl>
 
+#include "Global.h"
+
 #include <utils/DesktopServices.h>
 
 FirstLaunchWizard::FirstLaunchWizard(QWidget *parent) :
@@ -35,7 +37,11 @@ FirstLaunchWizard::FirstLaunchWizard(QWidget *parent) :
         ui->stackedWidget->slideInIdx(1);
 	});
     connect(ui->p3_next, &QPushButton::clicked, this, [&] {
+#ifdef ENABLE_CRASH_HANDLER
         ui->stackedWidget->slideInIdx(2);
+#else
+        ui->stackedWidget->slideInIdx(3);
+#endif
 	});
     connect(ui->p3b_next, &QPushButton::clicked, this, [&] {
         ui->stackedWidget->slideInIdx(3);

src/interface/fragment/SettingsFragment.cpp

@@ -13,6 +13,8 @@
 #include "utils/AutoStartManager.h"
 #include "utils/DesktopServices.h"
 
+#include "Global.h"
+
 #include <AeqSelector.h>
 
 #include <AeqPackageManager.h>
@@ -142,6 +144,10 @@ SettingsFragment::SettingsFragment(TrayIcon *trayIcon,
 #ifndef QT_NO_SYSTEMTRAYICON
 	}
 #endif
+
+#ifndef ENABLE_CRASH_HANDLER
+    ui->crashShareGroup->setVisible(false);
+#endif
 }
 
 SettingsFragment::~SettingsFragment()

src/interface/fragment/SettingsFragment.ui

@@ -578,7 +578,7 @@
        <widget class="QWidget" name="page">
         <layout class="QVBoxLayout" name="verticalLayout_9">
          <item>
-          <widget class="QGroupBox" name="groupBox_2">
+          <widget class="QGroupBox" name="crashShareGroup">
            <property name="title">
             <string>Share crash reports</string>
            </property>

src/main.cpp

@@ -12,11 +12,7 @@
 #include <QTextStream>
 #include <QSessionManager>
 
-#define FORCE_CRASH_HANDLER
-
-#if defined(Q_OS_UNIX) && defined(QT_NO_DEBUG) || defined(FORCE_CRASH_HANDLER)
-#define ENABLE_CRASH_HANDLER
-#endif
+#include "Global.h"
 
 #ifdef ENABLE_CRASH_HANDLER
 #include "crash/airbag.h"
@@ -137,6 +133,7 @@ int main(int   argc,
         return 0;
     }
 
+#ifdef ENABLE_CRASH_HANDLER
     if(lastSessionCrashed)
     {
         Log::information("Last session crashed unexpectedly. A crash report has been saved here: " + QString(STACKTRACE_LOG_OLD));
@@ -147,6 +144,7 @@ int main(int   argc,
            CrashReportSender::upload(Log::pathOld(), QString(STACKTRACE_LOG_OLD)); /* fire and forget */
         }
     }
+#endif
 
     // Prepare DspConfig based on cmdline argument
     DspConfig::instance(parser.isSet(watch));

src/src.pro

@@ -104,6 +104,7 @@ FORMS += \
     MainWindow.ui
 
 HEADERS += \
+    Global.h \
     config/AppConfig.h \
     config/ConfigContainer.h \
     config/ConfigIO.h \