fix: Add option to volume control the virtual sink (not recommended)

Author: timschneeb

src/audio/pipewire/PipewireAudioService.cpp

@@ -14,7 +14,7 @@ PipewireAudioService::PipewireAudioService()
 {
     Glib::init();
 
-    mgr = std::make_unique<PwPipelineManager>();
+    mgr = std::make_unique<PwPipelineManager>(AppConfig::instance().get<bool>(AppConfig::AudioVirtualSinkForceMaxValue));
     appMgr = std::make_unique<PwAppManager>(mgr.get());
     plugin = new PwJamesDspPlugin(mgr.get(), this);
     effects = std::make_unique<FilterContainer>(mgr.get(), plugin, &AppConfig::instance());

src/audio/pipewire/PwPipelineManager.cpp

@@ -1432,7 +1432,7 @@ const struct pw_registry_events registry_events = {
 
 }  // namespace
 
-PwPipelineManager::PwPipelineManager() : header_version(pw_get_headers_version()), library_version(pw_get_library_version()) {
+PwPipelineManager::PwPipelineManager(bool sinkForceMaxVolume) : header_version(pw_get_headers_version()), library_version(pw_get_library_version()) {
   pw_init(nullptr, nullptr);
 
   spa_zero(core_listener);
@@ -1494,7 +1494,7 @@ PwPipelineManager::PwPipelineManager() : header_version(pw_get_headers_version()
   pw_properties_set(props_sink, "factory.name", "support.null-audio-sink");
   pw_properties_set(props_sink, PW_KEY_MEDIA_CLASS, tags::pipewire::media_class::sink);
   pw_properties_set(props_sink, "audio.position", "FL,FR");
-  pw_properties_set(props_sink, "monitor.channel-volumes", "false");
+  pw_properties_set(props_sink, "monitor.channel-volumes", !sinkForceMaxVolume ? "true" : "false");
 
   proxy_stream_output_sink = static_cast<pw_proxy*>(
       pw_core_create_object(core, "adapter", PW_TYPE_INTERFACE_Node, PW_VERSION_NODE, &props_sink->dict, 0));

src/audio/pipewire/PwPipelineManager.h

@@ -50,7 +50,7 @@
 
 class PwPipelineManager {
  public:
-  PwPipelineManager();
+  PwPipelineManager(bool sinkForceMaxVolume);
   PwPipelineManager(const PwPipelineManager&) = delete;
   auto operator=(const PwPipelineManager&) -> PwPipelineManager& = delete;
   PwPipelineManager(const PwPipelineManager&&) = delete;

src/config/AppConfig.cpp

@@ -42,6 +42,7 @@ AppConfig::AppConfig()
     DEFINE_KEY(AudioAppBlocklist, QStringList());
     DEFINE_KEY(AudioAppBlocklistInvert, false);
     DEFINE_KEY(AudioInactivityTimeout, 10);
+    DEFINE_KEY(AudioVirtualSinkForceMaxValue, true);
 
     DEFINE_KEY(BenchmarkOnBoot, false);
     DEFINE_KEY(BenchmarkCacheC0, "");

src/config/AppConfig.h

@@ -66,6 +66,7 @@ class AppConfig :
         AudioAppBlocklist,
         AudioAppBlocklistInvert,
         AudioInactivityTimeout,
+        AudioVirtualSinkForceMaxValue,
 
         BenchmarkOnBoot,
         BenchmarkCacheC0,

src/interface/fragment/SettingsFragment.cpp

@@ -99,8 +99,9 @@ SettingsFragment::SettingsFragment(TrayIcon *trayIcon,
      * Audio processing
      */
     connect(ui->benchmarkOnBoot, &QCheckBox::clicked, this, &SettingsFragment::onBenchmarkOnBootToggled);
-    connect(ui->benchmarkNow, &QCheckBox::clicked, this, &SettingsFragment::onBenchmarkRunClicked);
-    connect(ui->benchmarkClear, &QCheckBox::clicked, this, &SettingsFragment::onBenchmarkClearClicked);
+    connect(ui->benchmarkNow, &QPushButton::clicked, this, &SettingsFragment::onBenchmarkRunClicked);
+    connect(ui->benchmarkClear, &QPushButton::clicked, this, &SettingsFragment::onBenchmarkClearClicked);
+    connect(ui->sinkAllowVolumeControl, &QCheckBox::clicked, this, &SettingsFragment::onSinkAllowVolumeControlClicked);
     connect(_audioService, &IAudioService::benchmarkDone, this, [this]{ updateBenchmarkStatus(tr("benchmark data loaded")); });
 
 	/*
@@ -267,6 +268,7 @@ void SettingsFragment::refreshAll()
     ui->eq_alwaysdrawhandles->setChecked(AppConfig::instance().get<bool>(AppConfig::EqualizerShowHandles));
 
     ui->benchmarkOnBoot->setChecked(AppConfig::instance().get<bool>(AppConfig::BenchmarkOnBoot));
+    ui->sinkAllowVolumeControl->setChecked(!AppConfig::instance().get<bool>(AppConfig::AudioVirtualSinkForceMaxValue));
 
     ui->blocklistInvert->blockSignals(true);
     ui->blocklistInvert->setChecked(AppConfig::instance().get<bool>(AppConfig::AudioAppBlocklistInvert));
@@ -460,6 +462,11 @@ void SettingsFragment::onBenchmarkClearClicked()
     updateBenchmarkStatus(tr("no benchmark data stored"));
 }
 
+void SettingsFragment::onSinkAllowVolumeControlClicked()
+{
+    AppConfig::instance().set(AppConfig::AudioVirtualSinkForceMaxValue, !ui->sinkAllowVolumeControl->isChecked());
+}
+
 void SettingsFragment::onLiveprogAutoExtractToggled()
 {
     AppConfig::instance().set(AppConfig::LiveprogAutoExtract, ui->liveprog_autoextract->isChecked());

src/interface/fragment/SettingsFragment.h

@@ -69,6 +69,7 @@ private slots:
     void onBenchmarkOnBootToggled();
     void onBenchmarkRunClicked();
     void onBenchmarkClearClicked();
+    void onSinkAllowVolumeControlClicked();
     void onLiveprogAutoExtractToggled();
     void onGithubLinkClicked();
     void onAeqDatabaseManageClicked();

src/interface/fragment/SettingsFragment.ui

@@ -7,7 +7,7 @@
     <x>0</x>
     <y>0</y>
     <width>685</width>
-    <height>365</height>
+    <height>400</height>
    </rect>
   </property>
   <property name="minimumSize">
@@ -391,6 +391,41 @@
            </layout>
           </widget>
          </item>
+         <item>
+          <widget class="QGroupBox" name="groupBox_2">
+           <property name="title">
+            <string>Workarounds</string>
+           </property>
+           <layout class="QVBoxLayout" name="verticalLayout_13">
+            <item>
+             <widget class="QCheckBox" name="sinkAllowVolumeControl">
+              <property name="sizePolicy">
+               <sizepolicy hsizetype="Fixed" vsizetype="Fixed">
+                <horstretch>0</horstretch>
+                <verstretch>0</verstretch>
+               </sizepolicy>
+              </property>
+              <property name="text">
+               <string>Allow volume control of the virtual sink device</string>
+              </property>
+             </widget>
+            </item>
+            <item>
+             <widget class="QLabel" name="label_10">
+              <property name="enabled">
+               <bool>false</bool>
+              </property>
+              <property name="text">
+               <string>Restart required to apply changes. May cause audio loss in some cases.</string>
+              </property>
+              <property name="wordWrap">
+               <bool>true</bool>
+              </property>
+             </widget>
+            </item>
+           </layout>
+          </widget>
+         </item>
          <item>
           <spacer name="verticalSpacer_5">
            <property name="orientation">